All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Cesati <marcocesati@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	devel@driverdev.osuosl.org
Subject: [PATCH 18/33] staging: rtl8723bs: remove typedefs in rtw_security.h
Date: Fri, 12 Mar 2021 09:26:23 +0100	[thread overview]
Message-ID: <20210312082638.25512-19-marco.cesati@gmail.com> (raw)
In-Reply-To: <20210312082638.25512-1-marco.cesati@gmail.com>

This commit fixes the following checkpatch.pl warning:

    WARNING: do not add new typedefs
    #87: FILE: include/rtw_security.h:87:
    +typedef struct _RT_PMKID_LIST {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_security.h  | 6 +++---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c    | 2 +-
 drivers/staging/rtl8723bs/os_dep/mlme_linux.c     | 8 ++++----
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
index 85ffd4ec4ce5..6c1483989ea3 100644
--- a/drivers/staging/rtl8723bs/include/rtw_security.h
+++ b/drivers/staging/rtl8723bs/include/rtw_security.h
@@ -84,14 +84,14 @@ union Keytype {
 };
 
 
-typedef struct _RT_PMKID_LIST {
+struct RT_PMKID_LIST {
 	u8 				bUsed;
 	u8 				Bssid[6];
 	u8 				PMKID[16];
 	u8 				SsidBuf[33];
 	u8 *ssid_octet;
 	u16 					ssid_length;
-} RT_PMKID_LIST, *PRT_PMKID_LIST;
+};
 
 
 struct security_priv {
@@ -166,7 +166,7 @@ struct security_priv {
 	u32 btkip_countermeasure_time;
 
 	/*  For WPA2 Pre-Authentication. */
-	RT_PMKID_LIST		PMKIDList[NUM_PMKID_CACHE];	/*  Renamed from PreAuthKey[NUM_PRE_AUTH_KEY]. Annie, 2006-10-13. */
+	struct RT_PMKID_LIST		PMKIDList[NUM_PMKID_CACHE];	/*  Renamed from PreAuthKey[NUM_PRE_AUTH_KEY]. Annie, 2006-10-13. */
 	u8 		PMKIDIndex;
 
 	u8 bWepDefaultKeyIdxSet;
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index ff164a8c8679..f0e38303022d 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -2346,7 +2346,7 @@ static int cfg80211_rtw_flush_pmksa(struct wiphy *wiphy,
 
 	DBG_871X(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(ndev));
 
-	memset(&psecuritypriv->PMKIDList[0], 0x00, sizeof(RT_PMKID_LIST) * NUM_PMKID_CACHE);
+	memset(&psecuritypriv->PMKIDList[0], 0x00, sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
 	psecuritypriv->PMKIDIndex = 0;
 
 	return 0;
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 78ba2423ed65..e1d168d6ac86 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -999,7 +999,7 @@ static int rtw_wx_set_pmkid(struct net_device *dev,
 	        }
 	} else if (pPMK->cmd == IW_PMKSA_FLUSH) {
 		DBG_871X("[rtw_wx_set_pmkid] IW_PMKSA_FLUSH!\n");
-		memset(&psecuritypriv->PMKIDList[0], 0x00, sizeof(RT_PMKID_LIST) * NUM_PMKID_CACHE);
+		memset(&psecuritypriv->PMKIDList[0], 0x00, sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
 		psecuritypriv->PMKIDIndex = 0;
 		intReturn = true;
 	}
diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
index 20899b2cff43..ac3ae26fc385 100644
--- a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
@@ -65,7 +65,7 @@ void rtw_os_indicate_scan_done(struct adapter *padapter, bool aborted)
 	indicate_wx_scan_complete_event(padapter);
 }
 
-static RT_PMKID_LIST   backupPMKIDList[NUM_PMKID_CACHE];
+static struct RT_PMKID_LIST   backupPMKIDList[NUM_PMKID_CACHE];
 void rtw_reset_securitypriv(struct adapter *adapter)
 {
 	u8 backupPMKIDIndex = 0;
@@ -84,7 +84,7 @@ void rtw_reset_securitypriv(struct adapter *adapter)
 		/*  Backup the btkip_countermeasure information. */
 		/*  When the countermeasure is trigger, the driver have to disconnect with AP for 60 seconds. */
 
-		memcpy(&backupPMKIDList[0], &adapter->securitypriv.PMKIDList[0], sizeof(RT_PMKID_LIST) * NUM_PMKID_CACHE);
+		memcpy(&backupPMKIDList[0], &adapter->securitypriv.PMKIDList[0], sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
 		backupPMKIDIndex = adapter->securitypriv.PMKIDIndex;
 		backupTKIPCountermeasure = adapter->securitypriv.btkip_countermeasure;
 		backupTKIPcountermeasure_time = adapter->securitypriv.btkip_countermeasure_time;
@@ -96,7 +96,7 @@ void rtw_reset_securitypriv(struct adapter *adapter)
 
 		/*  Added by Albert 2009/02/18 */
 		/*  Restore the PMK information to securitypriv structure for the following connection. */
-		memcpy(&adapter->securitypriv.PMKIDList[0], &backupPMKIDList[0], sizeof(RT_PMKID_LIST) * NUM_PMKID_CACHE);
+		memcpy(&adapter->securitypriv.PMKIDList[0], &backupPMKIDList[0], sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
 		adapter->securitypriv.PMKIDIndex = backupPMKIDIndex;
 		adapter->securitypriv.btkip_countermeasure = backupTKIPCountermeasure;
 		adapter->securitypriv.btkip_countermeasure_time = backupTKIPcountermeasure_time;
@@ -127,7 +127,7 @@ void rtw_reset_securitypriv(struct adapter *adapter)
 
 void rtw_os_indicate_disconnect(struct adapter *adapter)
 {
-	/* RT_PMKID_LIST   backupPMKIDList[ NUM_PMKID_CACHE ]; */
+	/* struct RT_PMKID_LIST   backupPMKIDList[ NUM_PMKID_CACHE ]; */
 
 	netif_carrier_off(adapter->pnetdev); /*  Do it first for tx broadcast pkt after disconnection issue! */
 
-- 
2.30.2

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2021-03-12  8:30 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  8:26 [PATCHSET] remove 153 useless typedefs in staging/rtl8723bs Marco Cesati
2021-03-12  8:26 ` [PATCH 01/33] staging: rtl8723bs: remove typedefs in HalBtcOutSrc.h Marco Cesati
2021-03-15 14:14   ` Dan Carpenter
2021-03-15 14:21     ` Marco Cesati
2021-03-12  8:26 ` [PATCH 02/33] staging: rtl8723bs: remove typedefs in rtw_mlme.h Marco Cesati
2021-03-15 14:17   ` Dan Carpenter
2021-03-12  8:26 ` [PATCH 03/33] staging: rtl8723bs: remove typedefs in odm.h Marco Cesati
2021-03-12  8:26 ` [PATCH 04/33] staging: rtl8723bs: remove typedefs in odm_CfoTracking.h Marco Cesati
2021-03-12  8:26 ` [PATCH 05/33] staging: rtl8723bs: remove typedefs in odm_NoiseMonitor.h Marco Cesati
2021-03-12  8:26 ` [PATCH 06/33] staging: rtl8723bs: remove typedefs in odm_interface.h Marco Cesati
2021-03-12  8:26 ` [PATCH 07/33] staging: rtl8723bs: remove typedefs in odm_EdcaTurboCheck.h Marco Cesati
2021-03-12  8:26 ` [PATCH 08/33] staging: rtl8723bs: remove typedefs in odm_HWConfig.h Marco Cesati
2021-03-12  8:26 ` [PATCH 09/33] staging: rtl8723bs: remove typedefs in odm_types.h Marco Cesati
2021-03-12  8:26 ` [PATCH 10/33] staging: rtl8723bs: remove typedefs in rtw_eeprom.h Marco Cesati
2021-03-12  8:26 ` [PATCH 11/33] staging: rtl8723bs: remove typedefs in hal_com.h Marco Cesati
2021-03-12  8:26 ` [PATCH 12/33] staging: rtl8723bs: remove typedefs in drv_types.h Marco Cesati
2021-03-12  8:26 ` [PATCH 13/33] staging: rtl8723bs: remove typedefs in rtw_ht.h Marco Cesati
2021-03-12  8:26 ` [PATCH 14/33] staging: rtl8723bs: remove typedefs in rtw_ioctl_set.h Marco Cesati
2021-03-12  8:26 ` [PATCH 15/33] staging: rtl8723bs: remove typedefs in wlan_bssdef.h Marco Cesati
2021-03-12  8:26 ` [PATCH 16/33] staging: rtl8723bs: remove typedefs in rtw_mp.h Marco Cesati
2021-03-12  8:26 ` [PATCH 17/33] staging: rtl8723bs: remove typedefs in osdep_service.h Marco Cesati
2021-03-12  8:26 ` Marco Cesati [this message]
2021-03-12  8:26 ` [PATCH 19/33] staging: rtl8723bs: remove typedefs in hal_com_h2c.h Marco Cesati
2021-03-12  8:26 ` [PATCH 20/33] staging: rtl8723bs: remove typedefs in rtl8723b_xmit.h Marco Cesati
2021-03-12  8:26 ` [PATCH 21/33] staging: rtl8723bs: remove typedefs in HalVerDef.h Marco Cesati
2021-03-12  8:26 ` [PATCH 22/33] staging: rtl8723bs: remove typedefs in rtl8723b_hal.h Marco Cesati
2021-03-12  8:26 ` [PATCH 23/33] staging: rtl8723bs: remove typedefs in rtw_mlme_ext.h Marco Cesati
2021-03-12  8:26 ` [PATCH 24/33] staging: rtl8723bs: remove typedefs in HalPwrSeqCmd.h Marco Cesati
2021-03-12  8:26 ` [PATCH 25/33] staging: rtl8723bs: remove typedefs in sta_info.h Marco Cesati
2021-03-12  8:26 ` [PATCH 26/33] staging: rtl8723bs: remove typedefs in ieee80211.h Marco Cesati
2021-03-12  8:26 ` [PATCH 27/33] staging: rtl8723bs: remove typedefs in basic_types.h Marco Cesati
2021-03-12  8:26 ` [PATCH 28/33] staging: rtl8723bs: remove typedefs in osdep_service_linux.h Marco Cesati
2021-03-12  8:26 ` [PATCH 29/33] staging: rtl8723bs: remove typedefs in rtw_efuse.h Marco Cesati
2021-03-12  8:26 ` [PATCH 30/33] staging: rtl8723bs: remove typedefs in hal_btcoex.h Marco Cesati
2021-03-12  8:26 ` [PATCH 31/33] staging: rtl8723bs: remove typedefs in odm_DIG.h Marco Cesati
2021-03-12  8:26 ` [PATCH 32/33] staging: rtl8723bs: remove typedefs in hal_btcoex.c Marco Cesati
2021-03-12  8:26 ` [PATCH 33/33] staging: rtl8723bs: remove typedefs in odm_DynamicBBPowerSaving.h Marco Cesati
2021-03-12 16:25 ` [PATCHSET] remove 153 useless typedefs in staging/rtl8723bs Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312082638.25512-19-marco.cesati@gmail.com \
    --to=marcocesati@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.