From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37359C433E0 for ; Fri, 12 Mar 2021 09:21:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6E4864FE2 for ; Fri, 12 Mar 2021 09:21:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6E4864FE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKdzX-0007ZF-5k for qemu-devel@archiver.kernel.org; Fri, 12 Mar 2021 04:21:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKdnT-0001Rw-81 for qemu-devel@nongnu.org; Fri, 12 Mar 2021 04:09:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKdnO-0004aY-W5 for qemu-devel@nongnu.org; Fri, 12 Mar 2021 04:09:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615540158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WY85PheJGUIWF/pnhP6dVvDiD4HcfYM0EzZHn/3af1Q=; b=CTiYdFKL/j/WjZstMcsJskmN+R0b/DWurxXAG6YwDFnRAZ8YHBIW45b56JyI2Ry00KVqLo NZO0iEsnbXoocwGS4/gmpBRZeyaHvyG48UvC8WtLH5uUpzDrmHkZ9YRVU/flWEhvz3iEVa Y7lebZ0ar6LCOiaxKPhafGLFP1ZR3no= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-MPHRuJuRNoS4oePmyF4Xog-1; Fri, 12 Mar 2021 04:09:16 -0500 X-MC-Unique: MPHRuJuRNoS4oePmyF4Xog-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E04683DD20; Fri, 12 Mar 2021 09:09:15 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF862648A8; Fri, 12 Mar 2021 09:09:03 +0000 (UTC) Date: Fri, 12 Mar 2021 10:09:00 +0100 From: Andrew Jones To: Claudio Fontana Subject: Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command Message-ID: <20210312090900.yadfwhwoa34pdluk@kamzik.brq.redhat.com> References: <20210311231202.1536040-1-philmd@redhat.com> <20210311231202.1536040-2-philmd@redhat.com> <651baead-dcc3-c0ef-f5dd-cda36c8d6599@redhat.com> <20210312084816.pnenjcbdjzwu3z54@kamzik.brq.redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=drjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Eduardo Habkost , "Michael S. Tsirkin" , libvir-list@redhat.com, Richard Henderson , QEMU , Markus Armbruster , "open list:ARM" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Igor Mammedov , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Mar 12, 2021 at 09:52:33AM +0100, Claudio Fontana wrote: > On 3/12/21 9:48 AM, Andrew Jones wrote: > > On Fri, Mar 12, 2021 at 09:11:45AM +0100, Thomas Huth wrote: > >> On 12/03/2021 08.42, Marc-André Lureau wrote: > >>> > >>> > >>> On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé > >>> > wrote: > >>> > >> [...] > >>> +## > >>> +# @AcceleratorInfo: > >>> +# > >>> +# Accelerator information. > >>> +# > >>> +# @name: The accelerator name. > >>> +# > >>> +# Since: 6.0 > >>> +## > >>> +{ 'union': 'AcceleratorInfo', > >>> +  'base': {'name': 'Accelerator'}, > >>> +  'discriminator': 'name', > >>> +  'data': { } } > >>> > >>> + > >>> > >>> > >>> Making room for future details, why not. > >> > >> I think we definitely need the additional data section here: For KVM on > >> POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on > >> MIPS it would be good to know whether it's KVM_VM_MIPS_VZ or KVM_VM_MIPS_TE, > >> for KVM on x86 whether it's the AMD flavor or Intel, ... > > > > Could also pre-expand all of these and list them individually. > > > > Let us consider simplicity for the reader, and which use cases we expect for this. What do you mean by "reader"? If you mean the QMP client that needs this information, then I can't think of anything more simple than a single list of booleans with descriptive names to process. If you mean that the expected use cases don't care about all those variants, then you don't need to worry about that. Only the ones compiled in will be in the list. The expected use cases will never see the other ones. Thanks, drew