From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 1/6] soc/tegra: Add devm_tegra_core_dev_init_opp_table()
Date: Fri, 12 Mar 2021 13:14:54 +0800 [thread overview]
Message-ID: <202103121343.TuYcoLAb-lkp@intel.com> (raw)
In-Reply-To: <20210311231208.18180-2-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5185 bytes --]
Hi Dmitry,
I love your patch! Yet something to improve:
[auto build test ERROR on tegra/for-next]
[also build test ERROR on v5.12-rc2 next-20210311]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/soc-tegra-Add-devm_tegra_core_dev_init_opp_table/20210312-081244
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8d5ea5b946a1399d7490fa992733a737c4bbd594
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Osipenko/soc-tegra-Add-devm_tegra_core_dev_init_opp_table/20210312-081244
git checkout 8d5ea5b946a1399d7490fa992733a737c4bbd594
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/soc/tegra/common.c: In function 'devm_tegra_core_dev_init_opp_table':
>> drivers/soc/tegra/common.c:123:14: error: implicit declaration of function 'devm_pm_opp_set_clkname'; did you mean 'dev_pm_opp_set_clkname'? [-Werror=implicit-function-declaration]
123 | opp_table = devm_pm_opp_set_clkname(dev, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~
| dev_pm_opp_set_clkname
drivers/soc/tegra/common.c:123:12: warning: assignment to 'struct opp_table *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
123 | opp_table = devm_pm_opp_set_clkname(dev, NULL);
| ^
>> drivers/soc/tegra/common.c:139:14: error: implicit declaration of function 'devm_pm_opp_set_supported_hw'; did you mean 'dev_pm_opp_set_supported_hw'? [-Werror=implicit-function-declaration]
139 | opp_table = devm_pm_opp_set_supported_hw(dev, &hw_version, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| dev_pm_opp_set_supported_hw
drivers/soc/tegra/common.c:139:12: warning: assignment to 'struct opp_table *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
139 | opp_table = devm_pm_opp_set_supported_hw(dev, &hw_version, 1);
| ^
>> drivers/soc/tegra/common.c:153:8: error: implicit declaration of function 'devm_pm_opp_of_add_table'; did you mean 'dev_pm_opp_of_add_table'? [-Werror=implicit-function-declaration]
153 | err = devm_pm_opp_of_add_table(dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| dev_pm_opp_of_add_table
cc1: some warnings being treated as errors
vim +123 drivers/soc/tegra/common.c
105
106 /**
107 * devm_tegra_core_dev_init_opp_table() - initialize OPP table
108 * @dev: device for which OPP table is initialized
109 * @params: pointer to the OPP table configuration
110 *
111 * This function will initialize OPP table and sync OPP state of a Tegra SoC
112 * core device.
113 *
114 * Return: 0 on success or errorno.
115 */
116 int devm_tegra_core_dev_init_opp_table(struct device *dev,
117 struct tegra_core_opp_params *params)
118 {
119 struct opp_table *opp_table;
120 u32 hw_version;
121 int err;
122
> 123 opp_table = devm_pm_opp_set_clkname(dev, NULL);
124 if (IS_ERR(opp_table)) {
125 dev_err(dev, "failed to set OPP clk %pe\n", opp_table);
126 return PTR_ERR(opp_table);
127 }
128
129 /* Tegra114+ doesn't support OPP yet */
130 if (!of_machine_is_compatible("nvidia,tegra20") &&
131 !of_machine_is_compatible("nvidia,tegra30"))
132 return -ENODEV;
133
134 if (of_machine_is_compatible("nvidia,tegra20"))
135 hw_version = BIT(tegra_sku_info.soc_process_id);
136 else
137 hw_version = BIT(tegra_sku_info.soc_speedo_id);
138
> 139 opp_table = devm_pm_opp_set_supported_hw(dev, &hw_version, 1);
140 if (IS_ERR(opp_table)) {
141 dev_err(dev, "failed to set OPP supported HW: %pe\n", opp_table);
142 return PTR_ERR(opp_table);
143 }
144
145 /*
146 * Older device-trees have an empty OPP table, hence we will get
147 * -ENODEV from devm_pm_opp_of_add_table() for the older DTBs.
148 *
149 * The OPP table presence also varies per-device and depending
150 * on a SoC generation, hence -ENODEV is expected to happen for
151 * the newer DTs as well.
152 */
> 153 err = devm_pm_opp_of_add_table(dev);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54196 bytes --]
next prev parent reply other threads:[~2021-03-12 5:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 23:12 [PATCH v3 0/6] NVIDIA Tegra core power domain driver and OPP helper Dmitry Osipenko
2021-03-11 23:12 ` [PATCH v3 1/6] soc/tegra: Add devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-03-12 3:29 ` kernel test robot
2021-03-12 5:14 ` kernel test robot [this message]
2021-03-11 23:12 ` [PATCH v3 2/6] soc/tegra: Add CONFIG_SOC_TEGRA_COMMON and select PM_OPP by default Dmitry Osipenko
2021-03-11 23:12 ` [PATCH v3 3/6] dt-bindings: power: tegra: Add binding for core power domain Dmitry Osipenko
2021-03-12 14:23 ` Rob Herring
2021-03-11 23:12 ` [PATCH v3 4/6] soc/tegra: Introduce core power domain driver Dmitry Osipenko
2021-03-12 4:00 ` kernel test robot
2021-03-12 12:37 ` Dmitry Osipenko
2021-03-11 23:12 ` [PATCH v3 5/6] soc/tegra: regulators: Support Core domain state syncing Dmitry Osipenko
2021-03-11 23:12 ` [PATCH v3 6/6] soc/tegra: pmc: Link children power domains to the parent domain Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103121343.TuYcoLAb-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.