From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A5AC433E6 for ; Fri, 12 Mar 2021 16:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84C6B64EC0 for ; Fri, 12 Mar 2021 16:19:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbhCLQTI (ORCPT ); Fri, 12 Mar 2021 11:19:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:40060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231894AbhCLQTA (ORCPT ); Fri, 12 Mar 2021 11:19:00 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 33FA964F80; Fri, 12 Mar 2021 16:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615565940; bh=SvjvS+eYw43j6dDZ3kTZEE/IzNK1vkwq2cjx8Oz0Kok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d1HawMuB/z5x3wCDWGqApB6ROaio1ewVhpI4NC86mDZEGMgL6Pv6NlB/E4ft3aqlW wXxCBiDCS6WDOn3suectrtQwefcgyzpPNlOmdgfYVYb6tCzIVjcBX/tdwCiSOIHABi D4/qegEXQPnrOXqu03+lrb3LpfiStsVvTsGNJIgjj0vkPP1FdC6jnZm0A0JUpYqHtL +dLBoDP1m0Lz0Gp477kunJ1RWGCM4toU4i9ALUQWF9y7jQejM7DrC3mGzBMk9MlnMk lW/sCQK279N0IxcohqHk+jIWE3P99OftRid/v/GwLgOfX3gJqQ5yRR/SL6J5LyDHW8 nNwvL0E3LgSzw== Received: by pali.im (Postfix) id E3CF07FB; Fri, 12 Mar 2021 17:18:57 +0100 (CET) Date: Fri, 12 Mar 2021 17:18:57 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Cc: Marek =?utf-8?B?QmVow7pu?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: <20210312161857.ytknen5d5zhfhtbk@pali> References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> <20210312161704.5e575906@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Friday 12 March 2021 16:53:32 Andrew Lunn wrote: > > So theoretically the turris-mox-rwtm driver can be renamed into > > something else and we can add a different compatible in order not to > > sound so turris-mox specific. > > That would be a good idea. And if possible, try to push the hardware > random number code upstream in the firmware repos, so everybody gets > it by default, not just those using your build. Who is responsible for > upstream? Marvell? Hello Andrew! The issue is that upstream Marvell repository contains only 'fuse.bin' application which is suitable only for fuse programming. I think it is not correct if this Marvell fuse application start providing other functionality not relevant to fuse programming. And Marvell does not provide any other application (publicly). So it would be needed to send it as another application, not part of 'fuse.bin'. And then it complicates build system and compile options, which is already too complicated (you need to set tons of TF-A options and prepare two sets of cross compile toolchains). But because application / firmware for MOX / Armada 3720 is actively developed on different place, I do not think that it make sense to send every change to two different locations (and wait for Marvell until review every change and include it into their repository). Such thing just increase maintenance cost at both sides. For me it looks like a better solution to provide 'wtmi_app.bin' application with HW number generator from separate repository, where it is currently developed and where it is available for a longer time. We are planning to send documentation update to Trusted-Firmware project to specify how to build Armada 3720 firmware image with our application. So people who are building Armada 3720 firmware would be able to switch from Marvell's 'fuse.bin' application to our 'wtmi_app.bin'. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B15C433E0 for ; Fri, 12 Mar 2021 16:20:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA7E564F80 for ; Fri, 12 Mar 2021 16:20:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA7E564F80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JSx61stghJZvURL3F35ejpbTHBr+0zE+7qWiEprk0Ww=; b=laGMlqkWD20wTZnjuVhc+GZ7S 3q+iBTsUvHFq6INKdN2lqp2fp1SUhVr8UqVX/fLIr1PXGIBiTCjrhcsQXE620iw3HiAVm6kFAfq8x K74/KklbuU4Vh6sLlrgVg2vQYxeztaPrpcblXqgrAnwTKA50t2O6PoOdHRJnxwRRSX8xd3/Dx/aLQ wRG+6DEut1PjB2JkhYqMyLN+WIj+jo160E4fyLQUtRvEHOL3bPHjBoY+83Q1egqGa9pVbG418gjQb zp0u+e+ppNVQgdeHz5qWBUdO+Fml0h2dzQtWA1+sXcm6vSHyjqzqXfdDFkQjlIXt8S4YxVvZRaF/P srRLHSJ6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKkVJ-00BvVv-Sx; Fri, 12 Mar 2021 16:19:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKkVE-00BvTs-Ab for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 16:19:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 33FA964F80; Fri, 12 Mar 2021 16:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615565940; bh=SvjvS+eYw43j6dDZ3kTZEE/IzNK1vkwq2cjx8Oz0Kok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d1HawMuB/z5x3wCDWGqApB6ROaio1ewVhpI4NC86mDZEGMgL6Pv6NlB/E4ft3aqlW wXxCBiDCS6WDOn3suectrtQwefcgyzpPNlOmdgfYVYb6tCzIVjcBX/tdwCiSOIHABi D4/qegEXQPnrOXqu03+lrb3LpfiStsVvTsGNJIgjj0vkPP1FdC6jnZm0A0JUpYqHtL +dLBoDP1m0Lz0Gp477kunJ1RWGCM4toU4i9ALUQWF9y7jQejM7DrC3mGzBMk9MlnMk lW/sCQK279N0IxcohqHk+jIWE3P99OftRid/v/GwLgOfX3gJqQ5yRR/SL6J5LyDHW8 nNwvL0E3LgSzw== Received: by pali.im (Postfix) id E3CF07FB; Fri, 12 Mar 2021 17:18:57 +0100 (CET) Date: Fri, 12 Mar 2021 17:18:57 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Cc: Marek =?utf-8?B?QmVow7pu?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: <20210312161857.ytknen5d5zhfhtbk@pali> References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> <20210312161704.5e575906@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_161905_415644_4F09E705 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 12 March 2021 16:53:32 Andrew Lunn wrote: > > So theoretically the turris-mox-rwtm driver can be renamed into > > something else and we can add a different compatible in order not to > > sound so turris-mox specific. > > That would be a good idea. And if possible, try to push the hardware > random number code upstream in the firmware repos, so everybody gets > it by default, not just those using your build. Who is responsible for > upstream? Marvell? Hello Andrew! The issue is that upstream Marvell repository contains only 'fuse.bin' application which is suitable only for fuse programming. I think it is not correct if this Marvell fuse application start providing other functionality not relevant to fuse programming. And Marvell does not provide any other application (publicly). So it would be needed to send it as another application, not part of 'fuse.bin'. And then it complicates build system and compile options, which is already too complicated (you need to set tons of TF-A options and prepare two sets of cross compile toolchains). But because application / firmware for MOX / Armada 3720 is actively developed on different place, I do not think that it make sense to send every change to two different locations (and wait for Marvell until review every change and include it into their repository). Such thing just increase maintenance cost at both sides. For me it looks like a better solution to provide 'wtmi_app.bin' application with HW number generator from separate repository, where it is currently developed and where it is available for a longer time. We are planning to send documentation update to Trusted-Firmware project to specify how to build Armada 3720 firmware image with our application. So people who are building Armada 3720 firmware would be able to switch from Marvell's 'fuse.bin' application to our 'wtmi_app.bin'. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel