From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC57C43381 for ; Fri, 12 Mar 2021 16:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3498A65025 for ; Fri, 12 Mar 2021 16:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbhCLQdA (ORCPT ); Fri, 12 Mar 2021 11:33:00 -0500 Received: from verein.lst.de ([213.95.11.211]:46250 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232238AbhCLQcs (ORCPT ); Fri, 12 Mar 2021 11:32:48 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 0DBCD68B05; Fri, 12 Mar 2021 17:32:47 +0100 (CET) Date: Fri, 12 Mar 2021 17:32:46 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Alex Williamson , Cornelia Huck , kvm@vger.kernel.org, "Raj, Ashok" , Dan Williams , Daniel Vetter , Leon Romanovsky , Max Gurtovoy , Tarun Gupta Subject: Re: [PATCH 01/10] vfio: Simplify the lifetime logic for vfio_device Message-ID: <20210312163246.GB11384@lst.de> References: <0-v1-7355d38b9344+17481-vfio1_jgg@nvidia.com> <1-v1-7355d38b9344+17481-vfio1_jgg@nvidia.com> <20210310072340.GA2659@lst.de> <20210312154133.GE2356281@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210312154133.GE2356281@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Mar 12, 2021 at 11:41:33AM -0400, Jason Gunthorpe wrote: > I split the put/get and it looks nicer. The other stuff is more > tightly coupled, doesn't look like there is much win from splitting > further Splitting the group put/get was all that I mean anyway. Thanks!