From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F57BC433E0 for ; Fri, 12 Mar 2021 18:43:58 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id DDCE564F69 for ; Fri, 12 Mar 2021 18:43:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDCE564F69 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26DE81608E1; Fri, 12 Mar 2021 19:43:57 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BE49F1608DA for ; Fri, 12 Mar 2021 19:43:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id D6DB6209B340; Fri, 12 Mar 2021 10:43:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D6DB6209B340 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1615574634; bh=NxlR7HL4wFacHar/mXo0/DPrd4ED/r3juG3189ZvkQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OsP/VAAu8Uzak9i4YLru/gYSKBvOGiKjKBXYrYBR8cme5LXROdHz4PQD0isNLKRRw GM4W3LoDhzHhabmEK6U1Ebnr61O2ai9YU2BbB8nfsicMMT927qH9lsl+2NcCqSeutZ T94EoU6s5d8sMaXO9fF0D24qcT+5Zbflsf1BMH8A= Date: Fri, 12 Mar 2021 10:43:54 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: David Marchand , Bruce Richardson , Ferruh Yigit , dev , Andrew Rybchenko Message-ID: <20210312184354.GC23744@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210312153419.GB937@bricha3-MOBL.ger.corp.intel.com> <2611050.R5Dl0tXAX9@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2611050.R5Dl0tXAX9@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 12, 2021 at 04:52:05PM +0100, Thomas Monjalon wrote: > 12/03/2021 16:34, Bruce Richardson: > > > > > > > > Instead of adding the "get_option('enable_driver_sdk')" checks to the modules, > > > > what about a more generic solution, like: > > > > > > > > modules assign relevant headers into a new variable, let's say 'pmd_headers', > > > > and in a high level meson file, all 'pmd_headers' are installed if > > > > 'enable_driver_sdk' enabled? > > > > > > > > > > +1. > > > Just, I don't like "pmd_headers" as the list name. > > > It can be misunderstood as the list of pmd-specific headers (thinking > > > of rte_pmd_i40e.h), that are exposed to applications. > > > > > Since the option is called "enable_driver_sdk" the variable name of > > "driver_sdk_headers" would be a good match. We should try and keep variable > > names and option names in sync as much as possible. > > +1 > seems like there is consensus. i'll figure out how introduce a driver_sdk_headers variable generically and remove the per-meson.build conditional evaluation. thanks