From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932F0C433E0 for ; Sat, 13 Mar 2021 20:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F91664E5B for ; Sat, 13 Mar 2021 20:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234402AbhCMUFJ (ORCPT ); Sat, 13 Mar 2021 15:05:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233635AbhCMUFJ (ORCPT ); Sat, 13 Mar 2021 15:05:09 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDF58C061574 for ; Sat, 13 Mar 2021 12:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FklQoEi8PnG+2CDky0Uq1toklxESBk4ZU9VRSAQNu8g=; b=rbe+a0CkmoLyc2L7lW/LP9e3ml kgxQAfMuITn7Ac4FmLN8cxcndahl0Y/ZiRviDR8T93a2ZLioweQJi5DzDRJ2llu+/7Xe+gluKyIYf JcybtnH9Ijd4W195aW3NvNx3o3KO3Cz1dUlCAGh/pDkB9Naui6KqSYtku1E9GfeMHYg2T0h7HhAYc L17PV/l3xw1inNkesSBiSviSJFL3Qr91CRoe4oleg/6NPSc7H+zrcEaYzrzUhu9nAokPgYfkAQfvp 3tcVdQJTrdnTNUHqLmVq7jG3Q3tL2QeUT/CKeMYM/W/pfVYBBo5QHTLEYebGSjlaKcfSNQlIY7pU8 JWhCceWw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lLAUR-00EjDY-If; Sat, 13 Mar 2021 20:04:08 +0000 Date: Sat, 13 Mar 2021 20:03:59 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, ziy@nvidia.com, william.kucharski@oracle.com, vbabka@suse.cz, richard.weiyang@linux.alibaba.com, peterx@redhat.com, anshuman.khandual@arm.com, thomas_os@shipmail.org, rcampbell@nvidia.com, aneesh.kumar@linux.ibm.com, yang.shi@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() Message-ID: <20210313200359.GL2577561@casper.infradead.org> References: <20210313103225.16607-1-linmiaohe@huawei.com> <20210313103225.16607-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210313103225.16607-2-linmiaohe@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 13, 2021 at 05:32:19AM -0500, Miaohe Lin wrote: > +static inline void try_to_split_huge_pmd_address(struct vm_area_struct *vma, unsigned long address) > +{ > + if (address & ~HPAGE_PMD_MASK && > + range_in_vma(vma, address & HPAGE_PMD_MASK, > + (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE)) > + split_huge_pmd_address(vma, address, false, NULL); > +} This isn't "try to split". This is "split if needed". I think the comments also need to be moved up here. I'm not even sure this is really an improvement.