All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 08/22] net: phy: Simplify the logic of phy_connect_fixed()
Date: Sun, 14 Mar 2021 20:14:52 +0800	[thread overview]
Message-ID: <20210314121506.18303-9-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20210314121506.18303-1-bmeng.cn@gmail.com>

Simplify the logic of phy_connect_fixed() by using the new API
ofnode_phy_is_fixed_link(), which brings additional bonus of
supporting the old DT bindings.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---

(no changes since v1)

 drivers/net/phy/phy.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index c7cdf64a0a..dcdef9e661 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -18,6 +18,7 @@
 #include <phy.h>
 #include <errno.h>
 #include <asm/global_data.h>
+#include <dm/of_extra.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/err.h>
@@ -1008,15 +1009,14 @@ static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
 					    phy_interface_t interface)
 {
 	ofnode node = dev_ofnode(dev), subnode;
-	struct phy_device *phydev;
-
-	subnode = ofnode_find_subnode(node, "fixed-link");
-	if (!ofnode_valid(subnode))
-		return NULL;
+	struct phy_device *phydev = NULL;
 
-	phydev = phy_device_create(bus, 0, PHY_FIXED_ID, false, interface);
-	if (phydev)
-		phydev->node = subnode;
+	if (ofnode_phy_is_fixed_link(node, &subnode)) {
+		phydev = phy_device_create(bus, 0, PHY_FIXED_ID,
+					   false, interface);
+		if (phydev)
+			phydev->node = subnode;
+	}
 
 	return phydev;
 }
-- 
2.25.1

  parent reply	other threads:[~2021-03-14 12:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14 12:14 [PATCH v4 00/22] ppc: qemu: Add eTSEC support Bin Meng
2021-03-14 12:14 ` Bin Meng
2021-03-14 12:14 ` [PATCH v4 01/22] dt-bindings: net: Add the old DT bindings for "fixed-link" Bin Meng
2021-03-14 12:14 ` [PATCH v4 02/22] of: extra: Introduce ofnode_phy_is_fixed_link() API Bin Meng
2021-03-14 12:14 ` [PATCH v4 03/22] dm: mdio: Use " Bin Meng
2021-03-14 12:14 ` [PATCH v4 04/22] net: phy: fixed: Be compatible with live OF tree Bin Meng
2021-03-14 12:14 ` [PATCH v4 05/22] net: phy: fixed: Drop #ifdef CONFIG_DM_ETH around phy_connect_fixed Bin Meng
2021-03-14 12:14 ` [PATCH v4 06/22] net: phy: xilinx: Be compatible with live OF tree Bin Meng
2021-04-23  7:35   ` Michal Simek
2021-04-23  9:14     ` Bin Meng
2021-04-23  9:23       ` Bin Meng
2021-04-23 11:52         ` Michal Simek
2021-03-14 12:14 ` [PATCH v4 07/22] net: phy: xilinx: Drop #ifdef CONFIG_DM_ETH around phy_connect_gmii2rgmii() Bin Meng
2021-03-14 12:14 ` Bin Meng [this message]
2021-03-14 12:14 ` [PATCH v4 09/22] net: phy: fixed: Make driver ops static Bin Meng
2021-03-14 12:14 ` [PATCH v4 10/22] net: phy: fixed: Add the missing ending newline Bin Meng
2021-03-14 12:14 ` [PATCH v4 11/22] net: phy: fixed: Support the old DT binding Bin Meng
2021-03-14 12:14 ` [PATCH v4 12/22] net: tsec: Use dm_eth_phy_connect() directly for the DM case Bin Meng
2021-03-14 12:14 ` [PATCH v4 13/22] sandbox: Add a DSA sandbox driver and unit test Bin Meng
2021-03-14 12:14 ` [PATCH v4 14/22] test: dm: Add a case to test ofnode_phy_is_fixed_link() Bin Meng
2021-03-14 12:14 ` [PATCH v4 15/22] net: tsec: Use map_physmem() directly instead of dev_remap_addr() Bin Meng
2021-03-14 12:15 ` [PATCH v4 16/22] dt-bindings: net: Update Freescale TSEC to support "queue-group" Bin Meng
2021-03-14 12:15 ` [PATCH v4 17/22] net: tsec: Support <reg> property from the subnode "queue-group" Bin Meng
2021-03-14 12:15 ` [PATCH v4 18/22] dm: core: Correctly read <ranges> of simple-bus Bin Meng
2021-03-14 12:15 ` [PATCH v4 19/22] test: dm: Add a test case for simple-bus <ranges> Bin Meng
2021-03-14 12:15 ` [PATCH v4 20/22] ppc: qemu: Create a virtual memory mapping of the platform bus Bin Meng
2021-03-14 12:15 ` [PATCH v4 21/22] ppc: qemu: Enable eTSEC support Bin Meng
2021-04-14 11:54   ` Priyanka Jain
2021-04-14 12:46     ` Tom Rini
2021-04-14 13:00     ` Bin Meng
2021-03-14 12:15 ` [PATCH v4 22/22] doc: board: qemu-ppce500: Document eTSEC usage Bin Meng
2021-04-06  8:48 ` [PATCH v4 00/22] ppc: qemu: Add eTSEC support Bin Meng
2021-04-06  8:48   ` Bin Meng
2021-04-08 15:29   ` Priyanka Jain
2021-04-08 15:29     ` Priyanka Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210314121506.18303-9-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.