All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH 15/24] staging:iio:cdc:ad7150: Tidy up local variable positioning.
Date: Sun, 14 Mar 2021 17:46:37 +0000	[thread overview]
Message-ID: <20210314174637.3dfb4a57@archlinux> (raw)
In-Reply-To: <7beef56608a54546ab88b8c76e8f4487@hisilicon.com>

On Mon, 8 Feb 2021 07:54:59 +0000
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com> wrote:

> > -----Original Message-----
> > From: Jonathan Cameron [mailto:jic23@kernel.org]
> > Sent: Monday, February 8, 2021 4:46 AM
> > To: linux-iio@vger.kernel.org
> > Cc: Lars-Peter Clausen <lars@metafoo.de>; Michael Hennerich
> > <Michael.Hennerich@analog.com>; Song Bao Hua (Barry Song)
> > <song.bao.hua@hisilicon.com>; robh+dt@kernel.org; Jonathan Cameron
> > <jonathan.cameron@huawei.com>
> > Subject: [PATCH 15/24] staging:iio:cdc:ad7150: Tidy up local variable
> > positioning.
> > 
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Where there is no other basis on which to order declarations
> > let us prefer reverse xmas tree.  Also reduce scope where
> > sensible.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>  
> 
> Reviewed-by: Barry Song <song.bao.hua@hisilicon.com>
This needed tweaking due to the earlier variable name change.

Applied with adaptive renamed to fixed and sense flipped.

Thanks,

Jonathan

> 
> > ---
> >  drivers/staging/iio/cdc/ad7150.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/cdc/ad7150.c
> > b/drivers/staging/iio/cdc/ad7150.c
> > index 9e88e774752f..d530b467d1b2 100644
> > --- a/drivers/staging/iio/cdc/ad7150.c
> > +++ b/drivers/staging/iio/cdc/ad7150.c
> > @@ -108,9 +108,9 @@ static int ad7150_read_raw(struct iio_dev *indio_dev,
> >  			   int *val2,
> >  			   long mask)
> >  {
> > -	int ret;
> >  	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> >  	int channel = chan->channel;
> > +	int ret;
> > 
> >  	switch (mask) {
> >  	case IIO_CHAN_INFO_RAW:
> > @@ -143,10 +143,10 @@ static int ad7150_read_event_config(struct iio_dev
> > *indio_dev,
> >  				    enum iio_event_type type,
> >  				    enum iio_event_direction dir)
> >  {
> > -	int ret;
> > +	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> >  	u8 threshtype;
> >  	bool thrfixed;
> > -	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> > +	int ret;
> > 
> >  	ret = i2c_smbus_read_byte_data(chip->client, AD7150_CFG_REG);
> >  	if (ret < 0)
> > @@ -227,10 +227,8 @@ static int ad7150_write_event_config(struct iio_dev
> > *indio_dev,
> >  				     enum iio_event_type type,
> >  				     enum iio_event_direction dir, int state)
> >  {
> > -	u8 thresh_type, cfg, adaptive;
> > -	int ret;
> >  	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> > -	int rising = (dir == IIO_EV_DIR_RISING);
> > +	int ret;
> > 
> >  	/*
> >  	 * There is only a single shared control and no on chip
> > @@ -251,6 +249,8 @@ static int ad7150_write_event_config(struct iio_dev
> > *indio_dev,
> > 
> >  	mutex_lock(&chip->state_lock);
> >  	if ((type != chip->type) || (dir != chip->dir)) {
> > +		int rising = (dir == IIO_EV_DIR_RISING);
> > +		u8 thresh_type, cfg, adaptive;
> > 
> >  		/*
> >  		 * Need to temporarily disable both interrupts if
> > @@ -533,9 +533,9 @@ static const struct iio_info ad7150_info_no_irq = {
> >  static int ad7150_probe(struct i2c_client *client,
> >  			const struct i2c_device_id *id)
> >  {
> > -	int ret;
> >  	struct ad7150_chip_info *chip;
> >  	struct iio_dev *indio_dev;
> > +	int ret;
> > 
> >  	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip));
> >  	if (!indio_dev)
> > --
> > 2.30.0  
> 


  reply	other threads:[~2021-03-14 17:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07 15:45 [PATCH 00/24] staging:iio:cdc:ad7150: cleanup / fixup / graduate Jonathan Cameron
2021-02-07 15:46 ` [PATCH 01/24] staging:iio:cdc:ad7150: use swapped reads for i2c rather than open coding Jonathan Cameron
2021-02-07 15:46 ` [PATCH 02/24] staging:iio:cdc:ad7150: Remove magnitude adaptive events Jonathan Cameron
2021-02-07 15:46 ` [PATCH 03/24] staging:iio:cdc:ad7150: Refactor event parameter update Jonathan Cameron
2021-02-07 15:46 ` [PATCH 04/24] staging:iio:cdc:ad7150: Timeout register covers both directions so both need updating Jonathan Cameron
2021-02-07 15:46 ` [PATCH 05/24] staging:iio:cdc:ad7150: Drop platform data support Jonathan Cameron
2021-02-08  8:01   ` Song Bao Hua (Barry Song)
2021-02-08 11:12     ` Jonathan Cameron
2021-02-07 15:46 ` [PATCH 06/24] staging:iio:cdc:ad7150: Handle variation in chan_spec across device and irq present or not Jonathan Cameron
2021-02-07 15:46 ` [PATCH 07/24] staging:iio:cdc:ad7150: Simplify event handling by only using rising direction Jonathan Cameron
2021-02-07 15:46 ` [PATCH 08/24] staging:iio:cdc:ad7150: Drop noisy print in probe Jonathan Cameron
2021-02-08  8:02   ` Song Bao Hua (Barry Song)
2021-02-07 15:46 ` [PATCH 09/24] staging:iio:cdc:ad7150: Add sampling_frequency support Jonathan Cameron
2021-02-07 15:46 ` [PATCH 10/24] iio:event: Add timeout event info type Jonathan Cameron
2021-02-07 15:46 ` [PATCH 11/24] staging:iio:cdc:ad7150: Change timeout units to seconds and use core support Jonathan Cameron
2021-02-07 15:46 ` [PATCH 12/24] staging:iio:cdc:ad7150: Rework interrupt handling Jonathan Cameron
2021-02-07 15:46 ` [PATCH 13/24] staging:iio:cdc:ad7150: More consistent register and field naming Jonathan Cameron
2021-03-14 17:43   ` Jonathan Cameron
2021-03-16 10:16     ` Alexandru Ardelean
2021-02-07 15:46 ` [PATCH 14/24] staging:iio:cdc:ad7150: Reorganize headers Jonathan Cameron
2021-02-08  7:54   ` Song Bao Hua (Barry Song)
2021-02-07 15:46 ` [PATCH 15/24] staging:iio:cdc:ad7150: Tidy up local variable positioning Jonathan Cameron
2021-02-08  7:54   ` Song Bao Hua (Barry Song)
2021-03-14 17:46     ` Jonathan Cameron [this message]
2021-02-07 15:46 ` [PATCH 16/24] staging:iio:cdc:ad7150: Drop unnecessary block comments Jonathan Cameron
2021-02-08  7:52   ` Song Bao Hua (Barry Song)
2021-02-07 15:46 ` [PATCH 17/24] staging:iio:cdc:ad7150: Shift the _raw readings by 4 bits Jonathan Cameron
2021-02-07 15:46 ` [PATCH 18/24] staging:iio:cdc:ad7150: Add scale and offset to info_mask_shared_by_type Jonathan Cameron
2021-02-07 15:46 ` [PATCH 19/24] staging:iio:cdc:ad7150: Really basic regulator support Jonathan Cameron
2021-02-07 15:46 ` [PATCH 20/24] staging:iio:cdc:ad7150: Add of_match_table Jonathan Cameron
2021-02-08  7:11   ` Alexandru Ardelean
2021-02-11 15:51     ` Jonathan Cameron
2021-02-08  7:50   ` Song Bao Hua (Barry Song)
2021-02-08  8:01     ` Alexandru Ardelean
2021-02-07 15:46 ` [PATCH 21/24] dt-bindings:iio:cdc:adi,ad7150 binding doc Jonathan Cameron
2021-02-07 16:00   ` Lars-Peter Clausen
2021-02-07 16:18     ` Jonathan Cameron
2021-02-08  8:12     ` Song Bao Hua (Barry Song)
2021-02-08 11:20       ` Jonathan Cameron
2021-02-21 15:59   ` Jonathan Cameron
2021-02-07 15:46 ` [PATCH 22/24] iio:Documentation:ABI Add missing elements as used by the adi,ad7150 Jonathan Cameron
2021-02-07 15:46 ` [PATCH 23/24] staging:iio:cdc:ad7150: Add copyright notice given substantial changes Jonathan Cameron
2021-02-07 15:46 ` [PATCH 24/24] iio:cdc:ad7150: Move driver out of staging Jonathan Cameron
2021-02-07 16:21   ` Jonathan Cameron
2021-02-07 16:12 ` [PATCH 00/24] staging:iio:cdc:ad7150: cleanup / fixup / graduate Jonathan Cameron
2021-02-08  7:20   ` Alexandru Ardelean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210314174637.3dfb4a57@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=song.bao.hua@hisilicon.com \
    --subject='Re: [PATCH 15/24] staging:iio:cdc:ad7150: Tidy up local variable positioning.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.