From: Roman Kagan <rvkagan@yandex-team.ru>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
yc-core@yandex-team.ru
Subject: [PATCH 0/7] block/nbd: decouple reconnect from drain
Date: Mon, 15 Mar 2021 09:06:04 +0300 [thread overview]
Message-ID: <20210315060611.2989049-1-rvkagan@yandex-team.ru> (raw)
The reconnection logic doesn't need to stop while in a drained section.
Moreover it has to be active during the drained section, as the requests
that were caught in-flight with the connection to the server broken can
only usefully get drained if the connection is restored. Otherwise such
requests can only either stall resulting in a deadlock (before
8c517de24a), or be aborted defeating the purpose of the reconnection
machinery (after 8c517de24a).
This series aims to just stop messing with the drained section in the
reconnection code.
While doing so it undoes the effect of 5ad81b4946 ("nbd: Restrict
connection_co reentrance"); as I've missed the point of that commit I'd
appreciate more scrutiny in this area.
Roman Kagan (7):
block/nbd: avoid touching freed connect_thread
block/nbd: use uniformly nbd_client_connecting_wait
block/nbd: assert attach/detach runs in the proper context
block/nbd: transfer reconnection stuff across aio_context switch
block/nbd: better document a case in nbd_co_establish_connection
block/nbd: decouple reconnect from drain
block/nbd: stop manipulating in_flight counter
block/nbd.c | 191 +++++++++++++++++++++++----------------------------
nbd/client.c | 2 -
2 files changed, 86 insertions(+), 107 deletions(-)
--
2.30.2
next reply other threads:[~2021-03-15 6:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 6:06 Roman Kagan [this message]
2021-03-15 6:06 ` [PATCH 1/7] block/nbd: avoid touching freed connect_thread Roman Kagan
2021-03-15 15:40 ` Vladimir Sementsov-Ogievskiy
2021-03-16 15:29 ` Roman Kagan
2021-04-06 16:21 ` Vladimir Sementsov-Ogievskiy
2021-03-15 6:06 ` [PATCH 2/7] block/nbd: use uniformly nbd_client_connecting_wait Roman Kagan
2021-03-15 15:48 ` Vladimir Sementsov-Ogievskiy
2021-03-15 6:06 ` [PATCH 3/7] block/nbd: assert attach/detach runs in the proper context Roman Kagan
2021-03-15 16:41 ` Vladimir Sementsov-Ogievskiy
2021-03-15 19:57 ` Roman Kagan
2021-03-15 6:06 ` [PATCH 4/7] block/nbd: transfer reconnection stuff across aio_context switch Roman Kagan
2021-03-15 6:06 ` [PATCH 5/7] block/nbd: better document a case in nbd_co_establish_connection Roman Kagan
2021-03-15 6:06 ` [PATCH 6/7] block/nbd: decouple reconnect from drain Roman Kagan
2021-03-15 20:10 ` Vladimir Sementsov-Ogievskiy
2021-03-16 16:03 ` Roman Kagan
2021-03-16 18:09 ` Vladimir Sementsov-Ogievskiy
2021-03-26 6:16 ` Roman Kagan
2021-03-15 6:06 ` [PATCH 7/7] block/nbd: stop manipulating in_flight counter Roman Kagan
2021-03-15 20:15 ` Vladimir Sementsov-Ogievskiy
2021-03-16 16:08 ` Roman Kagan
2021-03-16 18:37 ` Vladimir Sementsov-Ogievskiy
2021-03-26 7:41 ` Roman Kagan
2021-03-15 19:45 ` [PATCH 0/7] block/nbd: decouple reconnect from drain Vladimir Sementsov-Ogievskiy
2021-03-16 15:52 ` Roman Kagan
2021-03-16 14:41 ` Eric Blake
2021-03-16 16:10 ` Roman Kagan
2021-03-17 8:35 ` Vladimir Sementsov-Ogievskiy
2021-03-26 8:07 ` Roman Kagan
2021-04-07 7:45 ` Roman Kagan
2021-04-07 10:13 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315060611.2989049-1-rvkagan@yandex-team.ru \
--to=rvkagan@yandex-team.ru \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.