From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49683C433DB for ; Mon, 15 Mar 2021 07:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0679E64E4D for ; Mon, 15 Mar 2021 07:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbhCOHYy (ORCPT ); Mon, 15 Mar 2021 03:24:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:33120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229951AbhCOHYg (ORCPT ); Mon, 15 Mar 2021 03:24:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD03E64E61; Mon, 15 Mar 2021 07:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615793075; bh=bPgb6yp7ZSbsjfmG0toGXsrGC81m0xd6Hwvf92I5lQ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oUirYRY7evorBRjo6TqKpbhwLGoEgD8AgM9VtUN5wUaWR7TJf+qz/+UxXRYeGNMEf nBTO6JPklIvqrqYIgHe1/3MPAP2EXvA5UMPMADzh3JDLHfc6quppRl0dpMA4QTcfMi qWeaiW2J8snFkZJdqopW8WOltMmoBTp5qmdhLRvZ7zmKNE6N4Kt0FWDwmIc65AqmC/ fWPBSifh0I8XFbpfZYwGj1xEb6a0U+2e6MsJui0BIEMoKaofeGx8XtqcZmFFde0fTn ugIO+3K3AKZF5o48nKW6y6EzYbZYcGdh6oM7ePmcYycifFzrxBxpC12DWA4A9OxJz3 y0N1BINnET0+w== Date: Mon, 15 Mar 2021 15:24:30 +0800 From: Shawn Guo To: Martin Kepplinger Cc: robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com, krzk@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Sebastian Krzyszkowiak Subject: Re: [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Message-ID: <20210315072429.GQ11246@dragon> References: <20210311120259.3310499-1-martin.kepplinger@puri.sm> <20210311120259.3310499-3-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311120259.3310499-3-martin.kepplinger@puri.sm> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On Thu, Mar 11, 2021 at 01:02:58PM +0100, Martin Kepplinger wrote: > From: Sebastian Krzyszkowiak > > Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on") I cannot find this commit. Shawn > removed always-on marking from GPU regulator, which is great for power > saving - however it introduces additional i2c0 traffic which can be deadly > for devices from the Dogwood batch. > > To workaround the i2c0 shutdown issue on Dogwood, this commit marks > buck3 as always-on again - but only for Dogwood (r3). > > Signed-off-by: Sebastian Krzyszkowiak > Signed-off-by: Martin Kepplinger > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > index 0d38327043f8..cd3c3edd48fa 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > @@ -28,6 +28,10 @@ &bq25895 { > ti,termination-current = <144000>; /* uA */ > }; > > +&buck3_reg { > + regulator-always-on; > +}; > + > &proximity { > proximity-near-level = <25>; > }; > -- > 2.30.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BDEC433E0 for ; Mon, 15 Mar 2021 07:26:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AE2464E4D for ; Mon, 15 Mar 2021 07:26:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AE2464E4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K0JWl5LX7hJUCSlnxrMKQ3sSuIrKy9lhpouOYUQeTD4=; b=fxhnOQiBYDKcfc+qMzU7yKr1k ZGuNg+Y2qH1Xeay+2OjE+iGUVaOtLdZ3wheDMZP6v2ghqthuvCoq8TOx5kXp+OoLZBD70CeW+Q6Hw xzBZ5w9iZUkLarO1SQ5PEOjSfP4YIKh2JBGtOTNwTkooQt8zh+2jt6tpt9hv7XwJMK1tOsYYmLtlY 5vuVjFXBzdlO8iNKVFpOtBFun4qtz9n+Y9EmR5E6cLjJDz5O42671oUJeJAnbCEUIoIfXl+aECN09 Qcw9SbwFqBgVsH6QF3MvZbafHdUDMN8HtOfB6H7L/VC6XRAHbX+gZQjYw28xeJH9ZDEmdeSuCAV8I QH4WPUPLw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLhal-00F8Ii-0P; Mon, 15 Mar 2021 07:24:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLhaf-00F8Hj-BK for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 07:24:39 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD03E64E61; Mon, 15 Mar 2021 07:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615793075; bh=bPgb6yp7ZSbsjfmG0toGXsrGC81m0xd6Hwvf92I5lQ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oUirYRY7evorBRjo6TqKpbhwLGoEgD8AgM9VtUN5wUaWR7TJf+qz/+UxXRYeGNMEf nBTO6JPklIvqrqYIgHe1/3MPAP2EXvA5UMPMADzh3JDLHfc6quppRl0dpMA4QTcfMi qWeaiW2J8snFkZJdqopW8WOltMmoBTp5qmdhLRvZ7zmKNE6N4Kt0FWDwmIc65AqmC/ fWPBSifh0I8XFbpfZYwGj1xEb6a0U+2e6MsJui0BIEMoKaofeGx8XtqcZmFFde0fTn ugIO+3K3AKZF5o48nKW6y6EzYbZYcGdh6oM7ePmcYycifFzrxBxpC12DWA4A9OxJz3 y0N1BINnET0+w== Date: Mon, 15 Mar 2021 15:24:30 +0800 From: Shawn Guo To: Martin Kepplinger Cc: robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com, krzk@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Sebastian Krzyszkowiak Subject: Re: [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Message-ID: <20210315072429.GQ11246@dragon> References: <20210311120259.3310499-1-martin.kepplinger@puri.sm> <20210311120259.3310499-3-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210311120259.3310499-3-martin.kepplinger@puri.sm> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_072437_809669_DAAEE18E X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 01:02:58PM +0100, Martin Kepplinger wrote: > From: Sebastian Krzyszkowiak > > Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on") I cannot find this commit. Shawn > removed always-on marking from GPU regulator, which is great for power > saving - however it introduces additional i2c0 traffic which can be deadly > for devices from the Dogwood batch. > > To workaround the i2c0 shutdown issue on Dogwood, this commit marks > buck3 as always-on again - but only for Dogwood (r3). > > Signed-off-by: Sebastian Krzyszkowiak > Signed-off-by: Martin Kepplinger > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > index 0d38327043f8..cd3c3edd48fa 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > @@ -28,6 +28,10 @@ &bq25895 { > ti,termination-current = <144000>; /* uA */ > }; > > +&buck3_reg { > + regulator-always-on; > +}; > + > &proximity { > proximity-near-level = <25>; > }; > -- > 2.30.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel