From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A50FC433DB for ; Mon, 15 Mar 2021 10:06:37 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D4CFB64E99 for ; Mon, 15 Mar 2021 10:06:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4CFB64E99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E91B242606; Mon, 15 Mar 2021 11:06:35 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 3C4B64003C for ; Mon, 15 Mar 2021 11:06:33 +0100 (CET) IronPort-SDR: qCdzVdoSgYA2nLuBHora4klkQuGano9xj9PsG0z93TLJRJNtelLYHL2RaC70JImqktQCATo83r +xXx1ueBOf6w== X-IronPort-AV: E=McAfee;i="6000,8403,9923"; a="176193770" X-IronPort-AV: E=Sophos;i="5.81,249,1610438400"; d="scan'208";a="176193770" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 03:06:32 -0700 IronPort-SDR: 7J2SE4v8Ztk2UDZbgiFN1so+MbnoqIAKJYc9O0Er2x5OOhFP6sMlO0KM9GN27u3e2TdSWzU3k8 A4k3SFRlsmCg== X-IronPort-AV: E=Sophos;i="5.81,249,1610438400"; d="scan'208";a="449313908" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.180]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Mar 2021 03:06:29 -0700 Date: Mon, 15 Mar 2021 10:06:25 +0000 From: Bruce Richardson To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Message-ID: <20210315100625.GB2040@bricha3-MOBL.ger.corp.intel.com> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com> Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 12, 2021 at 02:20:06PM -0800, Tyler Retzlaff wrote: > Introduce a meson option enable_driver_sdk when true installs internal > driver headers for ethdev. this allows drivers that do not depend on > stable api/abi to be built external to the dpdk source tree. > > Signed-off-by: Tyler Retzlaff > --- > lib/librte_ethdev/meson.build | 6 ++++++ > lib/meson.build | 4 ++++ > meson_options.txt | 2 ++ > 3 files changed, 12 insertions(+) > The infrastructure looks good to me. However, you need to add change to the cryptodev, eventdev, etc. to add the headers from there too.