From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3479DC433DB for ; Mon, 15 Mar 2021 11:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E6A664E61 for ; Mon, 15 Mar 2021 11:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbhCOLY7 (ORCPT ); Mon, 15 Mar 2021 07:24:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26007 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhCOLYV (ORCPT ); Mon, 15 Mar 2021 07:24:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615807461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Djr40beaGeWrfSFbq8+OWk3jVJgTwdTUkjAhT7wUxI=; b=X/Lq2yrpDLQkMAzmhDdtkYLGtqny9Rb9R5Ee8gO4l9BJRzENjzIAOu5l7sAQNdPLRE5FxP 6G8GHuryW28ORMtUXRV+u2l6Pqx7E4x7oSEfWKBjTpvhFIKu4GFxq1QE2slBpVflfKq2YN Air4lFIxYNYdkQ5eIDtV0RafUcfRPlY= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-H3ctR4toO229HYRHOgrdUw-1; Mon, 15 Mar 2021 07:24:19 -0400 X-MC-Unique: H3ctR4toO229HYRHOgrdUw-1 Received: by mail-pl1-f198.google.com with SMTP id u5so13602826plg.2 for ; Mon, 15 Mar 2021 04:24:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7Djr40beaGeWrfSFbq8+OWk3jVJgTwdTUkjAhT7wUxI=; b=ATzDtmxDc64mFI1PXDb+kGy68valZSkY3onWeC98OTZxbG/UA1nvllkD21BorMfjge Z8I5AojlICexZMdNFDx46ci6Um4Mvosa8Fn1VBBrukmsoeYaxMeE2hJxvooiinv7k2cZ uk2srMxUNwAItcendnV/I4NwDz3pYOOmc2fAKGIzjHHcjYn5n/EB3awNxldrfpX46q39 bW8cRSFjE2mqXsMzbyFdG9lrx75s0a4kRe2cQLBlD/n3GTHD+FmxaLDkBwuWf+9DEUQM 5qkbO1+74UCMMIzeseQVHyNnVd0jPvPB6wptCHclezWUAa3d6fuc44mRLzkP0DkIFCuQ Nz+g== X-Gm-Message-State: AOAM532A2L0QeHDb/G+n/r0aj89lueDKpMvAGQxCm+RvuQkT2dS9/Zlg Ti4m14KOYF5SQJ2NJ4fD2LEIW1Rn1wF9OGWES0KGHv+5k/OKkmhDBdTUPiNmVWphvNflE/7g8xr Xz4nJiKBQHAbQeiimXFDQJUwl X-Received: by 2002:a17:902:ec91:b029:e6:90aa:24de with SMTP id x17-20020a170902ec91b02900e690aa24demr11008536plg.63.1615807458335; Mon, 15 Mar 2021 04:24:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIitvZrdUzlaIbOdZchSoaAuYKimnbJJQE6hRD5fYanFfh+YuwpjLDpPgkVCD9jVV6piqWQQ== X-Received: by 2002:a17:902:ec91:b029:e6:90aa:24de with SMTP id x17-20020a170902ec91b02900e690aa24demr11008524plg.63.1615807458168; Mon, 15 Mar 2021 04:24:18 -0700 (PDT) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id gk12sm10830473pjb.44.2021.03.15.04.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 04:24:17 -0700 (PDT) Date: Mon, 15 Mar 2021 19:24:07 +0800 From: Gao Xiang To: Huang Jianan Cc: zhangshiming@oppo.com, guoweichao@oppo.com, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] erofs: avoid memory allocation failure during rolling decompression Message-ID: <20210315112407.GA838000@xiangao.remote.csb> References: <20210305062219.557128-1-huangjianan@oppo.com> <20210305095840.31025-1-huangjianan@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210305095840.31025-1-huangjianan@oppo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 05:58:39PM +0800, Huang Jianan via Linux-erofs wrote: > Currently, err would be treated as io error. Therefore, it'd be > better to ensure memory allocation during rolling decompression > to avoid such io error. > > In the long term, we might consider adding another !Uptodate case > for such case. > > Signed-off-by: Huang Jianan > Signed-off-by: Guo Weichao Reviewed-by: Gao Xiang Thanks, Gao Xiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBF0C433E0 for ; Mon, 15 Mar 2021 11:24:30 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0BCD64E81 for ; Mon, 15 Mar 2021 11:24:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0BCD64E81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4DzYwX44clz2yjV for ; Mon, 15 Mar 2021 22:24:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X/Lq2yrp; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X/Lq2yrp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=hsiangkao@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X/Lq2yrp; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X/Lq2yrp; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DzYwT6CjQz2yRF for ; Mon, 15 Mar 2021 22:24:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615807461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Djr40beaGeWrfSFbq8+OWk3jVJgTwdTUkjAhT7wUxI=; b=X/Lq2yrpDLQkMAzmhDdtkYLGtqny9Rb9R5Ee8gO4l9BJRzENjzIAOu5l7sAQNdPLRE5FxP 6G8GHuryW28ORMtUXRV+u2l6Pqx7E4x7oSEfWKBjTpvhFIKu4GFxq1QE2slBpVflfKq2YN Air4lFIxYNYdkQ5eIDtV0RafUcfRPlY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615807461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Djr40beaGeWrfSFbq8+OWk3jVJgTwdTUkjAhT7wUxI=; b=X/Lq2yrpDLQkMAzmhDdtkYLGtqny9Rb9R5Ee8gO4l9BJRzENjzIAOu5l7sAQNdPLRE5FxP 6G8GHuryW28ORMtUXRV+u2l6Pqx7E4x7oSEfWKBjTpvhFIKu4GFxq1QE2slBpVflfKq2YN Air4lFIxYNYdkQ5eIDtV0RafUcfRPlY= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-k2jsa9GNMx2MKLRhLdCuLg-1; Mon, 15 Mar 2021 07:24:19 -0400 X-MC-Unique: k2jsa9GNMx2MKLRhLdCuLg-1 Received: by mail-pj1-f70.google.com with SMTP id oc10so14350845pjb.8 for ; Mon, 15 Mar 2021 04:24:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7Djr40beaGeWrfSFbq8+OWk3jVJgTwdTUkjAhT7wUxI=; b=sVoDWs/Jxxfc28NZAr88zMs7AMipaeHS9cf9C5aR5DzJLBOQ3xnytqk5AjAOQrMHzX 9aq1V1euAFB8/DwXSRsJksDIvZCgdfZNUmKmhew0T4OVS3bbnnVloorSfUuU5BxNRRSx YosPK3sXj1NKiXStqaazyoI3cHYMdnmt8dkcs0oKPli4rq0OWNJL1fJQKKJ0CeVdYjM5 135V/R6FE48rFDNykCuJCkeVYNS+HKPD1Wfa6+LuYVLn2rv3b3X9XHPDrCpWFDfmLCXE JkPqBAqiso5DFiEqUWYW05RSkvuf/edJhzwq6imEm4z0LyTFoiW+zjr+jRmc/Wh13oCV WjOQ== X-Gm-Message-State: AOAM530Gme/Eus6nIhATGmeZNUmWA61aWcG+PIvxIDFHgjOpRVHaj6ir HFhzi+mhbtnp912k4QPZFVlf9v8MYDuVKyDm2uqudzplEnKN3Y1niFlzpbAIZnq8LwLM9AeCgM7 9amvIDxbPWJL6E+bXdxJjVRZR X-Received: by 2002:a17:902:ec91:b029:e6:90aa:24de with SMTP id x17-20020a170902ec91b02900e690aa24demr11008541plg.63.1615807458340; Mon, 15 Mar 2021 04:24:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIitvZrdUzlaIbOdZchSoaAuYKimnbJJQE6hRD5fYanFfh+YuwpjLDpPgkVCD9jVV6piqWQQ== X-Received: by 2002:a17:902:ec91:b029:e6:90aa:24de with SMTP id x17-20020a170902ec91b02900e690aa24demr11008524plg.63.1615807458168; Mon, 15 Mar 2021 04:24:18 -0700 (PDT) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id gk12sm10830473pjb.44.2021.03.15.04.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 04:24:17 -0700 (PDT) Date: Mon, 15 Mar 2021 19:24:07 +0800 From: Gao Xiang To: Huang Jianan Subject: Re: [PATCH v5 1/2] erofs: avoid memory allocation failure during rolling decompression Message-ID: <20210315112407.GA838000@xiangao.remote.csb> References: <20210305062219.557128-1-huangjianan@oppo.com> <20210305095840.31025-1-huangjianan@oppo.com> MIME-Version: 1.0 In-Reply-To: <20210305095840.31025-1-huangjianan@oppo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hsiangkao@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangshiming@oppo.com, linux-erofs@lists.ozlabs.org, guoweichao@oppo.com, linux-kernel@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Fri, Mar 05, 2021 at 05:58:39PM +0800, Huang Jianan via Linux-erofs wrote: > Currently, err would be treated as io error. Therefore, it'd be > better to ensure memory allocation during rolling decompression > to avoid such io error. > > In the long term, we might consider adding another !Uptodate case > for such case. > > Signed-off-by: Huang Jianan > Signed-off-by: Guo Weichao Reviewed-by: Gao Xiang Thanks, Gao Xiang