From: Jakub Kicinski <kuba@kernel.org>
To: Huazhong Tan <tanhuazhong@huawei.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<huangdaode@huawei.com>, <linuxarm@openeuler.org>,
<linuxarm@huawei.com>, Jian Shen <shenjian15@huawei.com>
Subject: Re: [PATCH net-next 5/9] net: hns3: refactor flow director configuration
Date: Mon, 15 Mar 2021 13:00:27 -0700 [thread overview]
Message-ID: <20210315130027.669b8afa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1615811031-55209-6-git-send-email-tanhuazhong@huawei.com>
On Mon, 15 Mar 2021 20:23:47 +0800 Huazhong Tan wrote:
> From: Jian Shen <shenjian15@huawei.com>
>
> Currently, there are 3 flow director work modes in HNS3 driver,
> include EP(ethtool), tc flower and aRFS. The flow director rules
> are configured synchronously and need holding spin lock. With this
> limitation, all the commands with firmware are also needed to use
> spin lock.
>
> To eliminate the limitation, configure flow director rules
> asynchronously. The rules are still kept in the fd_rule_list
> with below states.
> TO_ADD: the rule is waiting to add to hardware
> TO_DEL: the rule is waiting to remove from hardware
> ADDING: the rule is adding to hardware
> ACTIVE: the rule is already added in hardware
>
> When receive a new request to add or delete flow director rule,
> check whether the rule location is existent, update the rule
> content and state, and request to schedule the service task to
> finish the configuration.
>
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
How is the application supposed to know if the ethtool rule was already
installed or installation is still pending?
With the firmware bloat on all devices this sort of async mechanism
seems to be popping up in more and more drivers but IMHO we shouldn't
weaken the semantics without amending the kernel <> user space API.
next prev parent reply other threads:[~2021-03-15 20:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 12:23 [PATCH net-next 0/9] net: hns3: refactor and new features for flow director Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 1/9] net: hns3: refactor out hclge_add_fd_entry() Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 2/9] net: hns3: refactor out hclge_fd_get_tuple() Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 3/9] net: hns3: refactor for function hclge_fd_convert_tuple Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 4/9] net: hns3: add support for traffic class tuple support for flow director by ethtool Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 5/9] net: hns3: refactor flow director configuration Huazhong Tan
2021-03-15 20:00 ` Jakub Kicinski [this message]
2021-03-17 1:47 ` Huazhong Tan
2021-03-17 18:32 ` Jakub Kicinski
2021-03-15 12:23 ` [PATCH net-next 6/9] net: hns3: refine for hns3_del_all_fd_entries() Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 7/9] net: hns3: add support for user-def data of flow director Huazhong Tan
2021-03-15 12:23 ` [PATCH net-next 8/9] net: hns3: add support for queue bonding mode " Huazhong Tan
2021-03-15 20:04 ` Jakub Kicinski
2021-03-18 1:02 ` Huazhong Tan
2021-03-18 1:28 ` Jakub Kicinski
2021-03-18 3:30 ` Alexander Duyck
2021-06-18 1:18 ` shenjian (K)
2021-06-18 22:01 ` Jakub Kicinski
2021-06-19 3:20 ` shenjian (K)
2021-03-15 12:23 ` [PATCH net-next 9/9] net: hns3: add queue bonding mode support for VF Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315130027.669b8afa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=huangdaode@huawei.com \
--cc=linuxarm@huawei.com \
--cc=linuxarm@openeuler.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.