All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
@ 2021-03-12  0:26 Bjorn Andersson
  2021-03-15 16:22 ` Mathieu Poirier
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-03-12  0:26 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Ohad Ben-Cohen, Mathieu Poirier
  Cc: linux-arm-msm, linux-remoteproc, linux-kernel

Failing to read the "firmware-name" DT property without informing the
developer is annoying, add some helpful debug prints.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 66106ba25ba3..15abfbba78d2 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev)
 	mba_image = desc->hexagon_mba_image;
 	ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
 					    0, &mba_image);
-	if (ret < 0 && ret != -EINVAL)
+	if (ret < 0 && ret != -EINVAL) {
+		dev_err(&pdev->dev, "unable to read mba firmware-name\n");
 		return ret;
+	}
 
 	rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops,
 			    mba_image, sizeof(*qproc));
@@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev)
 	qproc->hexagon_mdt_image = "modem.mdt";
 	ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
 					    1, &qproc->hexagon_mdt_image);
-	if (ret < 0 && ret != -EINVAL)
+	if (ret < 0 && ret != -EINVAL) {
+		dev_err(&pdev->dev, "unable to read mpss firmware-name\n");
 		goto free_rproc;
+	}
 
 	platform_set_drvdata(pdev, qproc);
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
  2021-03-12  0:26 [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing Bjorn Andersson
@ 2021-03-15 16:22 ` Mathieu Poirier
  2021-03-18 13:10 ` patchwork-bot+linux-remoteproc
  2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2021-03-15 16:22 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Ohad Ben-Cohen, linux-arm-msm, linux-remoteproc,
	linux-kernel

On Thu, Mar 11, 2021 at 04:26:05PM -0800, Bjorn Andersson wrote:
> Failing to read the "firmware-name" DT property without informing the
> developer is annoying, add some helpful debug prints.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index 66106ba25ba3..15abfbba78d2 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev)
>  	mba_image = desc->hexagon_mba_image;
>  	ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
>  					    0, &mba_image);
> -	if (ret < 0 && ret != -EINVAL)
> +	if (ret < 0 && ret != -EINVAL) {
> +		dev_err(&pdev->dev, "unable to read mba firmware-name\n");
>  		return ret;
> +	}
>  
>  	rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops,
>  			    mba_image, sizeof(*qproc));
> @@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev)
>  	qproc->hexagon_mdt_image = "modem.mdt";
>  	ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
>  					    1, &qproc->hexagon_mdt_image);
> -	if (ret < 0 && ret != -EINVAL)
> +	if (ret < 0 && ret != -EINVAL) {
> +		dev_err(&pdev->dev, "unable to read mpss firmware-name\n");
>  		goto free_rproc;
> +	}

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  
>  	platform_set_drvdata(pdev, qproc);
>  
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
  2021-03-12  0:26 [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing Bjorn Andersson
  2021-03-15 16:22 ` Mathieu Poirier
@ 2021-03-18 13:10 ` patchwork-bot+linux-remoteproc
  2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2021-03-18 13:10 UTC (permalink / raw)
  To: Bjorn Andersson; +Cc: linux-remoteproc

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Thu, 11 Mar 2021 16:26:05 -0800 you wrote:
> Failing to read the "firmware-name" DT property without informing the
> developer is annoying, add some helpful debug prints.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Here is the summary with links:
  - remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
    https://git.kernel.org/andersson/remoteproc/c/9af2a2a9c64e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
  2021-03-12  0:26 [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing Bjorn Andersson
  2021-03-15 16:22 ` Mathieu Poirier
  2021-03-18 13:10 ` patchwork-bot+linux-remoteproc
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
  To: Bjorn Andersson; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Thu, 11 Mar 2021 16:26:05 -0800 you wrote:
> Failing to read the "firmware-name" DT property without informing the
> developer is annoying, add some helpful debug prints.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Here is the summary with links:
  - remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
    https://git.kernel.org/qcom/c/9af2a2a9c64e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-26 19:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12  0:26 [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing Bjorn Andersson
2021-03-15 16:22 ` Mathieu Poirier
2021-03-18 13:10 ` patchwork-bot+linux-remoteproc
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.