All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v23 33/37] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct
Date: Mon, 15 Mar 2021 17:58:38 +0100	[thread overview]
Message-ID: <20210315165842.64488-34-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20210315165842.64488-1-zbigniew.kempczynski@intel.com>

Generally when playing with intel_buf we should use wrapper code
instead of adding it to intel_bb directly. Code checks required
alignment on specific gens so protects us from passing unaligned
properly addresses.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap_offset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index 5e48cd697..8f2006274 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -614,8 +614,8 @@ static void blt_coherency(int i915)
 	dst = create_bo(bops, 1, width, height);
 	size = src->surface[0].size;
 
-	intel_bb_add_object(ibb, src->handle, size, src->addr.offset, 0, false);
-	intel_bb_add_object(ibb, dst->handle, size, dst->addr.offset, 0, true);
+	intel_bb_add_intel_buf(ibb, src, false);
+	intel_bb_add_intel_buf(ibb, dst, true);
 
 	intel_bb_blt_copy(ibb,
 			  src, 0, 0, src->surface[0].stride,
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-03-15 16:59 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 16:58 [igt-dev] [PATCH i-g-t v23 00/37] Introduce IGT allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 01/37] lib/gem_submission: Add gem_has_relocations() check Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 02/37] lib/igt_list: Add igt_list_del_init() Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 03/37] lib/igt_list: igt_hlist implementation Zbigniew Kempczyński
2021-03-16 10:29   ` Daniel Vetter
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 04/37] lib/igt_map: Introduce igt_map Zbigniew Kempczyński
2021-03-16 10:30   ` Daniel Vetter
2021-03-16 12:25     ` Zbigniew Kempczyński
2021-03-16 13:26       ` Daniel Vetter
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 05/37] lib/igt_core: Track child process pid and tid Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 06/37] lib/intel_allocator_simple: Add simple allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 07/37] lib/intel_allocator_reloc: Add reloc allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 08/37] lib/intel_allocator_random: Add random allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 09/37] lib/intel_allocator: Add intel_allocator core Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 10/37] lib/intel_allocator: Try to stop smoothly instead of deinit Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 11/37] lib/intel_allocator_msgchannel: Scale to 4k of parallel clients Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 12/37] lib/intel_allocator: Separate allocator multiprocess start Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 13/37] lib/intel_bufops: Change size from 32->64 bit Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 14/37] lib/intel_bufops: Add init with handle and size function Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 15/37] lib/intel_batchbuffer: Integrate intel_bb with allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 16/37] lib/intel_batchbuffer: Use relocations in intel-bb up to gen12 Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 17/37] lib/intel_batchbuffer: Create bb with strategy / vm ranges Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 18/37] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 19/37] lib/igt_fb: Initialize intel_buf with same size as fb Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 20/37] tests/api_intel_bb: Remove check-canonical test Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 21/37] tests/api_intel_bb: Modify test to verify intel_bb with allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 22/37] tests/api_intel_bb: Add subtest to check render batch on the last page Zbigniew Kempczyński
2021-03-16 11:47   ` Daniel Vetter
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 23/37] tests/api_intel_bb: Add compressed->compressed copy Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 24/37] tests/api_intel_bb: Add purge-bb test Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 25/37] tests/api_intel_bb: Add simple intel-bb which uses allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 26/37] tests/api_intel_bb: Use allocator in delta-check test Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 27/37] tests/api_intel_bb: Check switching vm in intel-bb Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 28/37] tests/api_intel_allocator: Simple allocator test suite Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 29/37] tests/api_intel_allocator: Add execbuf with allocator example Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 30/37] tests/api_intel_allocator: Verify child can use its standalone allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 31/37] tests/gem_softpin: Verify allocator and execbuf pair work together Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 32/37] tests/gem|kms: Remove intel_bb from fixture Zbigniew Kempczyński
2021-03-15 16:58 ` Zbigniew Kempczyński [this message]
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 34/37] tests/gem_ppgtt: Adopt test to use intel_bb with allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 35/37] tests/gem_render_copy_redux: Adopt to use with intel_bb and allocator Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 36/37] tests/perf.c: Remove buffer from batch Zbigniew Kempczyński
2021-03-15 16:58 ` [igt-dev] [PATCH i-g-t v23 37/37] tests/gem_linear_blits: Use intel allocator Zbigniew Kempczyński
2021-03-16 11:23   ` Chris Wilson
2021-03-16 13:08     ` Zbigniew Kempczyński
2021-03-16 13:18     ` Zbigniew Kempczyński
2021-03-15 17:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev26) Patchwork
2021-03-15 19:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-16 10:36   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315165842.64488-34-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.