From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marco Cesati <marcocesati@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 00/57] Staging: rtl8723bs: fix POINTER_LOCATION whitespaces
Date: Tue, 16 Mar 2021 11:21:46 +0300 [thread overview]
Message-ID: <20210316082146.GQ2087@kadam> (raw)
In-Reply-To: <20210315170618.2566-1-marcocesati@gmail.com>
On Mon, Mar 15, 2021 at 06:05:21PM +0100, Marco Cesati wrote:
> This set of patches fixes 522 checkpatch.pl errors of type
> POINTER_LOCATION in the staging/rtl8723bs souce code. Every patch is
> purely syntactical: it does not change the generated machine code.
> Furthermore, every single patch leaves the source code fully compilable,
> so that 'git bisect' will not be affected.
Hopefully that part can be assumed. :P
>
> The checkpatch.pl script emits many errors and warnings for these
> patches, however all of them are caused by the original code. They shall
> be fixed in different patchsets.
Yep. You maybe went a tad too aggressive in fixing the checkpatch
warnings about parentheses... If you didn't introduce the warning, then
you can just leave it as-is.
Anyway, looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2021-03-16 8:22 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 17:05 [PATCH 00/57] Staging: rtl8723bs: fix POINTER_LOCATION whitespaces Marco Cesati
2021-03-15 17:05 ` [PATCH 01/57] Staging: rtl8723bs: fix spaces in rtw_cmd.c Marco Cesati
2021-03-15 17:05 ` [PATCH 02/57] Staging: rtl8723bs: fix spaces in HalBtc8723b1Ant.c Marco Cesati
2021-03-15 17:05 ` [PATCH 03/57] Staging: rtl8723bs: fix spaces in HalBtc8723b1Ant.h Marco Cesati
2021-03-15 17:05 ` [PATCH 04/57] Staging: rtl8723bs: fix spaces in HalBtc8723b2Ant.c Marco Cesati
2021-03-15 17:05 ` [PATCH 05/57] Staging: rtl8723bs: fix spaces in HalBtc8723b2Ant.h Marco Cesati
2021-03-15 17:05 ` [PATCH 06/57] Staging: rtl8723bs: fix spaces in HalBtcOutSrc.h Marco Cesati
2021-03-15 17:05 ` [PATCH 07/57] Staging: rtl8723bs: fix spaces in HalHWImg8723B_BB.c Marco Cesati
2021-03-15 17:05 ` [PATCH 08/57] Staging: rtl8723bs: fix spaces in HalHWImg8723B_BB.h Marco Cesati
2021-03-15 17:05 ` [PATCH 09/57] Staging: rtl8723bs: fix spaces in HalHWImg8723B_MAC.c Marco Cesati
2021-03-15 17:05 ` [PATCH 10/57] Staging: rtl8723bs: fix spaces in HalHWImg8723B_MAC.h Marco Cesati
2021-03-15 17:05 ` [PATCH 11/57] Staging: rtl8723bs: fix spaces in HalHWImg8723B_RF.c Marco Cesati
2021-03-15 17:05 ` [PATCH 12/57] Staging: rtl8723bs: fix spaces in HalHWImg8723B_RF.h Marco Cesati
2021-03-15 17:05 ` [PATCH 13/57] Staging: rtl8723bs: fix spaces in HalPhyRf.c Marco Cesati
2021-03-15 17:05 ` [PATCH 14/57] Staging: rtl8723bs: fix spaces in HalPhyRf.h Marco Cesati
2021-03-15 17:05 ` [PATCH 15/57] Staging: rtl8723bs: fix spaces in HalPhyRf_8723B.c Marco Cesati
2021-03-15 17:05 ` [PATCH 16/57] Staging: rtl8723bs: fix spaces in HalPhyRf_8723B.h Marco Cesati
2021-03-15 17:05 ` [PATCH 17/57] Staging: rtl8723bs: fix spaces in hal_btcoex.c Marco Cesati
2021-03-15 17:05 ` [PATCH 18/57] Staging: rtl8723bs: fix spaces in hal_com.c Marco Cesati
2021-03-15 17:05 ` [PATCH 19/57] Staging: rtl8723bs: fix spaces in hal_com_phycfg.c Marco Cesati
2021-03-15 17:05 ` [PATCH 20/57] Staging: rtl8723bs: fix spaces in odm.c Marco Cesati
2021-03-15 17:05 ` [PATCH 21/57] Staging: rtl8723bs: fix spaces in odm.h Marco Cesati
2021-03-15 17:05 ` [PATCH 22/57] Staging: rtl8723bs: fix spaces in odm_CfoTracking.c Marco Cesati
2021-03-15 17:05 ` [PATCH 23/57] Staging: rtl8723bs: fix spaces in odm_DIG.c Marco Cesati
2021-03-15 17:05 ` [PATCH 24/57] Staging: rtl8723bs: fix in odm_DynamicBBPowerSaving.c Marco Cesati
2021-03-15 17:05 ` [PATCH 25/57] Staging: rtl8723bs: fix spaces in odm_DynamicTxPower.c Marco Cesati
2021-03-15 17:05 ` [PATCH 26/57] Staging: rtl8723bs: fix spaces in odm_EdcaTurboCheck.c Marco Cesati
2021-03-15 17:05 ` [PATCH 27/57] Staging: rtl8723bs: fix spaces in odm_HWConfig.c Marco Cesati
2021-03-15 17:05 ` [PATCH 28/57] Staging: rtl8723bs: fix spaces in odm_HWConfig.h Marco Cesati
2021-03-15 17:05 ` [PATCH 29/57] Staging: rtl8723bs: fix spaces in odm_NoiseMonitor.c Marco Cesati
2021-03-15 17:05 ` [PATCH 30/57] Staging: rtl8723bs: fix spaces in odm_PathDiv.c Marco Cesati
2021-03-15 17:05 ` [PATCH 31/57] Staging: rtl8723bs: fix spaces in odm_RegConfig8723B.c Marco Cesati
2021-03-15 17:05 ` [PATCH 32/57] Staging: rtl8723bs: fix spaces in odm_RegConfig8723B.h Marco Cesati
2021-03-15 17:05 ` [PATCH 33/57] Staging: rtl8723bs: fix spaces in odm_debug.c Marco Cesati
2021-03-15 17:05 ` [PATCH 34/57] Staging: rtl8723bs: fix spaces in odm_debug.h Marco Cesati
2021-03-15 17:05 ` [PATCH 35/57] Staging: rtl8723bs: fix spaces in rtl8723b_dm.c Marco Cesati
2021-03-15 17:05 ` [PATCH 36/57] Staging: rtl8723bs: fix spaces in rtl8723b_hal_init.c Marco Cesati
2021-03-15 17:05 ` [PATCH 37/57] Staging: rtl8723bs: fix spaces in rtl8723b_phycfg.c Marco Cesati
2021-03-15 17:05 ` [PATCH 38/57] Staging: rtl8723bs: fix spaces in HalPwrSeqCmd.h Marco Cesati
2021-03-15 17:06 ` [PATCH 39/57] Staging: rtl8723bs: fix spaces in basic_types.h Marco Cesati
2021-03-15 17:06 ` [PATCH 40/57] Staging: rtl8723bs: fix spaces in drv_types.h Marco Cesati
2021-03-15 17:06 ` [PATCH 41/57] Staging: rtl8723bs: fix spaces in hal_com.h Marco Cesati
2021-03-15 17:06 ` [PATCH 42/57] Staging: rtl8723bs: fix spaces in hal_com_h2c.h Marco Cesati
2021-03-15 17:06 ` [PATCH 43/57] Staging: rtl8723bs: fix spaces in hal_com_phycfg.h Marco Cesati
2021-03-15 17:06 ` [PATCH 44/57] Staging: rtl8723bs: fix spaces in ieee80211.h Marco Cesati
2021-03-15 17:06 ` [PATCH 45/57] Staging: rtl8723bs: fix spaces in ioctl_cfg80211.h Marco Cesati
2021-03-15 17:06 ` [PATCH 46/57] Staging: rtl8723bs: fix spaces in osdep_intf.h Marco Cesati
2021-03-15 17:06 ` [PATCH 47/57] Staging: rtl8723bs: fix spaces in osdep_service.h Marco Cesati
2021-03-15 17:06 ` [PATCH 48/57] Staging: rtl8723bs: fix spaces in osdep_service_linux.h Marco Cesati
2021-03-15 17:06 ` [PATCH 49/57] Staging: rtl8723bs: fix spaces in recv_osdep.h Marco Cesati
2021-03-15 17:06 ` [PATCH 50/57] Staging: rtl8723bs: fix spaces in rtl8723b_xmit.h Marco Cesati
2021-03-15 17:06 ` [PATCH 51/57] Staging: rtl8723bs: fix spaces in rtw_cmd.h Marco Cesati
2021-03-15 17:06 ` [PATCH 52/57] Staging: rtl8723bs: fix spaces in rtw_ioctl_set.h Marco Cesati
2021-03-15 17:06 ` [PATCH 53/57] Staging: rtl8723bs: fix spaces in rtw_mlme_ext.h Marco Cesati
2021-03-15 17:06 ` [PATCH 54/57] Staging: rtl8723bs: fix spaces in xmit_osdep.h Marco Cesati
2021-03-15 17:06 ` [PATCH 55/57] Staging: rtl8723bs: fix spaces in os_intfs.c Marco Cesati
2021-03-15 17:06 ` [PATCH 56/57] Staging: rtl8723bs: fix spaces in osdep_service.c Marco Cesati
2021-03-15 17:06 ` [PATCH 57/57] Staging: rtl8723bs: fix spaces in xmit_linux.c Marco Cesati
2021-03-16 8:21 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316082146.GQ2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=marcocesati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.