From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A714FC433DB for ; Tue, 16 Mar 2021 21:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7337D64FA7 for ; Tue, 16 Mar 2021 21:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232812AbhCPVVj (ORCPT ); Tue, 16 Mar 2021 17:21:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:44438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232433AbhCPVVP (ORCPT ); Tue, 16 Mar 2021 17:21:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 584DB64FA6; Tue, 16 Mar 2021 21:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615929674; bh=su/a4cJXKkStHlw0Xv6RaaQR/ej+nELTe/a2v5ZVifY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ls+CiT1rDuu0/020yQNXMyP2EEGdd9tNmW+kVHPmWtJ+PknQ6RpzBiJLaN9fGZlF5 SsBWH/k4HVb5+FzKdDe2t7Ts9xj6H3AD+MvDRZ9U4pgiNYHjkdIeUsRx0zTvSW4vb9 czxtJsbfrwJVmmgL4qHh9R4Ykn9jadnw16nflBaRsNnrkz2sXh9J5hh2VUySY8AlOp oPBF7HIPB7sxJrie0K88Y2byZzXwXNrIuPvm0FIVOX/gbCh1+p6oFdGUmbnCm6q7sB klqBhD8p4rMRS9uoOAiz30GzIEdjKZiD6v/cN2f6NwOS8o6HFxEwWZNHCOQj9J6rX3 tcpWNiprO/D5Q== Date: Tue, 16 Mar 2021 14:21:13 -0700 From: Jakub Kicinski To: Voon Weifeng Cc: "David S . Miller" , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Giuseppe Cavallaro , Andrew Lunn , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Ong Boon Leong , Wong Vee Khee Subject: Re: [RESEND v1 net-next 2/5] net: stmmac: make stmmac_interrupt() function more friendly to MSI Message-ID: <20210316142113.40fd721f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210316121823.18659-3-weifeng.voon@intel.com> References: <20210316121823.18659-1-weifeng.voon@intel.com> <20210316121823.18659-3-weifeng.voon@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Mar 2021 20:18:20 +0800 Voon Weifeng wrote: > + if (unlikely(!dev)) { > + netdev_err(priv->dev, "%s: invalid dev pointer\n", __func__); > + return IRQ_NONE; > + } Where did this check come from? Please avoid defensive programming in the kernel unless you can point out how the condition can arise legitimately. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79007C433E0 for ; Tue, 16 Mar 2021 21:23:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E1EC64FA7 for ; Tue, 16 Mar 2021 21:23:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E1EC64FA7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6hyKeytxUWeZg6v/yBcQcy3SB8tz7kl2YyAvFwSD3FE=; b=Q8tIVymHjZv6tfRAwm0D2I0xw IBLH2eKCGqfJrlOQPqobQvZc8PA050uf41T7zO+wdFT6GvLQqvSXG52kmzaq91SAuno7d/+32HYqd TzhiiqROrSejFavr2DfeTS2GAcAPvR2upxAoOolV4DH+HQzAYdxI82Y+cJqzNjW11L+2OcEUaR+Lq /D8x19/o3fRkeSHzwiTDxniKzFkBLXkLA2ngiAAEe/C+4RuVIqJZKicsQke3/WekSEaScCaYgHP0Q o5FpKX9QwD1tYGLkcPy6kzAAQv4Exsn+6Sg+18jTODJpTGX8mNlyt5n8GTGc/Z4wQfOScjmd1NWen WJViWQJ2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMH7y-001tCc-Qr; Tue, 16 Mar 2021 21:21:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMH7t-001tBV-Oh for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 21:21:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 584DB64FA6; Tue, 16 Mar 2021 21:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615929674; bh=su/a4cJXKkStHlw0Xv6RaaQR/ej+nELTe/a2v5ZVifY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ls+CiT1rDuu0/020yQNXMyP2EEGdd9tNmW+kVHPmWtJ+PknQ6RpzBiJLaN9fGZlF5 SsBWH/k4HVb5+FzKdDe2t7Ts9xj6H3AD+MvDRZ9U4pgiNYHjkdIeUsRx0zTvSW4vb9 czxtJsbfrwJVmmgL4qHh9R4Ykn9jadnw16nflBaRsNnrkz2sXh9J5hh2VUySY8AlOp oPBF7HIPB7sxJrie0K88Y2byZzXwXNrIuPvm0FIVOX/gbCh1+p6oFdGUmbnCm6q7sB klqBhD8p4rMRS9uoOAiz30GzIEdjKZiD6v/cN2f6NwOS8o6HFxEwWZNHCOQj9J6rX3 tcpWNiprO/D5Q== Date: Tue, 16 Mar 2021 14:21:13 -0700 From: Jakub Kicinski To: Voon Weifeng Cc: "David S . Miller" , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Giuseppe Cavallaro , Andrew Lunn , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Ong Boon Leong , Wong Vee Khee Subject: Re: [RESEND v1 net-next 2/5] net: stmmac: make stmmac_interrupt() function more friendly to MSI Message-ID: <20210316142113.40fd721f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210316121823.18659-3-weifeng.voon@intel.com> References: <20210316121823.18659-1-weifeng.voon@intel.com> <20210316121823.18659-3-weifeng.voon@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_212118_021280_8E75F1D3 X-CRM114-Status: UNSURE ( 5.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Mar 2021 20:18:20 +0800 Voon Weifeng wrote: > + if (unlikely(!dev)) { > + netdev_err(priv->dev, "%s: invalid dev pointer\n", __func__); > + return IRQ_NONE; > + } Where did this check come from? Please avoid defensive programming in the kernel unless you can point out how the condition can arise legitimately. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel