From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 16 Mar 2021 13:42:59 -0400 Subject: [PATCH] arm: omap3: Make try_unlock_memory() static In-Reply-To: References: <20210307035321.23810-1-aford173@gmail.com> Message-ID: <20210316174259.GB1310@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Mar 16, 2021 at 12:18:05PM -0500, Adam Ford wrote: > On Mon, Mar 15, 2021 at 1:43 AM Lokesh Vutla wrote: > > > > > > > > On 07/03/21 9:23 am, Adam Ford wrote: > > > try_unlock_memory() is only used in one file, so make it static > > > in that file and remove it from the sys_proto header file. This > > > may help with some further optimization in the future. > > > > > > Signed-off-by: Adam Ford > > > > one of omap3 board is failing to build. Can you take a look? > > > > https://source.denx.de/u-boot/custodians/u-boot-ti/-/jobs/237886 > > > > Question on preference...Would you prefer I move the unused function > into the #ifdef area, or should I just mark the function as > __maybe_unused? I am not a fan of #ifdef, but I can move the > function there that is your preference. If there's already an #ifdef we should restructure the code to live there, yes. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: