From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83AF7C433E9 for ; Tue, 16 Mar 2021 16:55:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E8086510E for ; Tue, 16 Mar 2021 16:55:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E8086510E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMCyo-0007nK-71 for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 12:55:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMCsq-0002hL-PE for qemu-devel@nongnu.org; Tue, 16 Mar 2021 12:49:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMCsk-0006c8-1S for qemu-devel@nongnu.org; Tue, 16 Mar 2021 12:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615913361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCtrZx6iWF4UrUixr27TSrrVZEPhi+Cr+SwDcPPOj/8=; b=MyrXXWt/TQxiw04qxJzLG1/SLJXS8LUR0roC7IJAgweR3KxZ/PyM2p0ZuyKhpyidPcb95I Hm+Sbku0ScKHrPBMfVCkEJshIbH3hqUQjXYfxpeEYfGV7kpWp9PAltLYlyOa0sEfHd1u2f PMhP2z1uXiPNKk9WzdoFW9kOhIif+NU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-GRna24W9PaSpQ1nEpBIONA-1; Tue, 16 Mar 2021 12:49:19 -0400 X-MC-Unique: GRna24W9PaSpQ1nEpBIONA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 681FEA40C2; Tue, 16 Mar 2021 16:49:18 +0000 (UTC) Received: from localhost (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22E4219701; Tue, 16 Mar 2021 16:49:16 +0000 (UTC) Date: Tue, 16 Mar 2021 17:49:14 +0100 From: Igor Mammedov To: Paolo Bonzini Subject: Re: Windows 10 won't run on default x86_64 machine anymore Message-ID: <20210316174914.50efc26b@redhat.com> In-Reply-To: <20210316141044.311688bb@redhat.com> References: <20210315185302.29b0d90d@redhat.com> <20210316015503.GA1008366@private.email.ne.jp> <20210316131304.220a53b9@redhat.com> <9e2e1d83-29c1-053a-fd43-187f6f824b39@redhat.com> <20210316141044.311688bb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Reinoud Zandijk , qemu-devel@nongnu.org, Isaku Yamahata Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 16 Mar 2021 14:10:44 +0100 Igor Mammedov wrote: > On Tue, 16 Mar 2021 13:49:57 +0100 > Paolo Bonzini wrote: > > > On 16/03/21 13:13, Igor Mammedov wrote: > > >>> Surprisingly without accelerator ie with tcg the default machine does seem to > > >>> get to the login prompt. Is the ACPI data tailored to indicate an > > >>> accelerator/VM or is it static? Could it be that the CPU reported by my > > >>> machine is causing the issue? With the NVMM accelerator it passes on the hosts > > >> > > >> I think tcg case can be explained by x86_machine_is_smm_enabled() > > >> > > >> bool x86_machine_is_smm_enabled(const X86MachineState *x86ms) > > >> ... > > >> if (tcg_enabled() || qtest_enabled()) { > > >> smm_available = true; > > >> } else if (kvm_enabled()) { > > >> smm_available = kvm_has_smm(); > > >> } > > >> ... > > >> > > >> Although I don't know about nvmm case, this function also needs to be updated > > >> if smi isn't supported. > > > can you submit a patch for this please? > > > > nvmm is not part of upstream yet, so I guess it's up to Reinoud to fix > > it. Still, reproducing his testing conditions with KVM and -M smm=off > > is probably interesting because it also affects HAX, HVF and WHPX which > > are supported upstream. > > I'm in process of preparing test env for it with reported Windows version, > so I'll try this case as well. > Here is test matrix booting Windows install ISO: qemu-system-x86_64 -m 4G -smp cores=2 -cpu host -accel kvm -vnc localhost:0 -snapshot -M pc-i440fx-6.0,smm=off \ -cdrom en_windows_10_business_editions_version_1809_updated_jan_2019_x64_dvd_72a665f1.iso | smm=on | smm=off | -------------------------------------------------- QEMU6.0 pc-i440fx-5.2 | pass | pass | defaut smm-compat=on | | | -------------------------------------------------- QEMU6.0 pc-i440fx-6.0 | pass | fail | defaut smm-compat=off | | | -------------------------------------------------| so it will break booting Windows on accelerators that do not support smm by default starting from pc-i440fx-6.0 machine type. It asserts in: 0xa5_FAILED_ACPI_TRANSITION_ACPI!ACPIEnableEnterACPIMode I haven't looked into what it doesn't like there. > > Paolo > > > >