All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tools/x86/kcpuid: Add AMD leaf 0x8000001E
Date: Wed, 17 Mar 2021 08:30:11 +0800	[thread overview]
Message-ID: <20210317003011.GD49151@shbuild999.sh.intel.com> (raw)
In-Reply-To: <YFDlLHsE7AhOgkDi@google.com>

Hi Boris and Sean,

On Tue, Mar 16, 2021 at 10:04:44AM -0700, Sean Christopherson wrote:
> On Tue, Mar 16, 2021, Borislav Petkov wrote:
> > On Tue, Mar 16, 2021 at 03:42:23PM +0800, Feng Tang wrote:
> > > Also I'm wondering for some basic leaf and extended leaf which
> > > may has different definition for different vendors, do we need
> > > to seprate the csv to a general one and vendor specific ones.
> > 
> > Do you know of such?

No. When I read the patch, I googled some doc for the registers definition
which I found different from Intel's manual.

> > 
> > Because AFAIK vendors own, more or less, each range. Like, Intel owns
> > the base range and AMD the extended so there should be no conflicts
> > actually...
> 
> There are no known conflicts, and all sorts of things would break horribly if
> any CPU vendor (or hypervsior) were careless enough to redefine a CPUID bit.

Great to know these sharing policy between vendors, which will save many
troubles for us :)

Also I just took a look at code of cpuid, which has some functions like
	print_leafX_vendorA
	print_leafX_vendorB
	print_leafX_vendorC
but as you mentioned, I didn't find obvious overlaps of specific bits.

Thanks,
Feng

  reply	other threads:[~2021-03-17  0:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 12:59 [PATCH 1/2] tools/x86/kcpuid: Check last token too Borislav Petkov
2021-03-15 12:59 ` [PATCH 2/2] tools/x86/kcpuid: Add AMD leaf 0x8000001E Borislav Petkov
2021-03-16  7:42   ` Feng Tang
2021-03-16 14:28     ` Borislav Petkov
2021-03-16 17:04       ` Sean Christopherson
2021-03-17  0:30         ` Feng Tang [this message]
2021-03-18 10:38   ` [tip: x86/misc] " tip-bot2 for Borislav Petkov
2021-03-16  7:34 ` [PATCH 1/2] tools/x86/kcpuid: Check last token too Feng Tang
2021-03-18 10:38 ` [tip: x86/misc] " tip-bot2 for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317003011.GD49151@shbuild999.sh.intel.com \
    --to=feng.tang@intel.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.