From: Will Deacon <will@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
dave.martin@arm.com, daniel.kiss@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
broonie@kernel.org, kernel-team@android.com
Subject: Re: [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper
Date: Wed, 17 Mar 2021 14:01:15 +0000 [thread overview]
Message-ID: <20210317140115.GA5295@willie-the-truck> (raw)
In-Reply-To: <20210316101312.102925-5-maz@kernel.org>
On Tue, Mar 16, 2021 at 10:13:06AM +0000, Marc Zyngier wrote:
> The KVM code contains a number of "sve_vq_from_vl(vcpu->arch.sve_max_vl)"
> instances, and we are about to add more.
>
> Introduce vcpu_sve_vq() as a shorthand for this expression.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/include/asm/kvm_host.h | 4 +++-
> arch/arm64/kvm/guest.c | 6 +++---
> arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index fb1d78299ba0..c4afe3d3397f 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -375,6 +375,8 @@ struct kvm_vcpu_arch {
> #define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \
> sve_ffr_offset((vcpu)->arch.sve_max_vl))
>
> +#define vcpu_sve_vq(vcpu) sve_vq_from_vl((vcpu)->arch.sve_max_vl)
nit: maybe vcpu_sve_max_vq() would be a better name?
Either way:
Acked-by: Will Deacon <will@kernel.org>
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
kvmarm@lists.cs.columbia.edu, broonie@kernel.org,
kernel-team@android.com, dave.martin@arm.com,
linux-arm-kernel@lists.infradead.org, daniel.kiss@arm.com
Subject: Re: [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper
Date: Wed, 17 Mar 2021 14:01:15 +0000 [thread overview]
Message-ID: <20210317140115.GA5295@willie-the-truck> (raw)
In-Reply-To: <20210316101312.102925-5-maz@kernel.org>
On Tue, Mar 16, 2021 at 10:13:06AM +0000, Marc Zyngier wrote:
> The KVM code contains a number of "sve_vq_from_vl(vcpu->arch.sve_max_vl)"
> instances, and we are about to add more.
>
> Introduce vcpu_sve_vq() as a shorthand for this expression.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/include/asm/kvm_host.h | 4 +++-
> arch/arm64/kvm/guest.c | 6 +++---
> arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index fb1d78299ba0..c4afe3d3397f 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -375,6 +375,8 @@ struct kvm_vcpu_arch {
> #define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \
> sve_ffr_offset((vcpu)->arch.sve_max_vl))
>
> +#define vcpu_sve_vq(vcpu) sve_vq_from_vl((vcpu)->arch.sve_max_vl)
nit: maybe vcpu_sve_max_vq() would be a better name?
Either way:
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
dave.martin@arm.com, daniel.kiss@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
broonie@kernel.org, kernel-team@android.com
Subject: Re: [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper
Date: Wed, 17 Mar 2021 14:01:15 +0000 [thread overview]
Message-ID: <20210317140115.GA5295@willie-the-truck> (raw)
In-Reply-To: <20210316101312.102925-5-maz@kernel.org>
On Tue, Mar 16, 2021 at 10:13:06AM +0000, Marc Zyngier wrote:
> The KVM code contains a number of "sve_vq_from_vl(vcpu->arch.sve_max_vl)"
> instances, and we are about to add more.
>
> Introduce vcpu_sve_vq() as a shorthand for this expression.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/include/asm/kvm_host.h | 4 +++-
> arch/arm64/kvm/guest.c | 6 +++---
> arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index fb1d78299ba0..c4afe3d3397f 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -375,6 +375,8 @@ struct kvm_vcpu_arch {
> #define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \
> sve_ffr_offset((vcpu)->arch.sve_max_vl))
>
> +#define vcpu_sve_vq(vcpu) sve_vq_from_vl((vcpu)->arch.sve_max_vl)
nit: maybe vcpu_sve_max_vq() would be a better name?
Either way:
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-17 14:02 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 10:13 [PATCH 00/10] KVM: arm64: Enable SVE support on nVHE systems Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` [PATCH 01/10] KVM: arm64: Provide KVM's own save/restore SVE primitives Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:31 ` Quentin Perret
2021-03-16 10:31 ` Quentin Perret
2021-03-16 10:31 ` Quentin Perret
2021-03-16 12:17 ` Marc Zyngier
2021-03-16 12:17 ` Marc Zyngier
2021-03-16 12:17 ` Marc Zyngier
2021-03-17 14:30 ` Will Deacon
2021-03-17 14:30 ` Will Deacon
2021-03-17 14:30 ` Will Deacon
2021-03-16 10:13 ` [PATCH 02/10] KVM: arm64: Use {read,write}_sysreg_el1 to access ZCR_EL1 Marc Zyngier
2021-03-16 10:13 ` [PATCH 02/10] KVM: arm64: Use {read, write}_sysreg_el1 " Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 14:31 ` [PATCH 02/10] KVM: arm64: Use {read,write}_sysreg_el1 " Will Deacon
2021-03-17 14:31 ` Will Deacon
2021-03-17 14:31 ` Will Deacon
2021-03-16 10:13 ` [PATCH 03/10] KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 14:31 ` Will Deacon
2021-03-17 14:31 ` Will Deacon
2021-03-17 14:31 ` Will Deacon
2021-03-16 10:13 ` [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 14:01 ` Will Deacon [this message]
2021-03-17 14:01 ` Will Deacon
2021-03-17 14:01 ` Will Deacon
2021-03-16 10:13 ` [PATCH 05/10] KVM: arm64: Rework SVE host-save/guest-restore Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 14:29 ` Will Deacon
2021-03-17 14:29 ` Will Deacon
2021-03-17 14:29 ` Will Deacon
2021-03-17 14:54 ` Marc Zyngier
2021-03-17 14:54 ` Marc Zyngier
2021-03-17 14:54 ` Marc Zyngier
2021-03-16 10:13 ` [PATCH 06/10] KVM: arm64: Map SVE context at EL2 when available Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 16:01 ` Will Deacon
2021-03-17 16:01 ` Will Deacon
2021-03-17 16:01 ` Will Deacon
2021-03-18 8:56 ` Marc Zyngier
2021-03-18 8:56 ` Marc Zyngier
2021-03-18 8:56 ` Marc Zyngier
2021-03-16 10:13 ` [PATCH 07/10] KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 17:17 ` Will Deacon
2021-03-17 17:17 ` Will Deacon
2021-03-17 17:17 ` Will Deacon
2021-03-17 17:20 ` Will Deacon
2021-03-17 17:20 ` Will Deacon
2021-03-17 17:20 ` Will Deacon
2021-03-16 10:13 ` [PATCH 08/10] KVM: arm64: Add a nVHE-specific SVE VQ reset hypercall Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:45 ` Quentin Perret
2021-03-16 10:45 ` Quentin Perret
2021-03-16 10:45 ` Quentin Perret
2021-03-16 12:18 ` Marc Zyngier
2021-03-16 12:18 ` Marc Zyngier
2021-03-16 12:18 ` Marc Zyngier
2021-03-16 14:24 ` Andrew Scull
2021-03-16 14:24 ` Andrew Scull
2021-03-16 14:24 ` Andrew Scull
2021-03-16 15:00 ` Marc Zyngier
2021-03-16 15:00 ` Marc Zyngier
2021-03-16 15:00 ` Marc Zyngier
2021-03-16 10:13 ` [PATCH 09/10] KVM: arm64: Save/restore SVE state for nVHE Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 17:57 ` Will Deacon
2021-03-17 17:57 ` Will Deacon
2021-03-17 17:57 ` Will Deacon
2021-03-18 9:12 ` Marc Zyngier
2021-03-18 9:12 ` Marc Zyngier
2021-03-18 9:12 ` Marc Zyngier
2021-03-16 10:13 ` [PATCH 10/10] KVM: arm64: Enable SVE support " Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-16 10:13 ` Marc Zyngier
2021-03-17 18:00 ` Will Deacon
2021-03-17 18:00 ` Will Deacon
2021-03-17 18:00 ` Will Deacon
2021-03-18 9:14 ` Marc Zyngier
2021-03-18 9:14 ` Marc Zyngier
2021-03-18 9:14 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317140115.GA5295@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.kiss@arm.com \
--cc=dave.martin@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.