From: Vladimir Oltean <olteanv@gmail.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, pavana.sharma@digi.com,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
andrew@lunn.ch, ashkan.boldaji@digi.com, davem@davemloft.net,
kuba@kernel.org, f.fainelli@gmail.com, vivien.didelot@gmail.com,
lkp@intel.com
Subject: Re: [PATCH net-next v17 2/4] net: dsa: mv88e6xxx: wrap .set_egress_port method
Date: Wed, 17 Mar 2021 16:22:35 +0200 [thread overview]
Message-ID: <20210317142235.jgkv2q3743wb47wt@skbuf> (raw)
In-Reply-To: <20210317134643.24463-3-kabel@kernel.org>
On Wed, Mar 17, 2021 at 02:46:41PM +0100, Marek Behún wrote:
> There are two implementations of the .set_egress_port method, and both
> of them, if successful, set chip->*gress_dest_port variable.
>
> To avoid code repetition, wrap this method into
> mv88e6xxx_set_egress_port.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Reviewed-by: Pavana Sharma <pavana.sharma@digi.com>
> ---
Separately from this series, do you think you can rename the
"egress_port" into "monitor_port" across the driver? Seeing an
EGRESS_DIR_INGRESS is pretty strange.
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2021-03-17 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 13:46 [PATCH net-next v17 0/4] Add support for mv88e6393x family of Marvell Marek Behún
2021-03-17 13:46 ` [PATCH net-next v17 1/4] net: dsa: mv88e6xxx: change serdes lane parameter type from u8 type to int Marek Behún
2021-03-17 13:46 ` [PATCH net-next v17 2/4] net: dsa: mv88e6xxx: wrap .set_egress_port method Marek Behún
2021-03-17 14:22 ` Vladimir Oltean [this message]
2021-03-17 14:34 ` Marek Behún
2021-03-17 14:40 ` Vladimir Oltean
2021-03-17 13:46 ` [PATCH net-next v17 3/4] net: dsa: mv88e6xxx: add support for mv88e6393x family Marek Behún
2021-03-17 13:46 ` [PATCH net-next v17 4/4] net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst Marek Behún
2021-03-17 14:32 ` Vladimir Oltean
2021-03-17 21:50 ` [PATCH net-next v17 0/4] Add support for mv88e6393x family of Marvell patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317142235.jgkv2q3743wb47wt@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=ashkan.boldaji@digi.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pavana.sharma@digi.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.