From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00699C433DB for ; Wed, 17 Mar 2021 14:32:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E49564F67 for ; Wed, 17 Mar 2021 14:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbhCQOcH (ORCPT ); Wed, 17 Mar 2021 10:32:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:54164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231920AbhCQOcD (ORCPT ); Wed, 17 Mar 2021 10:32:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0EAD664E13; Wed, 17 Mar 2021 14:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615991523; bh=9PV7SAdG8UI+hcTymUc6iMtrRcc/ff/6MFt24sMoR4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jphF1XmayKtQgSAtPuUftY5Qv/YT6yoj383uQjZE9zvLm8jWI0tGF3DKhJvZHyA51 VnqyWU7ZTXljYlMjbty/RyYjFGXE0grk9sDvV7aa8J5Uvr/IADhNbo5vB3vIhLTqMW b7w/nLO7cbrpcFlk1s6mUXORXdd+LGgUmFOcBwSZ4Wei55J8dDDJQwlAlr824DnzuB l5rhJxilxB0D0sR1G711IZs0i4BocWJo8eBBZEFnF+2AWPkXIyFOBT8yK3b0zr8L2S qKkM4NSqSu5LucgAZEYY/jHlcF8flGsXAnjXOvZQef+nOE2VduRVqOy/asdAIsAXqK BwfJLxLH6a8VQ== Date: Wed, 17 Mar 2021 14:31:57 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 03/10] KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs Message-ID: <20210317143157.GD5393@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-4-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316101312.102925-4-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 16, 2021 at 10:13:05AM +0000, Marc Zyngier wrote: > The vcpu_sve_pffr() returns a pointer, which can be an interesting > thing to do on nVHE. Wrap the pointer with kern_hyp_va(), and > take this opportunity to remove the unnecessary casts (sve_state > being a void *). > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 3d10e6527f7d..fb1d78299ba0 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -372,8 +372,8 @@ struct kvm_vcpu_arch { > }; > > /* Pointer to the vcpu's SVE FFR for sve_{save,load}_state() */ > -#define vcpu_sve_pffr(vcpu) ((void *)((char *)((vcpu)->arch.sve_state) + \ > - sve_ffr_offset((vcpu)->arch.sve_max_vl))) > +#define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \ > + sve_ffr_offset((vcpu)->arch.sve_max_vl)) > > #define vcpu_sve_state_size(vcpu) ({ \ > size_t __size_ret; \ Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71418C433E0 for ; Wed, 17 Mar 2021 14:32:10 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id BC9D864E13 for ; Wed, 17 Mar 2021 14:32:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC9D864E13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4EB104B441; Wed, 17 Mar 2021 10:32:09 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NkaG9PyFuYpW; Wed, 17 Mar 2021 10:32:08 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 32D6A4B578; Wed, 17 Mar 2021 10:32:08 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 09DE84B40F for ; Wed, 17 Mar 2021 10:32:07 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z++G1pbwIYGc for ; Wed, 17 Mar 2021 10:32:06 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0E1B04B3EE for ; Wed, 17 Mar 2021 10:32:06 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0EAD664E13; Wed, 17 Mar 2021 14:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615991523; bh=9PV7SAdG8UI+hcTymUc6iMtrRcc/ff/6MFt24sMoR4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jphF1XmayKtQgSAtPuUftY5Qv/YT6yoj383uQjZE9zvLm8jWI0tGF3DKhJvZHyA51 VnqyWU7ZTXljYlMjbty/RyYjFGXE0grk9sDvV7aa8J5Uvr/IADhNbo5vB3vIhLTqMW b7w/nLO7cbrpcFlk1s6mUXORXdd+LGgUmFOcBwSZ4Wei55J8dDDJQwlAlr824DnzuB l5rhJxilxB0D0sR1G711IZs0i4BocWJo8eBBZEFnF+2AWPkXIyFOBT8yK3b0zr8L2S qKkM4NSqSu5LucgAZEYY/jHlcF8flGsXAnjXOvZQef+nOE2VduRVqOy/asdAIsAXqK BwfJLxLH6a8VQ== Date: Wed, 17 Mar 2021 14:31:57 +0000 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH 03/10] KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs Message-ID: <20210317143157.GD5393@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-4-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-4-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kvm@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, broonie@kernel.org, kernel-team@android.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org, daniel.kiss@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Mar 16, 2021 at 10:13:05AM +0000, Marc Zyngier wrote: > The vcpu_sve_pffr() returns a pointer, which can be an interesting > thing to do on nVHE. Wrap the pointer with kern_hyp_va(), and > take this opportunity to remove the unnecessary casts (sve_state > being a void *). > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 3d10e6527f7d..fb1d78299ba0 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -372,8 +372,8 @@ struct kvm_vcpu_arch { > }; > > /* Pointer to the vcpu's SVE FFR for sve_{save,load}_state() */ > -#define vcpu_sve_pffr(vcpu) ((void *)((char *)((vcpu)->arch.sve_state) + \ > - sve_ffr_offset((vcpu)->arch.sve_max_vl))) > +#define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \ > + sve_ffr_offset((vcpu)->arch.sve_max_vl)) > > #define vcpu_sve_state_size(vcpu) ({ \ > size_t __size_ret; \ Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E294C433E0 for ; Wed, 17 Mar 2021 14:34:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9859964EE7 for ; Wed, 17 Mar 2021 14:34:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9859964EE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6HN5+xheEdCkhKAFPPZzWBsqkQYLZ+xyuBO+ILsVZoA=; b=UG+8/Uni3wIUzy4GKCSHJ2qEU xUJNErQQOGcefvWy62z8P8uqKg568Gukm203dw3Vgfpz0qxx/qOSaZjEfL6o0wowAurMl1fr0wTHT Ng+WniBQTD+W9fT3ykNsYurRyz6u/WJnx/3m965HwdkFmWK/K0a/WDdNSxcHbM3UKHzSGp45+n7Ko IfrIGb4vwIazA3LhvdPDFE4jw5Zp32GdkRUPK/iHBkxdgU7EFibuh6oNsOGs7XHWfLouH9dPp57ah MkG2BzruAMe1NEJuXMHZcQWGNpi7Ir5GuWTNlazNsriJB+GBSAZDRc0X5TsIona1B1smyzriV+CnX Yho6pCO6w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMXDW-003Gn5-Ff; Wed, 17 Mar 2021 14:32:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMXDQ-003Glg-SG for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 14:32:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0EAD664E13; Wed, 17 Mar 2021 14:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615991523; bh=9PV7SAdG8UI+hcTymUc6iMtrRcc/ff/6MFt24sMoR4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jphF1XmayKtQgSAtPuUftY5Qv/YT6yoj383uQjZE9zvLm8jWI0tGF3DKhJvZHyA51 VnqyWU7ZTXljYlMjbty/RyYjFGXE0grk9sDvV7aa8J5Uvr/IADhNbo5vB3vIhLTqMW b7w/nLO7cbrpcFlk1s6mUXORXdd+LGgUmFOcBwSZ4Wei55J8dDDJQwlAlr824DnzuB l5rhJxilxB0D0sR1G711IZs0i4BocWJo8eBBZEFnF+2AWPkXIyFOBT8yK3b0zr8L2S qKkM4NSqSu5LucgAZEYY/jHlcF8flGsXAnjXOvZQef+nOE2VduRVqOy/asdAIsAXqK BwfJLxLH6a8VQ== Date: Wed, 17 Mar 2021 14:31:57 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 03/10] KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs Message-ID: <20210317143157.GD5393@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-4-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-4-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_143205_227204_34D7A816 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 10:13:05AM +0000, Marc Zyngier wrote: > The vcpu_sve_pffr() returns a pointer, which can be an interesting > thing to do on nVHE. Wrap the pointer with kern_hyp_va(), and > take this opportunity to remove the unnecessary casts (sve_state > being a void *). > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 3d10e6527f7d..fb1d78299ba0 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -372,8 +372,8 @@ struct kvm_vcpu_arch { > }; > > /* Pointer to the vcpu's SVE FFR for sve_{save,load}_state() */ > -#define vcpu_sve_pffr(vcpu) ((void *)((char *)((vcpu)->arch.sve_state) + \ > - sve_ffr_offset((vcpu)->arch.sve_max_vl))) > +#define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \ > + sve_ffr_offset((vcpu)->arch.sve_max_vl)) > > #define vcpu_sve_state_size(vcpu) ({ \ > size_t __size_ret; \ Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel