From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BD5C433E0 for ; Wed, 17 Mar 2021 16:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E013464F30 for ; Wed, 17 Mar 2021 16:28:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbhCQQ2G (ORCPT ); Wed, 17 Mar 2021 12:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232540AbhCQQ1j (ORCPT ); Wed, 17 Mar 2021 12:27:39 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720CAC06174A for ; Wed, 17 Mar 2021 09:27:39 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id s21so1420325pjq.1 for ; Wed, 17 Mar 2021 09:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MBYMaK89076Yqms9jzDXHj92BGi/krH6Ls/9qUJftRo=; b=ouzpVWP0seNzSvrU7krFFGaBGs2cJ96jR5ESDiDv5hrHSHco6PeHGfJUDN5Wnro7+L CjJc8tndpJjuD2eBMzmH3A4VUpX2Kz3i5DkIYRrRQnBnAryA65AvgPDI+KMd0/bs1H7b T+KAVkCqmFC5XiziVw7Fnw47VnARxZHvcg5pwCqDCBgt6dzDNhOIAvTfDTV0l+HmDQ7S x3GIl5SOXZM+MhuiM8dBdpNSKV1VROeaPmiht/xTOQWM5sSAsaVLH1zEchL8Y1DwVS5p ZP2BqbEe9fqCOkatrtluvdLeMaqGdmp4Z90MSGXLXR7z1kxcdaFBMoE6e73n2RVtIpqX mPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MBYMaK89076Yqms9jzDXHj92BGi/krH6Ls/9qUJftRo=; b=fZ8klRxSbzbDMJX5FIjd8GsJbFcnnYCUOrPCu0PkmE29PkznAV/eoQQADue25Re4wQ yE0Dyr1qKTXpqq6kri1G46R/xWX5uyzeEit5zZSSHh5+DBH1uKZZDL7uejlF6C2PDzxZ XhhFWMC3rbrIaQ4nF8cGge1t5o0yp+KslWw7H/aLD3htqE+iL+tmsJo5Myuh8yI+nl// njLTqcfwV3+u0gpcJZ8oNmWgpCzJODIue5Z08iL8ghm8pMntM6e90Xsh5M7kscbVa2YM spz0o1iw413xU10PMhuWYABTMQM2Ey2CMiaD9qAKQp7Ek4X3H087EchGCseFrGXLDnR5 YMug== X-Gm-Message-State: AOAM531nk7u1QU4r4rZIbebqBpptDppw2iibsZ0mzPz2Iz4a465Utia9 TtxofvWgJhdx1eRMhkGr4B7utJqsSm6zdw== X-Google-Smtp-Source: ABdhPJx92boKt/4oQc9PjsC+hH95eM143VVVrDH6h71Zq0GlSQ3s9m6xNHY1jPU/pATwN4UYmUnPqg== X-Received: by 2002:a17:902:bb83:b029:e5:dacc:9035 with SMTP id m3-20020a170902bb83b02900e5dacc9035mr5130619pls.80.1615998458964; Wed, 17 Mar 2021 09:27:38 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t16sm20450137pfc.204.2021.03.17.09.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 09:27:38 -0700 (PDT) Date: Wed, 17 Mar 2021 10:27:36 -0600 From: Mathieu Poirier To: Ben Levinsky Cc: "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Simek , "Ed T. Mooring" Subject: Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Message-ID: <20210317162736.GB1494354@xps15> References: <20210223154447.13247-1-ben.levinsky@xilinx.com> <20210223154447.13247-6-ben.levinsky@xilinx.com> <20210309165330.GA4013290@xps15> <38527B70-FE3A-4D05-8C2E-6A95A3D4ADF3@xilinx.com> <20210315173724.GB1342614@xps15> <09895E3D-AED4-4DBF-A48C-684271275D49@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <09895E3D-AED4-4DBF-A48C-684271275D49@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Mar 15, 2021 at 09:32:40PM +0000, Ben Levinsky wrote: > > > -----Original Message----- > From: Mathieu Poirier > Date: Monday, March 15, 2021 at 10:37 AM > To: Ben Levinsky > Cc: "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Simek , "Ed T. Mooring" > Subject: Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver > > On Thu, Mar 11, 2021 at 11:49:13PM +0000, Ben Levinsky wrote: > > Hi Mathieu > > > > -----Original Message----- > > From: Mathieu Poirier > > Date: Tuesday, March 9, 2021 at 8:53 AM > > To: Ben Levinsky > > Cc: "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Simek > > Subject: Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver > > > > [...] > > > > > + > > > +/** > > > + * zynqmp_r5_probe - Probes ZynqMP R5 processor device node > > > + * this is called for each individual R5 core to > > > + * set up mailbox, Xilinx platform manager unique ID, > > > + * add to rproc core > > > + * > > > + * @pdev: domain platform device for current R5 core > > > + * @node: pointer of the device node for current R5 core > > > + * @rpu_mode: mode to configure RPU, split or lockstep > > > + * > > > + * Return: 0 for success, negative value for failure. > > > + */ > > > +static struct zynqmp_r5_rproc *zynqmp_r5_probe(struct platform_device *pdev, > > > + struct device_node *node, > > > + enum rpu_oper_mode rpu_mode) > > > +{ > > > + int ret, num_banks; > > > + struct device *dev = &pdev->dev; > > > + struct rproc *rproc_ptr; > > > + struct zynqmp_r5_rproc *z_rproc; > > > + struct device_node *r5_node; > > > + > > > + /* Allocate remoteproc instance */ > > > + rproc_ptr = devm_rproc_alloc(dev, dev_name(dev), &zynqmp_r5_rproc_ops, > > > + NULL, sizeof(struct zynqmp_r5_rproc)); > > > + if (!rproc_ptr) { > > > + ret = -ENOMEM; > > > + goto error; > > > + } > > > + > > > + rproc_ptr->auto_boot = false; > > > + z_rproc = rproc_ptr->priv; > > > + z_rproc->rproc = rproc_ptr; > > > + r5_node = z_rproc->rproc->dev.parent->of_node; > > > + > > > + /* Set up DMA mask */ > > > + ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); > > > + if (ret) > > > + goto error; > > > + > > > + /* Get R5 power domain node */ > > > + ret = of_property_read_u32(node, "power-domain", &z_rproc->pnode_id); > > > + if (ret) > > > + goto error; > > > + > > > + ret = r5_set_mode(z_rproc, rpu_mode); > > > + if (ret) > > > + goto error; > > > + > > > + if (of_property_read_bool(node, "mboxes")) { > > > + ret = zynqmp_r5_setup_mbox(z_rproc, node); > > > + if (ret) > > > + goto error; > > > + } > > > + > > > + /* go through TCM banks for r5 node */ > > > + num_banks = of_count_phandle_with_args(r5_node, BANK_LIST_PROP, NULL); > > > + if (num_banks <= 0) { > > > + dev_err(dev, "need to specify TCM banks\n"); > > > + ret = -EINVAL; > > > + goto error; > > > + } > > > + > > > + if (num_banks > NUM_SRAMS) { > > > + dev_err(dev, "max number of srams is %d. given: %d \r\n", > > > + NUM_SRAMS, num_banks); > > > + ret = -EINVAL; > > > + goto error; > > > + } > > > + > > > + /* construct collection of srams used by the current R5 core */ > > > + for (; num_banks; num_banks--) { > > > + struct resource rsc; > > > + struct device_node *dt_node; > > > + resource_size_t size; > > > + int i; > > > + > > > + dt_node = of_parse_phandle(r5_node, BANK_LIST_PROP, i); > > > > Variable @i is not initialised but it is used as an index to retrieve a handle > > to the sram banks. That code _should_ have failed frequently or at least have > > yielded abnormal results often enough to be noticed. Why wasn't it the case? > > > > I will stop here for the moment. > > > > [Ben] > > Yes this should be initialized. The reason this got through is that as i defaults to 0 and the 0th bank housed the required data. the case where SRAMS that can be written to, 0xFFE20000 in this case of split mode and on R5-0, was not caught. > > > > Here @i is a variable allocated on the stack and as such it is garanteed to be > garbage on initialisation - it will do anything but default to 0. > > Ok. > > > Instead of i I will use > > > > sram_node = of_parse_phandle(node, BANK_LIST_PROP, > > num_banks - 1); > > Do you have to start with the last bank? If memory serves me well it isn't the > case in the previous revisions. Why not go back to the implementation you had > in V25? > > Makes sense. Will revert as suggested. For your next revision, go back to V25 and fix only what I commented on. I can't remember but you may also have to fix the put_device() problem we've been discussing. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D1F6C433DB for ; Wed, 17 Mar 2021 16:29:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD4D164EFC for ; Wed, 17 Mar 2021 16:29:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD4D164EFC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jkbugGbxQcV9Iv3HSTR4Y2ezqALEph/2PV2fjlmhg3o=; b=T401+HOzDKaxMuWQ3f9dyQVxb 3k/v3B5mxg7hNbIsVNO4jgBpc/P8zxwW8DQptfpxDjXu2IQyDANXAVYkz/TB+xvkzYWeJQGD9x40n jRrbWwo62eVRVwTozHKhruQrlZi8bJAFZjjsa0BfOYmej6OzOfsEFJtBzxu/o9Eevnyb+AHia1KHi a0WWUeEHpyEL+w98uJ0enkXUZoGW35fQa/GrOQoGoI2tQSTfYymk9negz9Bb5c8FhSWcmg7XBjBBD RgNGj+Hra/IXRAENkThV34vQiHKfWN3bfx7CTnMi1nQi0SWzQvOVtUuy7BtjDQb9qJCIpqHno6HTt lROdqWLUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMZ1N-003Ydp-F0; Wed, 17 Mar 2021 16:27:45 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMZ1I-003YdC-E6 for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 16:27:42 +0000 Received: by mail-pj1-x1031.google.com with SMTP id ha17so1416943pjb.2 for ; Wed, 17 Mar 2021 09:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MBYMaK89076Yqms9jzDXHj92BGi/krH6Ls/9qUJftRo=; b=ouzpVWP0seNzSvrU7krFFGaBGs2cJ96jR5ESDiDv5hrHSHco6PeHGfJUDN5Wnro7+L CjJc8tndpJjuD2eBMzmH3A4VUpX2Kz3i5DkIYRrRQnBnAryA65AvgPDI+KMd0/bs1H7b T+KAVkCqmFC5XiziVw7Fnw47VnARxZHvcg5pwCqDCBgt6dzDNhOIAvTfDTV0l+HmDQ7S x3GIl5SOXZM+MhuiM8dBdpNSKV1VROeaPmiht/xTOQWM5sSAsaVLH1zEchL8Y1DwVS5p ZP2BqbEe9fqCOkatrtluvdLeMaqGdmp4Z90MSGXLXR7z1kxcdaFBMoE6e73n2RVtIpqX mPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MBYMaK89076Yqms9jzDXHj92BGi/krH6Ls/9qUJftRo=; b=U4SmRWpKqXzUtWtKwyhyKbVSR7EzIMNM3gW4taDbQKaJvrpp4/ibe1oXd9FbWWA8S8 3eBn74evKSEWEimuyvIp1NNzcHgfOX9BZcgsU88Xh7gjZOr4L2TwfmC7r9wgCiVznJcS uN34QBHpIUxVAgZcevyb63y8I85PMUnWEEV9R2pSIo9YT4GneSC5uvjcb5M5tr8ltBUd fX3qxVU9i+tCX11m1b+MwausqnJhkQI+xFdpSxME9lM+ePv8umLBsGqQsWWbPgWSjYsY VOCALHDoLiP1l9pu90vSalrmEr0KWYcrtRvtAtvuFnuLqmqRuq7ABavcriBiemUQCT94 3vmA== X-Gm-Message-State: AOAM530CHCcMeg1eYFzbZTqBJCj2l4U3u59ZmNFx3dFP75LtYoqyAEi9 +kThOaHMvzKW4KiRpyse2s/7LA== X-Google-Smtp-Source: ABdhPJx92boKt/4oQc9PjsC+hH95eM143VVVrDH6h71Zq0GlSQ3s9m6xNHY1jPU/pATwN4UYmUnPqg== X-Received: by 2002:a17:902:bb83:b029:e5:dacc:9035 with SMTP id m3-20020a170902bb83b02900e5dacc9035mr5130619pls.80.1615998458964; Wed, 17 Mar 2021 09:27:38 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t16sm20450137pfc.204.2021.03.17.09.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 09:27:38 -0700 (PDT) Date: Wed, 17 Mar 2021 10:27:36 -0600 From: Mathieu Poirier To: Ben Levinsky Cc: "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Simek , "Ed T. Mooring" Subject: Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Message-ID: <20210317162736.GB1494354@xps15> References: <20210223154447.13247-1-ben.levinsky@xilinx.com> <20210223154447.13247-6-ben.levinsky@xilinx.com> <20210309165330.GA4013290@xps15> <38527B70-FE3A-4D05-8C2E-6A95A3D4ADF3@xilinx.com> <20210315173724.GB1342614@xps15> <09895E3D-AED4-4DBF-A48C-684271275D49@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <09895E3D-AED4-4DBF-A48C-684271275D49@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_162740_536151_BC7EEAE9 X-CRM114-Status: GOOD ( 33.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMTUsIDIwMjEgYXQgMDk6MzI6NDBQTSArMDAwMCwgQmVuIExldmluc2t5IHdy b3RlOgo+IAo+IAo+IO+7vy0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gRnJvbTogTWF0aGll dSBQb2lyaWVyIDxtYXRoaWV1LnBvaXJpZXJAbGluYXJvLm9yZz4KPiBEYXRlOiBNb25kYXksIE1h cmNoIDE1LCAyMDIxIGF0IDEwOjM3IEFNCj4gVG86IEJlbiBMZXZpbnNreSA8QkxFVklOU0tAeGls aW54LmNvbT4KPiBDYzogImRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnIiA8ZGV2aWNldHJlZUB2 Z2VyLmtlcm5lbC5vcmc+LCAibGludXgtcmVtb3RlcHJvY0B2Z2VyLmtlcm5lbC5vcmciIDxsaW51 eC1yZW1vdGVwcm9jQHZnZXIua2VybmVsLm9yZz4sICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwu b3JnIiA8bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZz4sICJsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmciIDxsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc+ LCBNaWNoYWwgU2ltZWsgPG1pY2hhbHNAeGlsaW54LmNvbT4sICJFZCBULiBNb29yaW5nIiA8ZW1v b3JpbmdAeGlsaW54LmNvbT4KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyNiA1LzVdIHJlbW90ZXBy b2M6IEFkZCBpbml0aWFsIHp5bnFtcCBSNSByZW1vdGVwcm9jIGRyaXZlcgo+IAo+ICAgICBPbiBU aHUsIE1hciAxMSwgMjAyMSBhdCAxMTo0OToxM1BNICswMDAwLCBCZW4gTGV2aW5za3kgd3JvdGU6 Cj4gICAgID4gSGkgTWF0aGlldQo+ICAgICA+IAo+ICAgICA+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tCj4gICAgID4gRnJvbTogTWF0aGlldSBQb2lyaWVyIDxtYXRoaWV1LnBvaXJpZXJAbGlu YXJvLm9yZz4KPiAgICAgPiBEYXRlOiBUdWVzZGF5LCBNYXJjaCA5LCAyMDIxIGF0IDg6NTMgQU0K PiAgICAgPiBUbzogQmVuIExldmluc2t5IDxCTEVWSU5TS0B4aWxpbnguY29tPgo+ICAgICA+IENj OiAiZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmciIDxkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9y Zz4sICJsaW51eC1yZW1vdGVwcm9jQHZnZXIua2VybmVsLm9yZyIgPGxpbnV4LXJlbW90ZXByb2NA dmdlci5rZXJuZWwub3JnPiwgImxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmciIDxsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnPiwgImxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZyIgPGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz4sIE1pY2hhbCBTaW1l ayA8bWljaGFsc0B4aWxpbnguY29tPgo+ICAgICA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjI2IDUv NV0gcmVtb3RlcHJvYzogQWRkIGluaXRpYWwgenlucW1wIFI1IHJlbW90ZXByb2MgZHJpdmVyCj4g ICAgID4gCj4gICAgID4gICAgIFsuLi5dCj4gICAgID4gCj4gICAgID4gICAgID4gKwo+ICAgICA+ ICAgICA+ICsvKioKPiAgICAgPiAgICAgPiArICogenlucW1wX3I1X3Byb2JlIC0gUHJvYmVzIFp5 bnFNUCBSNSBwcm9jZXNzb3IgZGV2aWNlIG5vZGUKPiAgICAgPiAgICAgPiArICoJCSAgICAgICB0 aGlzIGlzIGNhbGxlZCBmb3IgZWFjaCBpbmRpdmlkdWFsIFI1IGNvcmUgdG8KPiAgICAgPiAgICAg PiArICoJCSAgICAgICBzZXQgdXAgbWFpbGJveCwgWGlsaW54IHBsYXRmb3JtIG1hbmFnZXIgdW5p cXVlIElELAo+ICAgICA+ICAgICA+ICsgKgkJICAgICAgIGFkZCB0byBycHJvYyBjb3JlCj4gICAg ID4gICAgID4gKyAqCj4gICAgID4gICAgID4gKyAqIEBwZGV2OiBkb21haW4gcGxhdGZvcm0gZGV2 aWNlIGZvciBjdXJyZW50IFI1IGNvcmUKPiAgICAgPiAgICAgPiArICogQG5vZGU6IHBvaW50ZXIg b2YgdGhlIGRldmljZSBub2RlIGZvciBjdXJyZW50IFI1IGNvcmUKPiAgICAgPiAgICAgPiArICog QHJwdV9tb2RlOiBtb2RlIHRvIGNvbmZpZ3VyZSBSUFUsIHNwbGl0IG9yIGxvY2tzdGVwCj4gICAg ID4gICAgID4gKyAqCj4gICAgID4gICAgID4gKyAqIFJldHVybjogMCBmb3Igc3VjY2VzcywgbmVn YXRpdmUgdmFsdWUgZm9yIGZhaWx1cmUuCj4gICAgID4gICAgID4gKyAqLwo+ICAgICA+ICAgICA+ ICtzdGF0aWMgc3RydWN0IHp5bnFtcF9yNV9ycHJvYyAqenlucW1wX3I1X3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gICAgID4gICAgID4gKwkJCQkJICAgICAgIHN0cnVjdCBk ZXZpY2Vfbm9kZSAqbm9kZSwKPiAgICAgPiAgICAgPiArCQkJCQkgICAgICAgZW51bSBycHVfb3Bl cl9tb2RlIHJwdV9tb2RlKQo+ICAgICA+ICAgICA+ICt7Cj4gICAgID4gICAgID4gKwlpbnQgcmV0 LCBudW1fYmFua3M7Cj4gICAgID4gICAgID4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ ZGV2Owo+ICAgICA+ICAgICA+ICsJc3RydWN0IHJwcm9jICpycHJvY19wdHI7Cj4gICAgID4gICAg ID4gKwlzdHJ1Y3QgenlucW1wX3I1X3Jwcm9jICp6X3Jwcm9jOwo+ICAgICA+ICAgICA+ICsJc3Ry dWN0IGRldmljZV9ub2RlICpyNV9ub2RlOwo+ICAgICA+ICAgICA+ICsKPiAgICAgPiAgICAgPiAr CS8qIEFsbG9jYXRlIHJlbW90ZXByb2MgaW5zdGFuY2UgKi8KPiAgICAgPiAgICAgPiArCXJwcm9j X3B0ciA9IGRldm1fcnByb2NfYWxsb2MoZGV2LCBkZXZfbmFtZShkZXYpLCAmenlucW1wX3I1X3Jw cm9jX29wcywKPiAgICAgPiAgICAgPiArCQkJCSAgICAgTlVMTCwgc2l6ZW9mKHN0cnVjdCB6eW5x bXBfcjVfcnByb2MpKTsKPiAgICAgPiAgICAgPiArCWlmICghcnByb2NfcHRyKSB7Cj4gICAgID4g ICAgID4gKwkJcmV0ID0gLUVOT01FTTsKPiAgICAgPiAgICAgPiArCQlnb3RvIGVycm9yOwo+ICAg ICA+ICAgICA+ICsJfQo+ICAgICA+ICAgICA+ICsKPiAgICAgPiAgICAgPiArCXJwcm9jX3B0ci0+ YXV0b19ib290ID0gZmFsc2U7Cj4gICAgID4gICAgID4gKwl6X3Jwcm9jID0gcnByb2NfcHRyLT5w cml2Owo+ICAgICA+ICAgICA+ICsJel9ycHJvYy0+cnByb2MgPSBycHJvY19wdHI7Cj4gICAgID4g ICAgID4gKwlyNV9ub2RlID0gel9ycHJvYy0+cnByb2MtPmRldi5wYXJlbnQtPm9mX25vZGU7Cj4g ICAgID4gICAgID4gKwo+ICAgICA+ICAgICA+ICsJLyogU2V0IHVwIERNQSBtYXNrICovCj4gICAg ID4gICAgID4gKwlyZXQgPSBkbWFfc2V0X2NvaGVyZW50X21hc2soZGV2LCBETUFfQklUX01BU0so MzIpKTsKPiAgICAgPiAgICAgPiArCWlmIChyZXQpCj4gICAgID4gICAgID4gKwkJZ290byBlcnJv cjsKPiAgICAgPiAgICAgPiArCj4gICAgID4gICAgID4gKwkvKiBHZXQgUjUgcG93ZXIgZG9tYWlu IG5vZGUgKi8KPiAgICAgPiAgICAgPiArCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5vZGUs ICJwb3dlci1kb21haW4iLCAmel9ycHJvYy0+cG5vZGVfaWQpOwo+ICAgICA+ICAgICA+ICsJaWYg KHJldCkKPiAgICAgPiAgICAgPiArCQlnb3RvIGVycm9yOwo+ICAgICA+ICAgICA+ICsKPiAgICAg PiAgICAgPiArCXJldCA9IHI1X3NldF9tb2RlKHpfcnByb2MsIHJwdV9tb2RlKTsKPiAgICAgPiAg ICAgPiArCWlmIChyZXQpCj4gICAgID4gICAgID4gKwkJZ290byBlcnJvcjsKPiAgICAgPiAgICAg PiArCj4gICAgID4gICAgID4gKwlpZiAob2ZfcHJvcGVydHlfcmVhZF9ib29sKG5vZGUsICJtYm94 ZXMiKSkgewo+ICAgICA+ICAgICA+ICsJCXJldCA9IHp5bnFtcF9yNV9zZXR1cF9tYm94KHpfcnBy b2MsIG5vZGUpOwo+ICAgICA+ICAgICA+ICsJCWlmIChyZXQpCj4gICAgID4gICAgID4gKwkJCWdv dG8gZXJyb3I7Cj4gICAgID4gICAgID4gKwl9Cj4gICAgID4gICAgID4gKwo+ICAgICA+ICAgICA+ ICsJLyogZ28gdGhyb3VnaCBUQ00gYmFua3MgZm9yIHI1IG5vZGUgKi8KPiAgICAgPiAgICAgPiAr CW51bV9iYW5rcyA9IG9mX2NvdW50X3BoYW5kbGVfd2l0aF9hcmdzKHI1X25vZGUsIEJBTktfTElT VF9QUk9QLCBOVUxMKTsKPiAgICAgPiAgICAgPiArCWlmIChudW1fYmFua3MgPD0gMCkgewo+ICAg ICA+ICAgICA+ICsJCWRldl9lcnIoZGV2LCAibmVlZCB0byBzcGVjaWZ5IFRDTSBiYW5rc1xuIik7 Cj4gICAgID4gICAgID4gKwkJcmV0ID0gLUVJTlZBTDsKPiAgICAgPiAgICAgPiArCQlnb3RvIGVy cm9yOwo+ICAgICA+ICAgICA+ICsJfQo+ICAgICA+ICAgICA+ICsKPiAgICAgPiAgICAgPiArCWlm IChudW1fYmFua3MgPiBOVU1fU1JBTVMpIHsKPiAgICAgPiAgICAgPiArCQlkZXZfZXJyKGRldiwg Im1heCBudW1iZXIgb2Ygc3JhbXMgaXMgJWQuIGdpdmVuOiAlZCBcclxuIiwKPiAgICAgPiAgICAg PiArCQkJTlVNX1NSQU1TLCBudW1fYmFua3MpOwo+ICAgICA+ICAgICA+ICsJCXJldCA9IC1FSU5W QUw7Cj4gICAgID4gICAgID4gKwkJZ290byBlcnJvcjsKPiAgICAgPiAgICAgPiArCX0KPiAgICAg PiAgICAgPiArCj4gICAgID4gICAgID4gKwkvKiBjb25zdHJ1Y3QgY29sbGVjdGlvbiBvZiBzcmFt cyB1c2VkIGJ5IHRoZSBjdXJyZW50IFI1IGNvcmUgKi8KPiAgICAgPiAgICAgPiArCWZvciAoOyBu dW1fYmFua3M7IG51bV9iYW5rcy0tKSB7Cj4gICAgID4gICAgID4gKwkJc3RydWN0IHJlc291cmNl IHJzYzsKPiAgICAgPiAgICAgPiArCQlzdHJ1Y3QgZGV2aWNlX25vZGUgKmR0X25vZGU7Cj4gICAg ID4gICAgID4gKwkJcmVzb3VyY2Vfc2l6ZV90IHNpemU7Cj4gICAgID4gICAgID4gKwkJaW50IGk7 Cj4gICAgID4gICAgID4gKwo+ICAgICA+ICAgICA+ICsJCWR0X25vZGUgPSBvZl9wYXJzZV9waGFu ZGxlKHI1X25vZGUsIEJBTktfTElTVF9QUk9QLCBpKTsKPiAgICAgPiAKPiAgICAgPiAgICAgVmFy aWFibGUgQGkgaXMgbm90IGluaXRpYWxpc2VkIGJ1dCBpdCBpcyB1c2VkIGFzIGFuIGluZGV4IHRv IHJldHJpZXZlIGEgaGFuZGxlCj4gICAgID4gICAgIHRvIHRoZSBzcmFtIGJhbmtzLiAgVGhhdCBj b2RlIF9zaG91bGRfIGhhdmUgZmFpbGVkIGZyZXF1ZW50bHkgb3IgYXQgbGVhc3QgaGF2ZQo+ICAg ICA+ICAgICB5aWVsZGVkIGFibm9ybWFsIHJlc3VsdHMgb2Z0ZW4gZW5vdWdoIHRvIGJlIG5vdGlj ZWQuICBXaHkgd2Fzbid0IGl0IHRoZSBjYXNlPwo+ICAgICA+IAo+ICAgICA+ICAgICBJIHdpbGwg c3RvcCBoZXJlIGZvciB0aGUgbW9tZW50Lgo+ICAgICA+IAo+ICAgICA+IFtCZW5dCj4gICAgID4g WWVzIHRoaXMgc2hvdWxkIGJlIGluaXRpYWxpemVkLiBUaGUgcmVhc29uIHRoaXMgZ290IHRocm91 Z2ggaXMgdGhhdCBhcyBpIGRlZmF1bHRzIHRvIDAgYW5kIHRoZSAwdGggYmFuayBob3VzZWQgdGhl IHJlcXVpcmVkIGRhdGEuIHRoZSBjYXNlIHdoZXJlIFNSQU1TIHRoYXQgY2FuIGJlIHdyaXR0ZW4g dG8sIDB4RkZFMjAwMDAgaW4gdGhpcyBjYXNlIG9mIHNwbGl0IG1vZGUgYW5kIG9uIFI1LTAsIHdh cyBub3QgY2F1Z2h0Lgo+ICAgICA+IAo+IAo+ICAgICBIZXJlIEBpIGlzIGEgdmFyaWFibGUgYWxs b2NhdGVkIG9uIHRoZSBzdGFjayBhbmQgYXMgc3VjaCBpdCBpcyBnYXJhbnRlZWQgdG8gYmUKPiAg ICAgZ2FyYmFnZSBvbiBpbml0aWFsaXNhdGlvbiAtIGl0IHdpbGwgZG8gYW55dGhpbmcgYnV0IGRl ZmF1bHQgdG8gMC4KPiAKPiBPay4KPiAKPiAgICAgPiBJbnN0ZWFkIG9mIGkgSSB3aWxsIHVzZSAK PiAgICAgPiAKPiAgICAgPiAgICAgICAgICAgICAgICAgc3JhbV9ub2RlID0gb2ZfcGFyc2VfcGhh bmRsZShub2RlLCBCQU5LX0xJU1RfUFJPUCwgICAgICAgICAgICAgIAo+ICAgICA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bV9iYW5rcyAtIDEpOyAKPiAK PiAgICAgRG8geW91IGhhdmUgdG8gc3RhcnQgd2l0aCB0aGUgbGFzdCBiYW5rPyAgSWYgbWVtb3J5 IHNlcnZlcyBtZSB3ZWxsIGl0IGlzbid0IHRoZQo+ICAgICBjYXNlIGluIHRoZSBwcmV2aW91cyBy ZXZpc2lvbnMuICBXaHkgbm90IGdvIGJhY2sgdG8gdGhlIGltcGxlbWVudGF0aW9uIHlvdSBoYWQK PiAgICAgaW4gVjI1PyAgCj4gCj4gTWFrZXMgc2Vuc2UuIFdpbGwgcmV2ZXJ0IGFzIHN1Z2dlc3Rl ZC4KCkZvciB5b3VyIG5leHQgcmV2aXNpb24sIGdvIGJhY2sgdG8gVjI1IGFuZCBmaXggb25seSB3 aGF0IEkgY29tbWVudGVkIG9uLiAgSQpjYW4ndCByZW1lbWJlciBidXQgeW91IG1heSBhbHNvIGhh dmUgdG8gZml4IHRoZSBwdXRfZGV2aWNlKCkgcHJvYmxlbSB3ZSd2ZSBiZWVuCmRpc2N1c3Npbmcu IAoKPiAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK