From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D12226E89A for ; Thu, 18 Mar 2021 07:32:18 +0000 (UTC) Date: Thu, 18 Mar 2021 08:32:03 +0100 From: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Message-ID: <20210318073203.GA4672@zkempczy-mobl2> References: <20210317144610.108372-1-zbigniew.kempczynski@intel.com> <20210317144610.108372-14-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t v26 13/35] lib/intel_bufops: Add init with handle and size function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: IGT GPU Tools List-ID: T24gV2VkLCBNYXIgMTcsIDIwMjEgYXQgMDQ6MzY6NTRQTSAtMDUwMCwgSmFzb24gRWtzdHJhbmQg d3JvdGU6Cj4gT24gV2VkLCBNYXIgMTcsIDIwMjEgYXQgOTo0NiBBTSBaYmlnbmlldyBLZW1wY3p5 xYRza2kKPiA8emJpZ25pZXcua2VtcGN6eW5za2lAaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPiBG b3Igc29tZSBjYXNlcyAoZmIgd2l0aCBjb21wcmVzc2lvbikgZmIgc2l6ZSBpcyBiaWdnZXIgdGhh biBjYWxjdWxhdGVkCj4gPiBpbnRlbF9idWYgd2hhdCBsZWFkIHRvIGV4ZWNidWYgZmFpbHVyZSB3 aGVuIGFsbG9jYXRvciBpcyB1c2VkCj4gPiBhbG9uZyB3aXRoIEVYRUNfT0JKRUNUX1BJTk5FRCBm bGFnIHNldCBmb3IgYWxsIG9iamVjdHMuCj4gPgo+ID4gV2UgbmVlZCB0byBjcmVhdGUgaW50ZWxf YnVmIHdpdGggc2l6ZSBlcXVhbCB0byBmYiBzbyBuZXcgZnVuY3Rpb24KPiA+IGluIHdoaWNoIHdl IHBhc3MgaGFuZGxlIGFuZCBzaXplIGlzIHJlcXVpcmVkLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6 IFpiaWduaWV3IEtlbXBjennFhHNraSA8emJpZ25pZXcua2VtcGN6eW5za2lAaW50ZWwuY29tPgo+ ID4gQ2M6IERvbWluaWsgR3J6ZWdvcnplayA8ZG9taW5pay5ncnplZ29yemVrQGludGVsLmNvbT4K PiA+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IFJldmll d2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IC0tLQo+ ID4gIGxpYi9pbnRlbF9idWZvcHMuYyB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLQo+ID4gIGxpYi9pbnRlbF9idWZvcHMuaCB8ICA3ICsrKysrKysKPiA+ICAyIGZpbGVzIGNo YW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdp dCBhL2xpYi9pbnRlbF9idWZvcHMuYyBiL2xpYi9pbnRlbF9idWZvcHMuYwo+ID4gaW5kZXggZWI1 YWM0ZGFkLi5kOGViNjRlM2EgMTAwNjQ0Cj4gPiAtLS0gYS9saWIvaW50ZWxfYnVmb3BzLmMKPiA+ ICsrKyBiL2xpYi9pbnRlbF9idWZvcHMuYwo+ID4gQEAgLTcwOCw3ICs3MDgsOCBAQCBzdGF0aWMg dm9pZCBfX2ludGVsX2J1Zl9pbml0KHN0cnVjdCBidWZfb3BzICpib3BzLAo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBoYW5kbGUsCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9idWYgKmJ1ZiwKPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCBpbnQgYnBwLCBpbnQgYWxpZ25tZW50 LAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCByZXFfdGlsaW5nLCB1 aW50MzJfdCBjb21wcmVzc2lvbikKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu dDMyX3QgcmVxX3RpbGluZywgdWludDMyX3QgY29tcHJlc3Npb24sCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVpbnQ2NF90IGJvX3NpemUpCj4gPiAgewo+ID4gICAgICAgICB1aW50 MzJfdCB0aWxpbmcgPSByZXFfdGlsaW5nOwo+ID4gICAgICAgICB1aW50NjRfdCBzaXplOwo+ID4g QEAgLTc1OCw3ICs3NTksNyBAQCBzdGF0aWMgdm9pZCBfX2ludGVsX2J1Zl9pbml0KHN0cnVjdCBi dWZfb3BzICpib3BzLAo+ID4gICAgICAgICAgICAgICAgIGJ1Zi0+Y2NzWzBdLm9mZnNldCA9IGJ1 Zi0+c3VyZmFjZVswXS5zdHJpZGUgKiBBTElHTihoZWlnaHQsIDMyKTsKPiA+ICAgICAgICAgICAg ICAgICBidWYtPmNjc1swXS5zdHJpZGUgPSBhdXhfd2lkdGg7Cj4gPgo+ID4gLSAgICAgICAgICAg ICAgIHNpemUgPSBidWYtPmNjc1swXS5vZmZzZXQgKyBhdXhfd2lkdGggKiBhdXhfaGVpZ2h0Owo+ ID4gKyAgICAgICAgICAgICAgIHNpemUgPSBtYXgoYm9fc2l6ZSwgYnVmLT5jY3NbMF0ub2Zmc2V0 ICsgYXV4X3dpZHRoICogYXV4X2hlaWdodCk7Cj4gPiAgICAgICAgIH0gZWxzZSB7Cj4gPiAgICAg ICAgICAgICAgICAgaWYgKHRpbGluZykgewo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgZGV2 aWQgPSAgaW50ZWxfZ2V0X2RybV9kZXZpZChib3BzLT5mZCk7Cj4gPiBAQCAtNzczLDcgKzc3NCw3 IEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfYnVmX2luaXQoc3RydWN0IGJ1Zl9vcHMgKmJvcHMsCj4g PiAgICAgICAgICAgICAgICAgYnVmLT50aWxpbmcgPSB0aWxpbmc7Cj4gPiAgICAgICAgICAgICAg ICAgYnVmLT5icHAgPSBicHA7Cj4gPgo+ID4gLSAgICAgICAgICAgICAgIHNpemUgPSBidWYtPnN1 cmZhY2VbMF0uc3RyaWRlICogQUxJR04oaGVpZ2h0LCBhbGlnbl9oKTsKPiA+ICsgICAgICAgICAg ICAgICBzaXplID0gbWF4KGJvX3NpemUsIGJ1Zi0+c3VyZmFjZVswXS5zdHJpZGUgKiBBTElHTiho ZWlnaHQsIGFsaWduX2gpKTsKPiAKPiBEbyB3ZSB3YW50IHRvIHRha2UgYSBtYXgoKSBoZXJlIG9y IGRvIHNvbWV0aGluZyBsaWtlIHRoaXMgYWZ0ZXJ3YXJkczoKPiAKPiBpZiAoYm9fc2l6ZSA+IDAp IHsKPiAgICAgaWd0X2Fzc2VydChib19zaXplID49IHNpemUpOwo+ICAgICBidWYtPnNpemUgPSBi b19zaXplOwo+IH0gZWxzZSB7Cj4gICAgIGJ1Zi0+c2l6ZSA9IHNpemU7Cj4gfQoKQWdyZWUsIGlm IGNhbGxlciByZWFsbHkgd2FudCB0byBwYXNzIGJvX3NpemUgd2UgZXhwZWN0IGhlIHdpbGwgYXQg bGVhc3QKcHJvdmlkZSB2YWxpZCBzaXplIChhY2NvcmRpbmcgdG8gdy9oL2JwcCkuCgpUaGlzIGlz IGNvc21ldGljIGNoYW5nZSB3aGljaCBwcm92aWRlcyBiZXR0ZXIgaW5wdXQgZGF0YSBwcm90ZWN0 aW9uCnNvIEkgZGFyZSB0byBrZWVwIENocmlzIHItYiBoZXJlLiBJZiB5b3Ugd291bGQgY29tcGxh aW4gSSdsbCByZW1vdmUKdGhpcyBpbiBuZXh0IHNlcmllcy4KCi0tClpiaWduaWV3CgoKPiAKPiA+ ICAgICAgICAgfQo+ID4KPiA+ICAgICAgICAgLyogU3RvcmUgcmVhbCBibyBzaXplIHRvIGF2b2lk IG1pc3Rha2VzIGluIGNhbGN1bGF0aW5nIGl0IGFnYWluICovCj4gPiBAQCAtODA5LDcgKzgxMCw3 IEBAIHZvaWQgaW50ZWxfYnVmX2luaXQoc3RydWN0IGJ1Zl9vcHMgKmJvcHMsCj4gPiAgICAgICAg ICAgICAgICAgICAgIHVpbnQzMl90IHRpbGluZywgdWludDMyX3QgY29tcHJlc3Npb24pCj4gPiAg ewo+ID4gICAgICAgICBfX2ludGVsX2J1Zl9pbml0KGJvcHMsIDAsIGJ1Ziwgd2lkdGgsIGhlaWdo dCwgYnBwLCBhbGlnbm1lbnQsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgdGlsaW5nLCBj b21wcmVzc2lvbik7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgdGlsaW5nLCBjb21wcmVz c2lvbiwgMCk7Cj4gPgo+ID4gICAgICAgICBpbnRlbF9idWZfc2V0X293bmVyc2hpcChidWYsIHRy dWUpOwo+ID4gIH0KPiA+IEBAIC04NTgsNyArODU5LDcgQEAgdm9pZCBpbnRlbF9idWZfaW5pdF91 c2luZ19oYW5kbGUoc3RydWN0IGJ1Zl9vcHMgKmJvcHMsCj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1aW50MzJfdCByZXFfdGlsaW5nLCB1aW50MzJfdCBjb21wcmVzc2lvbikK PiA+ICB7Cj4gPiAgICAgICAgIF9faW50ZWxfYnVmX2luaXQoYm9wcywgaGFuZGxlLCBidWYsIHdp ZHRoLCBoZWlnaHQsIGJwcCwgYWxpZ25tZW50LAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg IHJlcV90aWxpbmcsIGNvbXByZXNzaW9uKTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICBy ZXFfdGlsaW5nLCBjb21wcmVzc2lvbiwgMCk7Cj4gPiAgfQo+ID4KPiA+ICAvKioKPiA+IEBAIC05 MjcsNiArOTI4LDI4IEBAIHN0cnVjdCBpbnRlbF9idWYgKmludGVsX2J1Zl9jcmVhdGVfdXNpbmdf aGFuZGxlKHN0cnVjdCBidWZfb3BzICpib3BzLAo+ID4gICAgICAgICByZXR1cm4gYnVmOwo+ID4g IH0KPiA+Cj4gPiArc3RydWN0IGludGVsX2J1ZiAqaW50ZWxfYnVmX2NyZWF0ZV91c2luZ19oYW5k bGVfYW5kX3NpemUoc3RydWN0IGJ1Zl9vcHMgKmJvcHMsCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBoYW5kbGUsCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBpbnQgd2lkdGgsIGludCBoZWlnaHQsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgYnBwLCBpbnQgYWxpZ25tZW50LAo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dWludDMyX3QgcmVxX3RpbGluZywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IGNvbXByZXNzaW9uLAo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0 X3Qgc2l6ZSkKPiA+ICt7Cj4gPiArICAgICAgIHN0cnVjdCBpbnRlbF9idWYgKmJ1ZjsKPiA+ICsK PiA+ICsgICAgICAgaWd0X2Fzc2VydChib3BzKTsKPiA+ICsKPiA+ICsgICAgICAgYnVmID0gY2Fs bG9jKDEsIHNpemVvZigqYnVmKSk7Cj4gPiArICAgICAgIGlndF9hc3NlcnQoYnVmKTsKPiA+ICsK PiA+ICsgICAgICAgX19pbnRlbF9idWZfaW5pdChib3BzLCBoYW5kbGUsIGJ1Ziwgd2lkdGgsIGhl aWdodCwgYnBwLCBhbGlnbm1lbnQsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgcmVxX3Rp bGluZywgY29tcHJlc3Npb24sIHNpemUpOwo+ID4gKwo+ID4gKyAgICAgICByZXR1cm4gYnVmOwo+ ID4gK30KPiA+ICsKPiA+ICsKPiA+ICAvKioKPiA+ICAgKiBpbnRlbF9idWZfZGVzdHJveQo+ID4g ICAqIEBidWY6IGludGVsX2J1Zgo+ID4gZGlmZiAtLWdpdCBhL2xpYi9pbnRlbF9idWZvcHMuaCBi L2xpYi9pbnRlbF9idWZvcHMuaAo+ID4gaW5kZXggNTYxOWZjNmZhLi41NDQ4MGJmZjYgMTAwNjQ0 Cj4gPiAtLS0gYS9saWIvaW50ZWxfYnVmb3BzLmgKPiA+ICsrKyBiL2xpYi9pbnRlbF9idWZvcHMu aAo+ID4gQEAgLTEzOSw2ICsxMzksMTMgQEAgc3RydWN0IGludGVsX2J1ZiAqaW50ZWxfYnVmX2Ny ZWF0ZV91c2luZ19oYW5kbGUoc3RydWN0IGJ1Zl9vcHMgKmJvcHMsCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCByZXFfdGlsaW5nLAo+ ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDMy X3QgY29tcHJlc3Npb24pOwo+ID4KPiA+ICtzdHJ1Y3QgaW50ZWxfYnVmICppbnRlbF9idWZfY3Jl YXRlX3VzaW5nX2hhbmRsZV9hbmRfc2l6ZShzdHJ1Y3QgYnVmX29wcyAqYm9wcywKPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQz Ml90IGhhbmRsZSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGludCB3aWR0aCwgaW50IGhlaWdodCwKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBicHAsIGludCBh bGlnbm1lbnQsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1aW50MzJfdCByZXFfdGlsaW5nLAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDMyX3QgY29tcHJlc3Np b24sCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1aW50NjRfdCBzaXplKTsKPiA+ICB2b2lkIGludGVsX2J1Zl9kZXN0cm95KHN0cnVj dCBpbnRlbF9idWYgKmJ1Zik7Cj4gPgo+ID4gIHZvaWQgKmludGVsX2J1Zl9jcHVfbWFwKHN0cnVj dCBpbnRlbF9idWYgKmJ1ZiwgYm9vbCB3cml0ZSk7Cj4gPiAtLQo+ID4gMi4yNi4wCj4gPgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxp bmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK