From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633FEC433DB for ; Thu, 18 Mar 2021 12:13:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A62D664E89 for ; Thu, 18 Mar 2021 12:13:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A62D664E89 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMrWU-0006um-LV for qemu-devel@archiver.kernel.org; Thu, 18 Mar 2021 08:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMrSJ-0005F1-Iz for qemu-devel@nongnu.org; Thu, 18 Mar 2021 08:08:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMrSH-0007Om-Ue for qemu-devel@nongnu.org; Thu, 18 Mar 2021 08:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616069324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4214Yr/DmC+fCnmkiUm0ELIn48y2d547AFPHU1RrC4=; b=PwboBwiGZMKmJN0aa0xzkooeqf0s9xEvfA0Jdz8Ae3V6u8+aBil+QLydk0Ku99fryppx+0 y2Y/4tNXdWLVvpd1EGXrjMfadQ57MrOeTZdSqr4Q+hezAc318Gc3v/zeTvaOYGpcG+0JpV uWW7t2I+N8BtLVrVFgDuKAQ1lfGhBbM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-PnlJr6IcOHmF6czKJ35iHw-1; Thu, 18 Mar 2021 08:08:43 -0400 X-MC-Unique: PnlJr6IcOHmF6czKJ35iHw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA6FB107ACCD; Thu, 18 Mar 2021 12:08:41 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.196.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3BBE19718; Thu, 18 Mar 2021 12:08:39 +0000 (UTC) Date: Thu, 18 Mar 2021 13:08:37 +0100 From: Andrew Jones To: Claudio Fontana Subject: Re: arm_cpu_post_init (Was: Re: arm: "max" CPU class hierarchy changes possible?) Message-ID: <20210318120837.cg4gfdpchjwiabav@kamzik.brq.redhat.com> References: <11e9d3bb-c94c-4ad7-35b0-b698376c5e00@suse.de> <2e6a5d98-e022-0b39-5f30-92eb74491d3b@redhat.com> <2277fdf5-ec92-476a-8fe5-0d4eee23dfef@suse.de> <20210311191046.ykcelkwq7orajyu7@kamzik.brq.redhat.com> <5467e45c-cc8e-6422-0c56-398405a7c331@suse.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=drjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.249, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel , qemu-arm , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Mar 18, 2021 at 12:32:30PM +0100, Claudio Fontana wrote: > And why do we have a separate arm_cpu_finalize_features()? Separate, because it's not just called from arm_cpu_realizefn(). > > Nothing in the ARM cpu classes initializations ever seems to be "final" to me. Some CPU features cannot be simply switched on/off at the property parse time. For example, there could be dependencies on multiple properties, the mutual exclusion of properties, or other aspects that can only be known later than property parse time. That stuff goes in arm_cpu_finalize_features(). Thanks, drew