[PATCH] avb: Fix error when partition not found

[PATCH] avb: Fix error when partition not found

[schspa]

part_get_info_by_name will return -1 on error, and >0 on success.

Signed-off-by: schspa <schspa@gmail.com>
Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
---
 common/avb_verify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/avb_verify.c b/common/avb_verify.c
index db10d0f21f..0520a71455 100644
--- a/common/avb_verify.c
+++ b/common/avb_verify.c
@@ -369,7 +369,7 @@ static struct mmc_part *get_partition(AvbOps *ops, const char *partition)
 	}
 
 	ret = part_get_info_by_name(mmc_blk, partition, &part->info);
-	if (!ret) {
+	if (ret < 0) {
 		printf("Can't find partition '%s'\n", partition);
 		goto err;
 	}
-- 
2.24.3 (Apple Git-128)

[PATCH] avb: Fix error when partition not found

[Igor Opaniuk]

Hi schspa,

On Thu, Feb 25, 2021 at 6:25 PM schspa <schspa@gmail.com> wrote:
>
> part_get_info_by_name will return -1 on error, and >0 on success.
>
> Signed-off-by: schspa <schspa@gmail.com>
> Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
> ---
>  common/avb_verify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index db10d0f21f..0520a71455 100644
> --- a/common/avb_verify.c
> +++ b/common/avb_verify.c
> @@ -369,7 +369,7 @@ static struct mmc_part *get_partition(AvbOps *ops, const char *partition)
>         }
>
>         ret = part_get_info_by_name(mmc_blk, partition, &part->info);
> -       if (!ret) {
> +       if (ret < 0) {
>                 printf("Can't find partition '%s'\n", partition);
>                 goto err;
>         }
> --
> 2.24.3 (Apple Git-128)
>

Reviewed-by: Igor Opaniuk <igor.opaniuk@gmail.com>

-- 
Best regards - Freundliche Gr?sse - Meilleures salutations

Igor Opaniuk
Embedded Software Engineer
T:  +380 938364067
E: igor.opaniuk at foundries.io
W: www.foundries.io

[PATCH] avb: Fix error when partition not found

[Tom Rini]

On Fri, Feb 26, 2021 at 12:19:10AM +0800, schspa wrote:

> part_get_info_by_name will return -1 on error, and >0 on success.
> 
> Signed-off-by: schspa <schspa@gmail.com>
> Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
> Reviewed-by: Igor Opaniuk <igor.opaniuk@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210318/1ef229bc/attachment.sig>