All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Jaroslav Kysela <perex@perex.cz>,
	tiwai@suse.de, tanjeff@cccmz.de, alsa-devel@alsa-project.org
Subject: Re: [alsa-lib][PATCH 0/6] add API of equality and comparison for a pair of control element IDs
Date: Fri, 19 Mar 2021 01:56:34 +0900	[thread overview]
Message-ID: <20210318165634.GA277809@workstation> (raw)
In-Reply-To: <20210318163715.GA273829@workstation>

On Fri, Mar 19, 2021 at 01:37:15AM +0900, Takashi Sakamoto wrote:
> As I described, your old implementation is not acceptable just by renaming.
> Although the idea of inline definitions is itself preferable. I suspect whether
> inline definition for your comparison algorithm is really less overhead than
> function call.
> 
> Anyway I'll post revised version of patchset later.

Oops. These APIs have arguments with opaque pointers. In the case,
inline definition is not available since the layout of structure underlying
the pointer is not available for userspace applications. Thus the rest of
issue is whether to use 'tuple' or 'fields' in the name of new API.

In my opinion, 'fields' is generic expression and could give impression to
application developers that it includes numid field as well. On the other
hand, 'tuple' is weak expression somehow and the developers easily find
its meaning in alsa-lib documentation (see line 80). When considering about
helpfulness to developers, 'tuple' seems to be better than 'fields'.


Thanks

Takashi Sakamoto

  reply	other threads:[~2021-03-18 16:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 10:30 [alsa-lib][PATCH 0/6] add API of equality and comparison for a pair of control element IDs Takashi Sakamoto
2021-03-18 10:30 ` [alsa-lib][PATCH 1/6] test: ctl-elem-id: add test program for future APIs relevant to control element ID Takashi Sakamoto
2021-03-18 10:30 ` [alsa-lib][PATCH 2/6] ctl: add API to check equality between a pair of control element IDs by numid Takashi Sakamoto
2021-03-18 10:30 ` [alsa-lib][PATCH 3/6] ctl: add API to check equality between a pair of control element IDs by tuple Takashi Sakamoto
2021-03-18 10:30 ` [alsa-lib][PATCH 4/6] ctl: add API to compare a pair of control element IDs by numid Takashi Sakamoto
2021-03-18 10:30 ` [alsa-lib][PATCH 5/6] ctl: add API to compare a pair of control element IDs by one of algorithms according to tuple Takashi Sakamoto
2021-03-18 10:30 ` [alsa-lib][PATCH 6/6] ctl: drop deprecated API to compare a pair of control element IDs Takashi Sakamoto
2021-03-18 11:42 ` [alsa-lib][PATCH 0/6] add API of equality and comparison for " Jaroslav Kysela
2021-03-18 16:37   ` Takashi Sakamoto
2021-03-18 16:56     ` Takashi Sakamoto [this message]
2021-03-18 17:17       ` Jaroslav Kysela
2021-03-22  4:49         ` Takashi Sakamoto
2021-03-18 17:04     ` Jaroslav Kysela
2021-03-22  4:41       ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210318165634.GA277809@workstation \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=tanjeff@cccmz.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.