From: Stefano Garzarella <sgarzare@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio: Fix virtio_mmio_read()/virtio_mmio_write()
Date: Fri, 19 Mar 2021 10:24:16 +0100 [thread overview]
Message-ID: <20210319092416.i54rvwh7u24yrrgf@steredhat> (raw)
In-Reply-To: <20210314200300.3259170-1-laurent@vivier.eu>
On Sun, Mar 14, 2021 at 09:03:00PM +0100, Laurent Vivier wrote:
>Both functions don't check the personality of the interface (legacy or
>modern) before accessing the configuration memory and always use
>virtio_config_readX()/virtio_config_writeX().
>
>With this patch, they now check the personality and in legacy mode
>call virtio_config_readX()/virtio_config_writeX(), otherwise call
>virtio_config_modern_readX()/virtio_config_modern_writeX().
>
>This change has been tested with virtio-mmio guests (virt stretch/armhf and
>virt sid/m68k) and virtio-pci guests (pseries RHEL-7.3/ppc64 and /ppc64le).
>
>Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>---
> hw/virtio/virtio-mmio.c | 74 +++++++++++++++++++++++++++++------------
> 1 file changed, 52 insertions(+), 22 deletions(-)
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
prev parent reply other threads:[~2021-03-19 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 20:03 [PATCH] virtio: Fix virtio_mmio_read()/virtio_mmio_write() Laurent Vivier
2021-03-17 14:18 ` Laurent Vivier
2021-03-19 9:24 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319092416.i54rvwh7u24yrrgf@steredhat \
--to=sgarzare@redhat.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.