From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7872C433E0 for ; Sat, 20 Mar 2021 14:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 923586196B for ; Sat, 20 Mar 2021 14:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229922AbhCTOlj (ORCPT ); Sat, 20 Mar 2021 10:41:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:54518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbhCTOlU (ORCPT ); Sat, 20 Mar 2021 10:41:20 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D65D861967; Sat, 20 Mar 2021 14:41:17 +0000 (UTC) Date: Sat, 20 Mar 2021 14:41:15 +0000 From: Jonathan Cameron To: Mugilraj Dhavachelvan Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: ad9832: kernel-doc fixes Message-ID: <20210320144115.20137afe@jic23-huawei> In-Reply-To: <20210315133711.26860-1-dmugil2000@gmail.com> References: <20210315133711.26860-1-dmugil2000@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Mar 2021 19:07:11 +0530 Mugilraj Dhavachelvan wrote: > Fixes a W=1 warning. > -Added ``:`` to lock parameter in 'ad9832_state' description. > -It's a reference comment so removed /** > > Signed-off-by: Mugilraj Dhavachelvan Great. Thanks for tidying this up. Applied to the togreg branch of iio.git and pushed out for testing to let the autobuilders poke at it. thanks Jonathan > --- > drivers/staging/iio/frequency/ad9832.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > index 74308a2e72db..e31ebba47a3c 100644 > --- a/drivers/staging/iio/frequency/ad9832.c > +++ b/drivers/staging/iio/frequency/ad9832.c > @@ -86,7 +86,7 @@ > * @freq_msg: tuning word spi message > * @phase_xfer: tuning word spi transfer > * @phase_msg: tuning word spi message > - * @lock protect sensor state > + * @lock: protect sensor state > * @data: spi transmit buffer > * @phase_data: tuning word spi transmit buffer > * @freq_data: tuning word spi transmit buffer > @@ -248,7 +248,7 @@ static ssize_t ad9832_write(struct device *dev, struct device_attribute *attr, > return ret ? ret : len; > } > > -/** > +/* > * see dds.h for further information > */ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78FBC433DB for ; Sat, 20 Mar 2021 14:41:25 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 498536196C for ; Sat, 20 Mar 2021 14:41:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 498536196C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0CE0483A99; Sat, 20 Mar 2021 14:41:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a8HwJoVsvAkO; Sat, 20 Mar 2021 14:41:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 164D083AA7; Sat, 20 Mar 2021 14:41:24 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1966C1BF313 for ; Sat, 20 Mar 2021 14:41:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 03D9983AA7 for ; Sat, 20 Mar 2021 14:41:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XDkQj7N0DyMd for ; Sat, 20 Mar 2021 14:41:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7C0B183A99 for ; Sat, 20 Mar 2021 14:41:22 +0000 (UTC) Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D65D861967; Sat, 20 Mar 2021 14:41:17 +0000 (UTC) Date: Sat, 20 Mar 2021 14:41:15 +0000 From: Jonathan Cameron To: Mugilraj Dhavachelvan Subject: Re: [PATCH] staging: iio: ad9832: kernel-doc fixes Message-ID: <20210320144115.20137afe@jic23-huawei> In-Reply-To: <20210315133711.26860-1-dmugil2000@gmail.com> References: <20210315133711.26860-1-dmugil2000@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Peter Meerwald-Stadler , Hartmut Knaack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, 15 Mar 2021 19:07:11 +0530 Mugilraj Dhavachelvan wrote: > Fixes a W=1 warning. > -Added ``:`` to lock parameter in 'ad9832_state' description. > -It's a reference comment so removed /** > > Signed-off-by: Mugilraj Dhavachelvan Great. Thanks for tidying this up. Applied to the togreg branch of iio.git and pushed out for testing to let the autobuilders poke at it. thanks Jonathan > --- > drivers/staging/iio/frequency/ad9832.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > index 74308a2e72db..e31ebba47a3c 100644 > --- a/drivers/staging/iio/frequency/ad9832.c > +++ b/drivers/staging/iio/frequency/ad9832.c > @@ -86,7 +86,7 @@ > * @freq_msg: tuning word spi message > * @phase_xfer: tuning word spi transfer > * @phase_msg: tuning word spi message > - * @lock protect sensor state > + * @lock: protect sensor state > * @data: spi transmit buffer > * @phase_data: tuning word spi transmit buffer > * @freq_data: tuning word spi transmit buffer > @@ -248,7 +248,7 @@ static ssize_t ad9832_write(struct device *dev, struct device_attribute *attr, > return ret ? ret : len; > } > > -/** > +/* > * see dds.h for further information > */ > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel