From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F557C433E1 for ; Mon, 22 Mar 2021 10:47:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69C7C6198E for ; Mon, 22 Mar 2021 10:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbhCVKqo (ORCPT ); Mon, 22 Mar 2021 06:46:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbhCVKqL (ORCPT ); Mon, 22 Mar 2021 06:46:11 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9E19C061762 for ; Mon, 22 Mar 2021 03:46:10 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id o10so20470750lfb.9 for ; Mon, 22 Mar 2021 03:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YVhaX9TyJpOCjZ6lAAx4X7Evu71S5QgfpSg+uRC3XiQ=; b=M6jX3QVPO2UvJpsu3y0kv19VW5H79eVHUQvu9oD8AlEmyUmNNKBqbG0M9SlNIvKW1A j4HrUVwhPDK8XJkQb2YtadImTHZFIu+ZiV2CiY4VqPwXdbkbI/JEcbsz/1ysRzNkUGqm YCnNWVY5+wV8jyvDHq1hQJj647gMtGG8cTL9qnbbrc4R2mfABoXP185LrniGGhgOBl/e qE8Y2JCCUVVLVun6uiSqkngNMyVNRC9Zg/lBqOFWSItWSDvOVD/M0CWxh0J28yYm/R9J xKgmf9d5Z4dye+vyvIqCw6pxvy7dzPyFYk/ksskR9lwXAIK9kT/ZafHhgk+INpAYlx2n j88g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YVhaX9TyJpOCjZ6lAAx4X7Evu71S5QgfpSg+uRC3XiQ=; b=sOvGTtzH6VPTgtTpD2Fg5YI4JtIa58G/AmPUx45N4EMbkh7WHsPaHWL6Wyw0JmH/GJ XJvj2P2309zOGVLjRcjPed731m2w/fOvb5VMHbHCX2EFIyZ7UlycZIaH51xpcgk2n7kU AKF7ie33WU8/Yuk1LUWaIVN2iEjJP0lhYN4s14bhN/n1uXM4+xVPc3lNKrZUUpxp/+01 PEH7lVffgrIk4oDNh52TX2MOWtydaUSxbRFbGXQVeE5vh3b5A9heWmWrHGS3dJdvaYEI OGqYvfMxwn5HeAmJ3eRoo1uTBlsHLLBeb3RMPa8a6sJDzHCZyy5zZcQpyZ7XT7OesUR4 KMyA== X-Gm-Message-State: AOAM530Yrzce2O5zkudGBOxv0ostWTXIGu8p0GVnOHDir7Z2wxxbGuIx 3TkkVYWKGryj/scseQMHDxPrqQ== X-Google-Smtp-Source: ABdhPJzLM+bmJsvaTQY9QrPsDTclu+7bOjKDoiq6hBThy6PKFfc4RTvbqhPQkPHx8PacTz+LlaoISw== X-Received: by 2002:a05:6512:219:: with SMTP id a25mr6170751lfo.222.1616409969171; Mon, 22 Mar 2021 03:46:09 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v80sm1531541lfa.229.2021.03.22.03.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 03:46:08 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 32D84101DEB; Mon, 22 Mar 2021 13:46:16 +0300 (+03) Date: Mon, 22 Mar 2021 13:46:16 +0300 From: "Kirill A. Shutemov" To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v23 15/28] x86/mm: Update maybe_mkwrite() for shadow stack Message-ID: <20210322104616.tht6flrxif257fdb@box> References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-16-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316151054.5405-16-yu-cheng.yu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 08:10:41AM -0700, Yu-cheng Yu wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a6c18c5752d6..af805ffde48e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -997,6 +997,8 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) > { > if (likely(vma->vm_flags & VM_WRITE)) > pte = pte_mkwrite(pte); > + else > + pte = arch_maybe_mkwrite(pte, vma); > return pte; > } I think it would be cleaner to allow arch code to override maybe_mkwrite() and maybe_pmd_mkwrite() altogether. Wrap it into #ifndef maybe_mkwrite here and provide VM_SHSTK-aware version from . -- Kirill A. Shutemov