All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v28 26/36] tests/api_intel_bb: Check switching vm in intel-bb
Date: Mon, 22 Mar 2021 13:37:40 +0100	[thread overview]
Message-ID: <20210322123750.94772-27-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20210322123750.94772-1-zbigniew.kempczynski@intel.com>

For more vm-controlled scenarios we have to support changing vm
in the intel-bb. Test verifies allocator is able to provide
two vm's which can be assigned to used within intel-bb context.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 tests/i915/api_intel_bb.c | 105 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)

diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c
index 706dc8eb1..9ce3b0c1a 100644
--- a/tests/i915/api_intel_bb.c
+++ b/tests/i915/api_intel_bb.c
@@ -36,6 +36,7 @@
 #include <glib.h>
 #include <zlib.h>
 #include "intel_bufops.h"
+#include "i915/gem_vm.h"
 
 #define PAGE_SIZE 4096
 
@@ -239,6 +240,107 @@ static void bb_with_allocator(struct buf_ops *bops)
 	intel_bb_destroy(ibb);
 }
 
+static void bb_with_vm(struct buf_ops *bops)
+{
+	int i915 = buf_ops_get_fd(bops);
+	struct drm_i915_gem_context_param arg = {
+		.param = I915_CONTEXT_PARAM_VM,
+	};
+	struct intel_bb *ibb;
+	struct intel_buf *src, *dst, *gap;
+	uint32_t ctx = 0, vm_id1, vm_id2;
+	uint64_t prev_vm, vm;
+	uint64_t src_addr[5], dst_addr[5];
+
+	igt_require(gem_uses_full_ppgtt(i915));
+
+	ibb = intel_bb_create_with_allocator(i915, ctx, PAGE_SIZE,
+					     INTEL_ALLOCATOR_SIMPLE);
+	if (debug_bb)
+		intel_bb_set_debug(ibb, true);
+
+	src = intel_buf_create(bops, 4096/32, 32, 8, 0, I915_TILING_NONE,
+			       I915_COMPRESSION_NONE);
+	dst = intel_buf_create(bops, 4096/32, 32, 8, 0, I915_TILING_NONE,
+			       I915_COMPRESSION_NONE);
+	gap = intel_buf_create(bops, 4096, 128, 8, 0, I915_TILING_NONE,
+			       I915_COMPRESSION_NONE);
+
+	/* vm for second blit */
+	vm_id1 = gem_vm_create(i915);
+
+	/* Get vm_id for default vm */
+	arg.ctx_id = ctx;
+	gem_context_get_param(i915, &arg);
+	vm_id2 = arg.value;
+
+	igt_debug("Vm_id1: %u\n", vm_id1);
+	igt_debug("Vm_id2: %u\n", vm_id2);
+
+	/* First blit without set calling setparam */
+	intel_bb_copy_intel_buf(ibb, dst, src, 4096);
+	src_addr[0] = src->addr.offset;
+	dst_addr[0] = dst->addr.offset;
+	igt_debug("step1: src: 0x%llx, dst: 0x%llx\n",
+		  (long long) src_addr[0], (long long) dst_addr[0]);
+
+	/* Open new allocator with vm_id */
+	vm = intel_allocator_open_vm(i915, vm_id1, INTEL_ALLOCATOR_SIMPLE);
+	prev_vm = intel_bb_assign_vm(ibb, vm, vm_id1);
+
+	intel_bb_add_intel_buf(ibb, gap, false);
+	intel_bb_copy_intel_buf(ibb, dst, src, 4096);
+	src_addr[1] = src->addr.offset;
+	dst_addr[1] = dst->addr.offset;
+	igt_debug("step2: src: 0x%llx, dst: 0x%llx\n",
+		  (long long) src_addr[1], (long long) dst_addr[1]);
+
+	/* Back with default vm */
+	intel_bb_assign_vm(ibb, prev_vm, vm_id2);
+	intel_bb_add_intel_buf(ibb, gap, false);
+	intel_bb_copy_intel_buf(ibb, dst, src, 4096);
+	src_addr[2] = src->addr.offset;
+	dst_addr[2] = dst->addr.offset;
+	igt_debug("step3: src: 0x%llx, dst: 0x%llx\n",
+		  (long long) src_addr[2], (long long) dst_addr[2]);
+
+	/* And exchange one more time */
+	intel_bb_assign_vm(ibb, vm, vm_id1);
+	intel_bb_copy_intel_buf(ibb, dst, src, 4096);
+	src_addr[3] = src->addr.offset;
+	dst_addr[3] = dst->addr.offset;
+	igt_debug("step4: src: 0x%llx, dst: 0x%llx\n",
+		  (long long) src_addr[3], (long long) dst_addr[3]);
+
+	/* Back with default vm */
+	gem_vm_destroy(i915, vm_id1);
+	gem_vm_destroy(i915, vm_id2);
+	intel_bb_assign_vm(ibb, prev_vm, 0);
+
+	/* We can close it after assign previous vm to ibb */
+	intel_allocator_close(vm);
+
+	/* Try default vm still works */
+	intel_bb_copy_intel_buf(ibb, dst, src, 4096);
+	src_addr[4] = src->addr.offset;
+	dst_addr[4] = dst->addr.offset;
+	igt_debug("step5: src: 0x%llx, dst: 0x%llx\n",
+		  (long long) src_addr[4], (long long) dst_addr[4]);
+
+	/* Addresses should match for vm and prev_vm blits */
+	igt_assert_eq(src_addr[0], src_addr[2]);
+	igt_assert_eq(dst_addr[0], dst_addr[2]);
+	igt_assert_eq(src_addr[1], src_addr[3]);
+	igt_assert_eq(dst_addr[1], dst_addr[3]);
+	igt_assert_eq(src_addr[2], src_addr[4]);
+	igt_assert_eq(dst_addr[2], dst_addr[4]);
+
+	intel_buf_destroy(src);
+	intel_buf_destroy(dst);
+	intel_buf_destroy(gap);
+	intel_bb_destroy(ibb);
+}
+
 /*
  * Make sure we lead to realloc in the intel_bb.
  */
@@ -1455,6 +1557,9 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL)
 	igt_subtest("bb-with-allocator")
 		bb_with_allocator(bops);
 
+	igt_subtest("bb-with-vm")
+		bb_with_vm(bops);
+
 	igt_subtest("lot-of-buffers")
 		lot_of_buffers(bops);
 
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-03-22 12:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 12:37 [igt-dev] [PATCH i-g-t v28 00/36] Introduce IGT allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 01/36] lib/igt_list: Add igt_list_del_init() Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 02/36] lib/igt_list: igt_hlist implementation Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 03/36] lib/igt_map: Adopt Mesa hash table Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 04/36] lib/igt_core: Track child process pid and tid Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 05/36] lib/intel_allocator_simple: Add simple allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 06/36] lib/intel_allocator_reloc: Add reloc allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 07/36] lib/intel_allocator_random: Add random allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 08/36] lib/intel_allocator: Add intel_allocator core Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 09/36] lib/intel_allocator: Try to stop smoothly instead of deinit Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 10/36] lib/intel_allocator_msgchannel: Scale to 4k of parallel clients Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 11/36] lib/intel_allocator: Separate allocator multiprocess start Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 12/36] lib/intel_bufops: Change size from 32->64 bit Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 13/36] lib/intel_bufops: Add init with handle and size function Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 14/36] lib/intel_batchbuffer: Integrate intel_bb with allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 15/36] lib/intel_batchbuffer: Use relocations in intel-bb up to gen12 Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 16/36] lib/intel_batchbuffer: Create bb with strategy / vm ranges Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 17/36] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 18/36] lib/intel_batchbuffer: Don't collect relocations for newer gens Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 19/36] lib/igt_fb: Initialize intel_buf with same size as fb Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 20/36] tests/api_intel_bb: Remove check-canonical test Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 21/36] tests/api_intel_bb: Modify test to verify intel_bb with allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 22/36] tests/api_intel_bb: Add compressed->compressed copy Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 23/36] tests/api_intel_bb: Add purge-bb test Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 24/36] tests/api_intel_bb: Add simple intel-bb which uses allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 25/36] tests/api_intel_bb: Use allocator in delta-check test Zbigniew Kempczyński
2021-03-22 12:37 ` Zbigniew Kempczyński [this message]
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 27/36] tests/api_intel_allocator: Simple allocator test suite Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 28/36] tests/api_intel_allocator: Add execbuf with allocator example Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 29/36] tests/api_intel_allocator: Verify child can use its standalone allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 30/36] tests/gem_softpin: Verify allocator and execbuf pair work together Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 31/36] tests/gem|kms: Remove intel_bb from fixture Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 32/36] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 33/36] tests/gem_ppgtt: Adopt test to use intel_bb with allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 34/36] tests/gem_render_copy_redux: Adopt to use with intel_bb and allocator Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 35/36] tests/perf.c: Remove buffer from batch Zbigniew Kempczyński
2021-03-22 12:37 ` [igt-dev] [PATCH i-g-t v28 36/36] tests/gem_linear_blits: Use intel allocator Zbigniew Kempczyński
2021-03-22 13:28 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev31) Patchwork
2021-03-23 15:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-23 16:32   ` Zbigniew Kempczyński
2021-03-23 18:16   ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322123750.94772-27-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.