From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFB7C433C1 for ; Mon, 22 Mar 2021 13:11:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A8D86191C for ; Mon, 22 Mar 2021 13:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbhCVNLH (ORCPT ); Mon, 22 Mar 2021 09:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232696AbhCVM4n (ORCPT ); Mon, 22 Mar 2021 08:56:43 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A1BEC061765 for ; Mon, 22 Mar 2021 05:56:42 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id e7so19132764edu.10 for ; Mon, 22 Mar 2021 05:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jhMUMt47Qy3l4R1BzGhFrfV0S7KiLdr2F6jiJY4dFDk=; b=RgQ4iWT/PdFY/iZlFFqrrqi0NsFDqfJiPcx0MjPK+u4+kuaUEphxou0541X5gcuUMF B1ktR9sSf14DUUjdS0rW5w8wD+s/VdKafMEEQkRi7aQWYV5b5KfGZKTxQFTRDbe4o9Et ur3xdFTJjIxTzwcLMX32ZEz2BPQpN2lTEVU5C9FfagnQu9Kt63lX/o86KUyNJwwWmEVL 9bqHchQm4AdOxvd75FJJlUYz8uV18VlRatZEQpudO8zj/lY5caWi7L9K4mB4eOTosnB6 LfBOCquCbcDg8ikAMQEK37kKzWb5ncNrB45oh05JRRwL74UXV0fId213OdlAHLDmpyIm mZlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jhMUMt47Qy3l4R1BzGhFrfV0S7KiLdr2F6jiJY4dFDk=; b=JRVSn6eqwRE4DhMjbjvRGc3aOdNreYrsd3wMusTDpt/I4wHdQda6P/9NAXHGf4GkyA xwCQ1L3zRK88/0nO0J8qHcawFPTFGjfSASSXJjjfIZujF3HavIGuSsMV4Ee408uP7enj 2k/O2c4myj4HIcv3DlvlXTxN4lMHY+LodF56x4+dCLAaicsDJ9nqq/i+APiEsRB77adN EaMnw2btRbNpw10KT94dWRIg0mVnwKXKYbitEYXmJl5GxKABR3L+n8QFwNhZjwqw3m7U VtNOq5NPqkbbzZcXoSE4kw4OJlAkosUp8EuvfwvTU8VNbBruR+e0tXu0rdXckbZtq0tp mlWg== X-Gm-Message-State: AOAM5302+pF+D1xKg5ULju9Hc1xl/PP3X7VhNWMhi7VP092MqDSzlp+Y ruhlZsSr6R+8jBDznypqQexCQw== X-Google-Smtp-Source: ABdhPJySqR19DC/hCxF0a+sQiHHOwFj/hBIjXHAzej6vqyeDzzJ7iRwppliBGYzEkkTG1KvIeKN+xQ== X-Received: by 2002:aa7:cf17:: with SMTP id a23mr26254551edy.30.1616417800851; Mon, 22 Mar 2021 05:56:40 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id l18sm9686234ejk.86.2021.03.22.05.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 05:56:40 -0700 (PDT) Date: Mon, 22 Mar 2021 12:56:38 +0000 From: Lee Jones To: Fabrice Gasnier Cc: vilhelm.gray@gmail.com, alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com, olivier.moysan@foss.st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] mfd: stm32-timers: avoid clearing auto reload register Message-ID: <20210322125638.GP2916463@dell> References: <1614793895-10504-1-git-send-email-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Mar 2021, Fabrice Gasnier wrote: > On 3/3/21 6:51 PM, Fabrice Gasnier wrote: > > The ARR register is cleared unconditionally upon probing, after the maximum > > value has been read. This initial condition is rather not intuitive, when > > considering the counter child driver. It rather expects the maximum value > > by default: > > - The counter interface shows a zero value by default for 'ceiling' > > attribute. > > - Enabling the counter without any prior configuration makes it doesn't > > count. > > > > The reset value of ARR register is the maximum. So Choice here > > is to backup it, and restore it then, instead of clearing its value. > > It also fixes the initial condition seen by the counter driver. > > > > Fixes: d0f949e220fd ("mfd: Add STM32 Timers driver") > > > > Signed-off-by: Fabrice Gasnier > > --- > > drivers/mfd/stm32-timers.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > Hi, > > It's just a gentle reminder to review this patch. Looks like this was either dropped, or didn't make it into my queue. It's on the list now, I will deal with it soon. > > diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c > > index add6033..44ed2fc 100644 > > --- a/drivers/mfd/stm32-timers.c > > +++ b/drivers/mfd/stm32-timers.c > > @@ -158,13 +158,18 @@ static const struct regmap_config stm32_timers_regmap_cfg = { > > > > static void stm32_timers_get_arr_size(struct stm32_timers *ddata) > > { > > + u32 arr; > > + > > + /* Backup ARR to restore it after getting the maximum value */ > > + regmap_read(ddata->regmap, TIM_ARR, &arr); > > + > > /* > > * Only the available bits will be written so when readback > > * we get the maximum value of auto reload register > > */ > > regmap_write(ddata->regmap, TIM_ARR, ~0L); > > regmap_read(ddata->regmap, TIM_ARR, &ddata->max_arr); > > - regmap_write(ddata->regmap, TIM_ARR, 0x0); > > + regmap_write(ddata->regmap, TIM_ARR, arr); > > } > > > > static int stm32_timers_dma_probe(struct device *dev, > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D508C433DB for ; Mon, 22 Mar 2021 13:01:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11EB061930 for ; Mon, 22 Mar 2021 13:01:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11EB061930 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K6g2afslkMk39Pclmx63IBb2FK+HV9Vp/fv8Z0IXhLE=; b=mNLvkTYpWY1XcOQ+Jav8Vaggi zkDd8u7Aanf6yh/kMdFJvN3ME8PTdV4sXkcDScXII2MbvvE9v6exvRJmsyIKshBg2+nW92gcvdEAv ouAwaw8qh3Rm3oJubs+fh0L0RntPTzMRl+hHe61Lg4ey2LffnDv3TAac34c72BeSnCS0xBMUCOXX4 XFcmHncLGFU/x7VkX8BBEvIaSXho2iifvfrgldgiKig8VxuQQT6m4Vct3A0FqsGh+AIbNm8cIYzND 5vMdAa2k8cJRcApGHGuWG0RfI9EF6yLqyYkWVrBw72lL3AzrWHrnvYJXHLTPLeXjJehHuSWB9XnCp ImOdLov0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOK92-00BdUV-Ml; Mon, 22 Mar 2021 12:58:57 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOK6s-00BdLb-3i for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 12:58:43 +0000 Received: by mail-ed1-x536.google.com with SMTP id h10so19161913edt.13 for ; Mon, 22 Mar 2021 05:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jhMUMt47Qy3l4R1BzGhFrfV0S7KiLdr2F6jiJY4dFDk=; b=RgQ4iWT/PdFY/iZlFFqrrqi0NsFDqfJiPcx0MjPK+u4+kuaUEphxou0541X5gcuUMF B1ktR9sSf14DUUjdS0rW5w8wD+s/VdKafMEEQkRi7aQWYV5b5KfGZKTxQFTRDbe4o9Et ur3xdFTJjIxTzwcLMX32ZEz2BPQpN2lTEVU5C9FfagnQu9Kt63lX/o86KUyNJwwWmEVL 9bqHchQm4AdOxvd75FJJlUYz8uV18VlRatZEQpudO8zj/lY5caWi7L9K4mB4eOTosnB6 LfBOCquCbcDg8ikAMQEK37kKzWb5ncNrB45oh05JRRwL74UXV0fId213OdlAHLDmpyIm mZlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jhMUMt47Qy3l4R1BzGhFrfV0S7KiLdr2F6jiJY4dFDk=; b=JcjKGqU6koCx1QNQumWmx2VAKDrOThsoRVnE9Ob4Pxs5xyEj3sRzuglGrSxHo8Bgyn 2Hz2Rm0Ujx6oZcAL7CjRoMux/A17ZChXrhS5hxSSIbn9ZB4AK8eoPm5QvFiAKpOf2G4y gKixA4/B/sTWX4XepbrLqLL1qRyu4EMYJUe3XJVKPrUz1t8vC8ZB6oRFwsc6jxHJnJbL AReW6rFx9ikTC+i8VBop0tSrwTPYGgMDob3C6JQVlYLW7KLbbz0d0p8ANI9X9Zb67ngs CwA+pKFt+3r7Q5TYwYdxl2N/DM+fgLSCQDUYNQICBoxS8gjnPl8Iurj37lHU9rFZTS/d 7X+A== X-Gm-Message-State: AOAM530PCF9xcN/GkhJeVrJkYeLH1AcbvM7N277yZ6gbPh3JVRArZ11l cex4DBO2FRZIKV8nk5oZbwBZxb0j/57R8w== X-Google-Smtp-Source: ABdhPJySqR19DC/hCxF0a+sQiHHOwFj/hBIjXHAzej6vqyeDzzJ7iRwppliBGYzEkkTG1KvIeKN+xQ== X-Received: by 2002:aa7:cf17:: with SMTP id a23mr26254551edy.30.1616417800851; Mon, 22 Mar 2021 05:56:40 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id l18sm9686234ejk.86.2021.03.22.05.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 05:56:40 -0700 (PDT) Date: Mon, 22 Mar 2021 12:56:38 +0000 From: Lee Jones To: Fabrice Gasnier Cc: vilhelm.gray@gmail.com, alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com, olivier.moysan@foss.st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] mfd: stm32-timers: avoid clearing auto reload register Message-ID: <20210322125638.GP2916463@dell> References: <1614793895-10504-1-git-send-email-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_125842_299718_2BE121D2 X-CRM114-Status: GOOD ( 27.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMiBNYXIgMjAyMSwgRmFicmljZSBHYXNuaWVyIHdyb3RlOgoKPiBPbiAzLzMvMjEg Njo1MSBQTSwgRmFicmljZSBHYXNuaWVyIHdyb3RlOgo+ID4gVGhlIEFSUiByZWdpc3RlciBpcyBj bGVhcmVkIHVuY29uZGl0aW9uYWxseSB1cG9uIHByb2JpbmcsIGFmdGVyIHRoZSBtYXhpbXVtCj4g PiB2YWx1ZSBoYXMgYmVlbiByZWFkLiBUaGlzIGluaXRpYWwgY29uZGl0aW9uIGlzIHJhdGhlciBu b3QgaW50dWl0aXZlLCB3aGVuCj4gPiBjb25zaWRlcmluZyB0aGUgY291bnRlciBjaGlsZCBkcml2 ZXIuIEl0IHJhdGhlciBleHBlY3RzIHRoZSBtYXhpbXVtIHZhbHVlCj4gPiBieSBkZWZhdWx0Ogo+ ID4gLSBUaGUgY291bnRlciBpbnRlcmZhY2Ugc2hvd3MgYSB6ZXJvIHZhbHVlIGJ5IGRlZmF1bHQg Zm9yICdjZWlsaW5nJwo+ID4gICBhdHRyaWJ1dGUuCj4gPiAtIEVuYWJsaW5nIHRoZSBjb3VudGVy IHdpdGhvdXQgYW55IHByaW9yIGNvbmZpZ3VyYXRpb24gbWFrZXMgaXQgZG9lc24ndAo+ID4gICBj b3VudC4KPiA+IAo+ID4gVGhlIHJlc2V0IHZhbHVlIG9mIEFSUiByZWdpc3RlciBpcyB0aGUgbWF4 aW11bS4gU28gQ2hvaWNlIGhlcmUKPiA+IGlzIHRvIGJhY2t1cCBpdCwgYW5kIHJlc3RvcmUgaXQg dGhlbiwgaW5zdGVhZCBvZiBjbGVhcmluZyBpdHMgdmFsdWUuCj4gPiBJdCBhbHNvIGZpeGVzIHRo ZSBpbml0aWFsIGNvbmRpdGlvbiBzZWVuIGJ5IHRoZSBjb3VudGVyIGRyaXZlci4KPiA+IAo+ID4g Rml4ZXM6IGQwZjk0OWUyMjBmZCAoIm1mZDogQWRkIFNUTTMyIFRpbWVycyBkcml2ZXIiKQo+ID4g Cj4gPiBTaWduZWQtb2ZmLWJ5OiBGYWJyaWNlIEdhc25pZXIgPGZhYnJpY2UuZ2FzbmllckBmb3Nz LnN0LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvbWZkL3N0bTMyLXRpbWVycy5jIHwgNyArKysr KystCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ IAo+IEhpLAo+IAo+IEl0J3MganVzdCBhIGdlbnRsZSByZW1pbmRlciB0byByZXZpZXcgdGhpcyBw YXRjaC4KCkxvb2tzIGxpa2UgdGhpcyB3YXMgZWl0aGVyIGRyb3BwZWQsIG9yIGRpZG4ndCBtYWtl IGl0IGludG8gbXkgcXVldWUuCgpJdCdzIG9uIHRoZSBsaXN0IG5vdywgSSB3aWxsIGRlYWwgd2l0 aCBpdCBzb29uLgoKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9zdG0zMi10aW1lcnMuYyBi L2RyaXZlcnMvbWZkL3N0bTMyLXRpbWVycy5jCj4gPiBpbmRleCBhZGQ2MDMzLi40NGVkMmZjIDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tZmQvc3RtMzItdGltZXJzLmMKPiA+ICsrKyBiL2RyaXZl cnMvbWZkL3N0bTMyLXRpbWVycy5jCj4gPiBAQCAtMTU4LDEzICsxNTgsMTggQEAgc3RhdGljIGNv bnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIHN0bTMyX3RpbWVyc19yZWdtYXBfY2ZnID0gewo+ID4g IAo+ID4gIHN0YXRpYyB2b2lkIHN0bTMyX3RpbWVyc19nZXRfYXJyX3NpemUoc3RydWN0IHN0bTMy X3RpbWVycyAqZGRhdGEpCj4gPiAgewo+ID4gKwl1MzIgYXJyOwo+ID4gKwo+ID4gKwkvKiBCYWNr dXAgQVJSIHRvIHJlc3RvcmUgaXQgYWZ0ZXIgZ2V0dGluZyB0aGUgbWF4aW11bSB2YWx1ZSAqLwo+ ID4gKwlyZWdtYXBfcmVhZChkZGF0YS0+cmVnbWFwLCBUSU1fQVJSLCAmYXJyKTsKPiA+ICsKPiA+ ICAJLyoKPiA+ICAJICogT25seSB0aGUgYXZhaWxhYmxlIGJpdHMgd2lsbCBiZSB3cml0dGVuIHNv IHdoZW4gcmVhZGJhY2sKPiA+ICAJICogd2UgZ2V0IHRoZSBtYXhpbXVtIHZhbHVlIG9mIGF1dG8g cmVsb2FkIHJlZ2lzdGVyCj4gPiAgCSAqLwo+ID4gIAlyZWdtYXBfd3JpdGUoZGRhdGEtPnJlZ21h cCwgVElNX0FSUiwgfjBMKTsKPiA+ICAJcmVnbWFwX3JlYWQoZGRhdGEtPnJlZ21hcCwgVElNX0FS UiwgJmRkYXRhLT5tYXhfYXJyKTsKPiA+IC0JcmVnbWFwX3dyaXRlKGRkYXRhLT5yZWdtYXAsIFRJ TV9BUlIsIDB4MCk7Cj4gPiArCXJlZ21hcF93cml0ZShkZGF0YS0+cmVnbWFwLCBUSU1fQVJSLCBh cnIpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgaW50IHN0bTMyX3RpbWVyc19kbWFfcHJvYmUo c3RydWN0IGRldmljZSAqZGV2LAo+ID4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlv ciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBU d2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=