From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BF4C433E3 for ; Mon, 22 Mar 2021 16:42:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 763EE619B0 for ; Mon, 22 Mar 2021 16:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231962AbhCVQlz (ORCPT ); Mon, 22 Mar 2021 12:41:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:34736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231989AbhCVQlk (ORCPT ); Mon, 22 Mar 2021 12:41:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3D6461983; Mon, 22 Mar 2021 16:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616431299; bh=wTCQr9EWReJqtv/s8uqRSPBYWLbukkFUAZ7BJJhYHhI=; h=From:To:Cc:Subject:Date:From; b=FPrmYxwLnsZstci9axXyytZZzCy9y3Cevl1KqesKwOuenXzXvlVzxhadzwKXI54mr aSjFBZSVdDt22a6tXaI7+rJMgbES/VMyJGT6D0V0jpWtdKNJjJBI7i+FF1Cxm2JvSz Df/icB4sJaXsfPKndnUEX+SJzndY/e/Moin0GZrEgqjqDA1WPy4+f/S3jS/eSYmgQR cX1/5h5kq98Nru1lJO0vBoWrejwnli8I7gsqb9nlCSypsvDhhCyy5J4kLgSCWnWpTO 6APc7UdRuJKkdl0BJr4RE5gCy+vyln4Nw7PNsov+iQZrMrG1+gfPGHmvVsIRo0WQH4 09iB9yXFo/YoA== From: Arnd Bergmann To: Lee Jones , Daniel Thompson , Jingoo Han , Kristoffer Ericson , Richard Purdie Cc: Arnd Bergmann , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: journada720: fix Wmisleading-indentation warning Date: Mon, 22 Mar 2021 17:41:28 +0100 Message-Id: <20210322164134.827091-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann With gcc-11, we get a warning about code that looks correct but badly indented: drivers/video/backlight/jornada720_bl.c: In function ‘jornada_bl_update_status’: drivers/video/backlight/jornada720_bl.c:66:11: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation] 66 | } else /* turn on backlight */ | ^~~~ Change the formatting according to our normal conventions. Fixes: 13a7b5dc0d17 ("backlight: Adds HP Jornada 700 series backlight driver") Signed-off-by: Arnd Bergmann --- drivers/video/backlight/jornada720_bl.c | 44 ++++++++++++------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c index 996f7ba3b373..066d0dc98f60 100644 --- a/drivers/video/backlight/jornada720_bl.c +++ b/drivers/video/backlight/jornada720_bl.c @@ -66,30 +66,30 @@ static int jornada_bl_update_status(struct backlight_device *bd) } else /* turn on backlight */ PPSR |= PPC_LDD1; - /* send command to our mcu */ - if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) { - dev_info(&bd->dev, "failed to set brightness\n"); - ret = -ETIMEDOUT; - goto out; - } + /* send command to our mcu */ + if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) { + dev_info(&bd->dev, "failed to set brightness\n"); + ret = -ETIMEDOUT; + goto out; + } - /* - * at this point we expect that the mcu has accepted - * our command and is waiting for our new value - * please note that maximum brightness is 255, - * but due to physical layout it is equal to 0, so we simply - * invert the value (MAX VALUE - NEW VALUE). - */ - if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) - != TXDUMMY) { - dev_err(&bd->dev, "set brightness failed\n"); - ret = -ETIMEDOUT; - } + /* + * at this point we expect that the mcu has accepted + * our command and is waiting for our new value + * please note that maximum brightness is 255, + * but due to physical layout it is equal to 0, so we simply + * invert the value (MAX VALUE - NEW VALUE). + */ + if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) + != TXDUMMY) { + dev_err(&bd->dev, "set brightness failed\n"); + ret = -ETIMEDOUT; + } - /* - * If infact we get an TXDUMMY as output we are happy and dont - * make any further comments about it - */ + /* + * If infact we get an TXDUMMY as output we are happy and dont + * make any further comments about it + */ out: jornada_ssp_end(); -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF04CC433DB for ; Mon, 22 Mar 2021 16:41:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C4886198D for ; Mon, 22 Mar 2021 16:41:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C4886198D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D1F6E11C; Mon, 22 Mar 2021 16:41:40 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 090756E11C for ; Mon, 22 Mar 2021 16:41:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D3D6461983; Mon, 22 Mar 2021 16:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616431299; bh=wTCQr9EWReJqtv/s8uqRSPBYWLbukkFUAZ7BJJhYHhI=; h=From:To:Cc:Subject:Date:From; b=FPrmYxwLnsZstci9axXyytZZzCy9y3Cevl1KqesKwOuenXzXvlVzxhadzwKXI54mr aSjFBZSVdDt22a6tXaI7+rJMgbES/VMyJGT6D0V0jpWtdKNJjJBI7i+FF1Cxm2JvSz Df/icB4sJaXsfPKndnUEX+SJzndY/e/Moin0GZrEgqjqDA1WPy4+f/S3jS/eSYmgQR cX1/5h5kq98Nru1lJO0vBoWrejwnli8I7gsqb9nlCSypsvDhhCyy5J4kLgSCWnWpTO 6APc7UdRuJKkdl0BJr4RE5gCy+vyln4Nw7PNsov+iQZrMrG1+gfPGHmvVsIRo0WQH4 09iB9yXFo/YoA== From: Arnd Bergmann To: Lee Jones , Daniel Thompson , Jingoo Han , Kristoffer Ericson , Richard Purdie Subject: [PATCH] backlight: journada720: fix Wmisleading-indentation warning Date: Mon, 22 Mar 2021 17:41:28 +0100 Message-Id: <20210322164134.827091-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Sam Ravnborg , dri-devel@lists.freedesktop.org, Arnd Bergmann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RnJvbTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KCldpdGggZ2NjLTExLCB3ZSBnZXQg YSB3YXJuaW5nIGFib3V0IGNvZGUgdGhhdCBsb29rcyBjb3JyZWN0CmJ1dCBiYWRseSBpbmRlbnRl ZDoKCmRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2pvcm5hZGE3MjBfYmwuYzogSW4gZnVuY3Rpb24g 4oCYam9ybmFkYV9ibF91cGRhdGVfc3RhdHVz4oCZOgpkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9q b3JuYWRhNzIwX2JsLmM6NjY6MTE6IGVycm9yOiB0aGlzIOKAmGVsc2XigJkgY2xhdXNlIGRvZXMg bm90IGd1YXJkLi4uIFstV2Vycm9yPW1pc2xlYWRpbmctaW5kZW50YXRpb25dCiAgIDY2IHwgICAg ICAgICB9IGVsc2UgIC8qIHR1cm4gb24gYmFja2xpZ2h0ICovCiAgICAgIHwgICAgICAgICAgIF5+ fn4KCkNoYW5nZSB0aGUgZm9ybWF0dGluZyBhY2NvcmRpbmcgdG8gb3VyIG5vcm1hbCBjb252ZW50 aW9ucy4KCkZpeGVzOiAxM2E3YjVkYzBkMTcgKCJiYWNrbGlnaHQ6IEFkZHMgSFAgSm9ybmFkYSA3 MDAgc2VyaWVzIGJhY2tsaWdodCBkcml2ZXIiKQpTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPgotLS0KIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2pvcm5hZGE3MjBf YmwuYyB8IDQ0ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBp bnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVv L2JhY2tsaWdodC9qb3JuYWRhNzIwX2JsLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9qb3Ju YWRhNzIwX2JsLmMKaW5kZXggOTk2ZjdiYTNiMzczLi4wNjZkMGRjOThmNjAgMTAwNjQ0Ci0tLSBh L2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2pvcm5hZGE3MjBfYmwuYworKysgYi9kcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9qb3JuYWRhNzIwX2JsLmMKQEAgLTY2LDMwICs2NiwzMCBAQCBzdGF0aWMg aW50IGpvcm5hZGFfYmxfdXBkYXRlX3N0YXR1cyhzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAqYmQp CiAJfSBlbHNlICAvKiB0dXJuIG9uIGJhY2tsaWdodCAqLwogCQlQUFNSIHw9IFBQQ19MREQxOwog Ci0JCS8qIHNlbmQgY29tbWFuZCB0byBvdXIgbWN1ICovCi0JCWlmIChqb3JuYWRhX3NzcF9ieXRl KFNFVEJSSUdIVE5FU1MpICE9IFRYRFVNTVkpIHsKLQkJCWRldl9pbmZvKCZiZC0+ZGV2LCAiZmFp bGVkIHRvIHNldCBicmlnaHRuZXNzXG4iKTsKLQkJCXJldCA9IC1FVElNRURPVVQ7Ci0JCQlnb3Rv IG91dDsKLQkJfQorCS8qIHNlbmQgY29tbWFuZCB0byBvdXIgbWN1ICovCisJaWYgKGpvcm5hZGFf c3NwX2J5dGUoU0VUQlJJR0hUTkVTUykgIT0gVFhEVU1NWSkgeworCQlkZXZfaW5mbygmYmQtPmRl diwgImZhaWxlZCB0byBzZXQgYnJpZ2h0bmVzc1xuIik7CisJCXJldCA9IC1FVElNRURPVVQ7CisJ CWdvdG8gb3V0OworCX0KIAotCQkvKgotCQkgKiBhdCB0aGlzIHBvaW50IHdlIGV4cGVjdCB0aGF0 IHRoZSBtY3UgaGFzIGFjY2VwdGVkCi0JCSAqIG91ciBjb21tYW5kIGFuZCBpcyB3YWl0aW5nIGZv ciBvdXIgbmV3IHZhbHVlCi0JCSAqIHBsZWFzZSBub3RlIHRoYXQgbWF4aW11bSBicmlnaHRuZXNz IGlzIDI1NSwKLQkJICogYnV0IGR1ZSB0byBwaHlzaWNhbCBsYXlvdXQgaXQgaXMgZXF1YWwgdG8g MCwgc28gd2Ugc2ltcGx5Ci0JCSAqIGludmVydCB0aGUgdmFsdWUgKE1BWCBWQUxVRSAtIE5FVyBW QUxVRSkuCi0JCSAqLwotCQlpZiAoam9ybmFkYV9zc3BfYnl0ZShCTF9NQVhfQlJJR0hUIC0gYmQt PnByb3BzLmJyaWdodG5lc3MpCi0JCQkhPSBUWERVTU1ZKSB7Ci0JCQlkZXZfZXJyKCZiZC0+ZGV2 LCAic2V0IGJyaWdodG5lc3MgZmFpbGVkXG4iKTsKLQkJCXJldCA9IC1FVElNRURPVVQ7Ci0JCX0K KwkvKgorCSAqIGF0IHRoaXMgcG9pbnQgd2UgZXhwZWN0IHRoYXQgdGhlIG1jdSBoYXMgYWNjZXB0 ZWQKKwkgKiBvdXIgY29tbWFuZCBhbmQgaXMgd2FpdGluZyBmb3Igb3VyIG5ldyB2YWx1ZQorCSAq IHBsZWFzZSBub3RlIHRoYXQgbWF4aW11bSBicmlnaHRuZXNzIGlzIDI1NSwKKwkgKiBidXQgZHVl IHRvIHBoeXNpY2FsIGxheW91dCBpdCBpcyBlcXVhbCB0byAwLCBzbyB3ZSBzaW1wbHkKKwkgKiBp bnZlcnQgdGhlIHZhbHVlIChNQVggVkFMVUUgLSBORVcgVkFMVUUpLgorCSAqLworCWlmIChqb3Ju YWRhX3NzcF9ieXRlKEJMX01BWF9CUklHSFQgLSBiZC0+cHJvcHMuYnJpZ2h0bmVzcykKKwkJIT0g VFhEVU1NWSkgeworCQlkZXZfZXJyKCZiZC0+ZGV2LCAic2V0IGJyaWdodG5lc3MgZmFpbGVkXG4i KTsKKwkJcmV0ID0gLUVUSU1FRE9VVDsKKwl9CiAKLQkJLyoKLQkJICogSWYgaW5mYWN0IHdlIGdl dCBhbiBUWERVTU1ZIGFzIG91dHB1dCB3ZSBhcmUgaGFwcHkgYW5kIGRvbnQKLQkJICogbWFrZSBh bnkgZnVydGhlciBjb21tZW50cyBhYm91dCBpdAotCQkgKi8KKwkvKgorCSAqIElmIGluZmFjdCB3 ZSBnZXQgYW4gVFhEVU1NWSBhcyBvdXRwdXQgd2UgYXJlIGhhcHB5IGFuZCBkb250CisJICogbWFr ZSBhbnkgZnVydGhlciBjb21tZW50cyBhYm91dCBpdAorCSAqLwogb3V0OgogCWpvcm5hZGFfc3Nw X2VuZCgpOwogCi0tIAoyLjI5LjIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=