[PATCH] arm/hafnium: refuse to build on non-x86-64 hosts

[PATCH] arm/hafnium: refuse to build on non-x86-64 hosts

[Ross Burton]

For reasons, hafnium doesn't use host binaries for stuff like GN, Ninja,
Clang, GCC, or Qemu. Instead it ships binaries that it uses during the
build, but these binaries are only available for x86-64.

Attempts to use external tools (so the recipe can just DEPENDS as usual)
were not successful (clang being the problem) so just forcible stop the
recipe building on anything but x86-64 for now.

Change-Id: I144309d15fa1265b2b105981cd2bfcd376aab7ad
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb b/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb
index 3a52599..361d6db 100644
--- a/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb
+++ b/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb
@@ -72,3 +72,9 @@ do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
 }
 addtask deploy after do_install
+
+python() {
+    # https://developer.trustedfirmware.org/T898
+    if d.getVar("BUILD_ARCH") != "x86_64":
+        raise bb.parse.SkipRecipe("Cannot be built on non-x86-64 hosts")
+}
-- 
2.25.1

Re: [meta-arm] [PATCH] arm/hafnium: refuse to build on non-x86-64 hosts

[Jon Mason]

On Mon, Mar 22, 2021 at 06:59:51PM +0000, Ross Burton wrote:
> For reasons, hafnium doesn't use host binaries for stuff like GN, Ninja,
> Clang, GCC, or Qemu. Instead it ships binaries that it uses during the
> build, but these binaries are only available for x86-64.
> 
> Attempts to use external tools (so the recipe can just DEPENDS as usual)
> were not successful (clang being the problem) so just forcible stop the
> recipe building on anything but x86-64 for now.
> 
> Change-Id: I144309d15fa1265b2b105981cd2bfcd376aab7ad
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---

Included in the master branch.

Thanks,
Jon

>  meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb b/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb
> index 3a52599..361d6db 100644
> --- a/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb
> +++ b/meta-arm/recipes-bsp/hafnium/hafnium_2.4.bb
> @@ -72,3 +72,9 @@ do_deploy() {
>      cp -rf ${D}/firmware/* ${DEPLOYDIR}/
>  }
>  addtask deploy after do_install
> +
> +python() {
> +    # https://developer.trustedfirmware.org/T898
> +    if d.getVar("BUILD_ARCH") != "x86_64":
> +        raise bb.parse.SkipRecipe("Cannot be built on non-x86-64 hosts")
> +}
> -- 
> 2.25.1
> 

> 
> 
>