From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCE5C433E1 for ; Tue, 23 Mar 2021 08:40:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 629696198C for ; Tue, 23 Mar 2021 08:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbhCWIj6 (ORCPT ); Tue, 23 Mar 2021 04:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbhCWIjj (ORCPT ); Tue, 23 Mar 2021 04:39:39 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EA2DC061763 for ; Tue, 23 Mar 2021 01:39:39 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id k10so25715597ejg.0 for ; Tue, 23 Mar 2021 01:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=vOdKWnp3rkpIGMt87ZNlf2cZf53/gDQXm8BtihNuwrY=; b=awC7OJCja/vDjs8UM3Q2cV7cH4nuw99ReUsihpNF+0rbb/GYsXuZl+yoz8gQu8xn4B hTALcZCKLmRhR6rGBx5oe19l9xnWJ31Ch53+rY2CpZSSvH55LYyJp+91113PSVJNIS00 yFWPcW99/D9lZFnQZlpOHcfmEI5dxY6BBarjNauuYBRpKnAvbIeobKullrS6/F+GabEX RLIqR2rCthAonYJaBQByTJodXq+ZjqYwTvE5UiCKMUxKQmKPupfoBqFqkV0eDKW7SzPm 0+ul8XGZKTS40YtkXqZCXjiN7E6EnNaZwrf+8JXCI2s9pdm7CQckxordKve2k8LhNwLb jcoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vOdKWnp3rkpIGMt87ZNlf2cZf53/gDQXm8BtihNuwrY=; b=o6z66RUDtOAD9PO7QcQgdmOFD3SwwI0nNCmAp9FfJJnY7MvghQVMbTkQdcyGJou8CZ fSot3pGgqOuuMWFVi2E6Il0VJnQFdzQos6u29DYFljvjpmQP7UciStl8SSmjQEl7Ik/d zHKJAa6RIu9XWtQii/DcyZNjuqSgvvFFAZGWAKtVqgFDW38fUMqeHu7tzGPmc6l5mfpE r4/GEKUVzoX93HVbCcKPrrREWuMIpy9R6eit3gzTd40Ie5/EaFKXLUzQ6zGHFKR0Hiyl yoLTT6NDIU/mPKpBgIt5UPPhvWTdxdMTYZxnHsGme27ip4XT/q5gGMLIFkzBd+kF4EE3 oARg== X-Gm-Message-State: AOAM532LYc9vnfH3xKH2GOwuXlqOLpmmIvJsLAL8UNfQ63WhUp2vHqzP ZBuYnYhMmzkpIm3AxgE9LTIXLA== X-Google-Smtp-Source: ABdhPJztz2rpnHmS0vjtxAqb+sjwT+S9UIOX/8oNcIG+D+p3IjWse50o3nha+gQW7cNBnqWhjOEJGw== X-Received: by 2002:a17:906:d153:: with SMTP id br19mr3749846ejb.360.1616488777820; Tue, 23 Mar 2021 01:39:37 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id h13sm12649939edz.71.2021.03.23.01.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 01:39:37 -0700 (PDT) Date: Tue, 23 Mar 2021 08:39:35 +0000 From: Lee Jones To: Daniel Thompson Cc: Konrad Dybcio , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, Jingoo Han , Pavel Machek , Dan Murphy , Rob Herring , Andy Gross , Bjorn Andersson , Kiran Gunda , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible Message-ID: <20210323083935.GF2916463@dell> References: <20210228124106.135812-1-konrad.dybcio@somainline.org> <20210228124106.135812-2-konrad.dybcio@somainline.org> <20210322161810.biagj2qro66rv4gt@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210322161810.biagj2qro66rv4gt@maple.lan> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, 22 Mar 2021, Daniel Thompson wrote: > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > Signed-off-by: Konrad Dybcio > > Reviewed-by: Daniel Thompson Why are you Reviewing/Acking a patch that was applied on the 10th? > > --- > > drivers/video/backlight/qcom-wled.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > index 3bc7800eb0a9..497b9035a908 100644 > > --- a/drivers/video/backlight/qcom-wled.c > > +++ b/drivers/video/backlight/qcom-wled.c > > @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev) > > > > static const struct of_device_id wled_match_table[] = { > > { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, > > + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, > > { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, > > { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, > > { .compatible = "qcom,pm8150l-wled", .data = (void *)5 }, -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599ACC433DB for ; Tue, 23 Mar 2021 08:39:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D5346198C for ; Tue, 23 Mar 2021 08:39:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D5346198C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 132538931F; Tue, 23 Mar 2021 08:39:40 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F3858931F for ; Tue, 23 Mar 2021 08:39:39 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id ce10so25687869ejb.6 for ; Tue, 23 Mar 2021 01:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=vOdKWnp3rkpIGMt87ZNlf2cZf53/gDQXm8BtihNuwrY=; b=awC7OJCja/vDjs8UM3Q2cV7cH4nuw99ReUsihpNF+0rbb/GYsXuZl+yoz8gQu8xn4B hTALcZCKLmRhR6rGBx5oe19l9xnWJ31Ch53+rY2CpZSSvH55LYyJp+91113PSVJNIS00 yFWPcW99/D9lZFnQZlpOHcfmEI5dxY6BBarjNauuYBRpKnAvbIeobKullrS6/F+GabEX RLIqR2rCthAonYJaBQByTJodXq+ZjqYwTvE5UiCKMUxKQmKPupfoBqFqkV0eDKW7SzPm 0+ul8XGZKTS40YtkXqZCXjiN7E6EnNaZwrf+8JXCI2s9pdm7CQckxordKve2k8LhNwLb jcoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vOdKWnp3rkpIGMt87ZNlf2cZf53/gDQXm8BtihNuwrY=; b=hXzKeF4D5JOuJ8vbekcop1K13W1baRRO1hEJGd7y9fHrRHEI1LxrV3MnWvoKXUs7uO axV9j1s8BgKz4+0gJrZevmYg5TV+UqJYAXEpE+224mLzdcMOBSkjLTkzRxNEZzp3tVPV DOlCNVmWvJmM8Hxja1h/pqyCQNb1z1o6ItbGYIQWAAxCDSrgdGxZ0uWv2Fhg6VpfROh/ 0vzRcZr6XY2RvpqFIGecqBhjuzB/qrdWq7dQH41dY7cLgr/oiseslLuEwEJXYoCNhheD FtY81PyVYFNlG3pAYmWaAowtlrBzOUBuPO5f0QwtHigZvwMRfN8f89vdy6YzEu7Z88RO Pfqw== X-Gm-Message-State: AOAM530iDmbjU7fpGReBwWXVHsy6yGscsLsSqHckNQmstPPv2vhc4SET /vft+6cAO7iQ0X2axUce+6+pgg== X-Google-Smtp-Source: ABdhPJztz2rpnHmS0vjtxAqb+sjwT+S9UIOX/8oNcIG+D+p3IjWse50o3nha+gQW7cNBnqWhjOEJGw== X-Received: by 2002:a17:906:d153:: with SMTP id br19mr3749846ejb.360.1616488777820; Tue, 23 Mar 2021 01:39:37 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id h13sm12649939edz.71.2021.03.23.01.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 01:39:37 -0700 (PDT) Date: Tue, 23 Mar 2021 08:39:35 +0000 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible Message-ID: <20210323083935.GF2916463@dell> References: <20210228124106.135812-1-konrad.dybcio@somainline.org> <20210228124106.135812-2-konrad.dybcio@somainline.org> <20210322161810.biagj2qro66rv4gt@maple.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210322161810.biagj2qro66rv4gt@maple.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Kiran Gunda , Jingoo Han , linux-arm-msm@vger.kernel.org, Konrad Dybcio , Andy Gross , dri-devel@lists.freedesktop.org, Bjorn Andersson , Rob Herring , martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, Pavel Machek , angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Dan Murphy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAyMiBNYXIgMjAyMSwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBTdW4sIEZl YiAyOCwgMjAyMSBhdCAwMTo0MTowNVBNICswMTAwLCBLb25yYWQgRHliY2lvIHdyb3RlOgo+ID4g QWRkIGEgY29tcGF0aWJsZSBmb3IgUE1JODk5NCBXTEVELiBJdCB1c2VzIHRoZSBWNCBvZiBXTEVE IElQLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBLb25yYWQgRHliY2lvIDxrb25yYWQuZHliY2lv QHNvbWFpbmxpbmUub3JnPgo+IAo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVGhvbXBzb24gPGRhbmll bC50aG9tcHNvbkBsaW5hcm8ub3JnPgoKV2h5IGFyZSB5b3UgUmV2aWV3aW5nL0Fja2luZyBhIHBh dGNoIHRoYXQgd2FzIGFwcGxpZWQgb24gdGhlIDEwdGg/Cgo+ID4gLS0tCj4gPiAgZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMgfCAxICsKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0 L3Fjb20td2xlZC5jIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMKPiA+IGlu ZGV4IDNiYzc4MDBlYjBhOS4uNDk3YjkwMzVhOTA4IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMKPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L3Fjb20td2xlZC5jCj4gPiBAQCAtMTcwNCw2ICsxNzA0LDcgQEAgc3RhdGljIGludCB3bGVk X3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gIAo+ID4gIHN0YXRpYyBj b25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHdsZWRfbWF0Y2hfdGFibGVbXSA9IHsKPiA+ICAJeyAu Y29tcGF0aWJsZSA9ICJxY29tLHBtODk0MS13bGVkIiwgLmRhdGEgPSAodm9pZCAqKTMgfSwKPiA+ ICsJeyAuY29tcGF0aWJsZSA9ICJxY29tLHBtaTg5OTQtd2xlZCIsIC5kYXRhID0gKHZvaWQgKik0 IH0sCj4gPiAgCXsgLmNvbXBhdGlibGUgPSAicWNvbSxwbWk4OTk4LXdsZWQiLCAuZGF0YSA9ICh2 b2lkICopNCB9LAo+ID4gIAl7IC5jb21wYXRpYmxlID0gInFjb20scG02NjBsLXdsZWQiLCAuZGF0 YSA9ICh2b2lkICopNCB9LAo+ID4gIAl7IC5jb21wYXRpYmxlID0gInFjb20scG04MTUwbC13bGVk IiwgLmRhdGEgPSAodm9pZCAqKTUgfSwKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9y IFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=