All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 0/2] optionrom/pvh: use memcmp() to find the RSDP signature
Date: Tue, 23 Mar 2021 10:22:09 +0100	[thread overview]
Message-ID: <20210323092211.44597-1-sgarzare@redhat.com> (raw)

In this version I added a memcmp() implementation. In v1 I tried with
__builtin_memcmp() but CI failed with clang [1] and gcc 4.8.5.

v2:
- added patch 1 to provide a memcmp() implementation
- made 'rsdp_signature' static const [Phil]
- uses memcmp() instead of __builtin_memcmp()
- added pvh.bin binary with the changes applied

v1: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg07425.html

Thanks,
Stefano

[1] https://gitlab.com/sgarzarella/qemu/-/jobs/1117036403#L385

Stefano Garzarella (2):
  optionrom: add memcmp() implementation
  optionrom/pvh: use memcmp() to find the RSDP signature

 pc-bios/optionrom/optrom.h   |  15 +++++++++++++++
 pc-bios/optionrom/pvh_main.c |  12 +++++++-----
 pc-bios/pvh.bin              | Bin 1536 -> 1536 bytes
 3 files changed, 22 insertions(+), 5 deletions(-)

-- 
2.30.2



             reply	other threads:[~2021-03-23  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  9:22 Stefano Garzarella [this message]
2021-03-23  9:22 ` [PATCH v2 1/2] optionrom: add memcmp() implementation Stefano Garzarella
2021-03-23  9:22 ` [PATCH v2 2/2] optionrom/pvh: use memcmp() to find the RSDP signature Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323092211.44597-1-sgarzare@redhat.com \
    --to=sgarzare@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.