From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD10C433DB for ; Tue, 23 Mar 2021 09:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 713EE619A5 for ; Tue, 23 Mar 2021 09:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229500AbhCWJkW (ORCPT ); Tue, 23 Mar 2021 05:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhCWJkA (ORCPT ); Tue, 23 Mar 2021 05:40:00 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDEDC061574 for ; Tue, 23 Mar 2021 02:40:00 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id dm8so22684917edb.2 for ; Tue, 23 Mar 2021 02:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VM6J50cuO11tHNrSpVMEPhTlVh0nXJYB1QWh6jX41x8=; b=ljIX33yEr+y8O/Km4ORjc6mpfKAzTKw7E0cIYwNv9D4+CTk92/dWTK8pNVyby0TD92 r/WgLLXu2D/bfmC+KhRAZAGh9C/rGvicFTh6UwBCdlMnsO2rcHMxZ9S6N+lXOjh18o4J 3uqKQ0ovd60NWl5nQ01pHI/PQMEMvBBmS6LT19KDWAabdB9J3Gs4TEue6ob5HiAUrQ/R QNrc/NfLdBo3cFk2gKJQTVpLW6QevvR3UFJWOCRwB5Bbe1rG1amFtjn2+Ws2aJkjCrku AC62Rh3GXbClZekjs+wTrd8c3oGZt8jSw4VuJmySUHRloEcPrz/fFcQK5gImMkR2ZtuD B27w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VM6J50cuO11tHNrSpVMEPhTlVh0nXJYB1QWh6jX41x8=; b=G/AoMSl8tZr3hz22MBcbakDpI+9exwr5FfCxtoMhNNRi9323rvMZJR3piEoIikn9gl 5jeXQIpaqaFEEwB1TyQu29f3kugBUa3NEJRkI0GEAzGD/y5cwkxtsF8aHCZ4+s9Nura5 u1SiXQkIod9fZ2XWhSkpiOAIyoPFFI1JYhY4EPi/5tBvQctIsK2J1pSeneETAQIF26Q2 R2JZdRz8kssRcPsLmCNH3Y0HzOCfRN6ruJM+3gJwwX6O/qsX0i1mFx0QeG0Oodol3fsS D8wcWywd1E8c1QmQWwogauy6q65JU7AkmuZcXTFL1BKZyOa0kkug9DgnTXSXoSDxK1/W I7Ww== X-Gm-Message-State: AOAM530ICeOw/9go1VmM7UffYz4dZ331gnIsDinRDwHyuDkt30mjg9Ob 7ztpDBbfk6vyUpZYqA/YZfKqRV8rRAmTYw== X-Google-Smtp-Source: ABdhPJxdvGM+6tcJUBAoHYZn+tISoI8Z3WDYAZL4H8IT3tFDossgdWDbo06ey4bSGaw1krADL34Q8g== X-Received: by 2002:a05:6402:2058:: with SMTP id bc24mr3723646edb.243.1616492399245; Tue, 23 Mar 2021 02:39:59 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id lx6sm10905544ejb.64.2021.03.23.02.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 02:39:58 -0700 (PDT) Date: Tue, 23 Mar 2021 09:39:56 +0000 From: Lee Jones To: Fabrice Gasnier Cc: vilhelm.gray@gmail.com, alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com, olivier.moysan@foss.st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] mfd: stm32-timers: avoid clearing auto reload register Message-ID: <20210323093956.GS2916463@dell> References: <1614793895-10504-1-git-send-email-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1614793895-10504-1-git-send-email-fabrice.gasnier@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Mar 2021, Fabrice Gasnier wrote: > The ARR register is cleared unconditionally upon probing, after the maximum > value has been read. This initial condition is rather not intuitive, when > considering the counter child driver. It rather expects the maximum value > by default: > - The counter interface shows a zero value by default for 'ceiling' > attribute. > - Enabling the counter without any prior configuration makes it doesn't > count. > > The reset value of ARR register is the maximum. So Choice here > is to backup it, and restore it then, instead of clearing its value. > It also fixes the initial condition seen by the counter driver. > > Fixes: d0f949e220fd ("mfd: Add STM32 Timers driver") > > Signed-off-by: Fabrice Gasnier > --- > drivers/mfd/stm32-timers.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1295EC433DB for ; Tue, 23 Mar 2021 09:41:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98AE2619A5 for ; Tue, 23 Mar 2021 09:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98AE2619A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xjQySM/ggJF4M+kZSu3yyodY8L0KkuEgW1ebWoJMi1Y=; b=exAfScnkyhg1Uc5g0usTNvv5O ysfYYrzWSrZOoN+NXVAo5W/Og3Kr7/Y0WyDf0oatwBRchMgLMyqRfJFF7N8/8eqQUB+ouack2j6s5 bVjTycMu0ACBQ27dhNxxQfrh9R55o0HpthfXUZES1l/D77hBE+Jo+lmyfVIGF69kn7r1LSltZ4IMs bggVMAZgQoRZ6ZIv4U5LcXuPPz3FK224mXrQGFI7JUgsfWRs1fE9j2uL+HDmP+lrE/vDwRYEEB3oy GK+I398NkyEHDxw+R1PF7KgmfKdIDkm3CsDpH/yAavo5OklRuAIJ4NrCwGUVxCSLNkGimWPdjcX+3 KWh+AK2zA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOdWC-00EUIG-Ie; Tue, 23 Mar 2021 09:40:09 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOdW5-00EUGM-LM for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 09:40:05 +0000 Received: by mail-ed1-x536.google.com with SMTP id x21so22660646eds.4 for ; Tue, 23 Mar 2021 02:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VM6J50cuO11tHNrSpVMEPhTlVh0nXJYB1QWh6jX41x8=; b=ljIX33yEr+y8O/Km4ORjc6mpfKAzTKw7E0cIYwNv9D4+CTk92/dWTK8pNVyby0TD92 r/WgLLXu2D/bfmC+KhRAZAGh9C/rGvicFTh6UwBCdlMnsO2rcHMxZ9S6N+lXOjh18o4J 3uqKQ0ovd60NWl5nQ01pHI/PQMEMvBBmS6LT19KDWAabdB9J3Gs4TEue6ob5HiAUrQ/R QNrc/NfLdBo3cFk2gKJQTVpLW6QevvR3UFJWOCRwB5Bbe1rG1amFtjn2+Ws2aJkjCrku AC62Rh3GXbClZekjs+wTrd8c3oGZt8jSw4VuJmySUHRloEcPrz/fFcQK5gImMkR2ZtuD B27w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VM6J50cuO11tHNrSpVMEPhTlVh0nXJYB1QWh6jX41x8=; b=PE1iImAj2VvxElw+Pmt6y8pRya5Dv75mtMgd56BiRSU+0pEyoFzbXIecuNE66kKHxC jN4wcPL7mbkIRf6VuYGT58h+j1WwjhhbrlV/Y+f0OMQi1uaki+OUa+EJq849Z0OMK4Wq aSItB6K/oGhZNWrPSRQ44aeKLEtjzho+aE155TMTXXIMcAPo5c9hnVPFRLnziD2T0iD6 HA0sXfuisj8FQaoyInC24VA6V5zynWebeWPwGkfZedwzxQ4nFkBqZKyPgjSVs9R8EzB8 VFYcJTniv+6lJFzIclIq1YN4NLCFhI1dF633ySJplVdQH/0dLLOiMHZaUn45p3WlGiMv D39w== X-Gm-Message-State: AOAM530EO/ZorT71tq5fEFoxfQsnCxO1yJSHReyZGxES2EXU7WNhFV9M i9YKeDlr2qwqZ3XQkGA/XmmC0A== X-Google-Smtp-Source: ABdhPJxdvGM+6tcJUBAoHYZn+tISoI8Z3WDYAZL4H8IT3tFDossgdWDbo06ey4bSGaw1krADL34Q8g== X-Received: by 2002:a05:6402:2058:: with SMTP id bc24mr3723646edb.243.1616492399245; Tue, 23 Mar 2021 02:39:59 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id lx6sm10905544ejb.64.2021.03.23.02.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 02:39:58 -0700 (PDT) Date: Tue, 23 Mar 2021 09:39:56 +0000 From: Lee Jones To: Fabrice Gasnier Cc: vilhelm.gray@gmail.com, alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com, olivier.moysan@foss.st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] mfd: stm32-timers: avoid clearing auto reload register Message-ID: <20210323093956.GS2916463@dell> References: <1614793895-10504-1-git-send-email-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1614793895-10504-1-git-send-email-fabrice.gasnier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_094002_673605_B03662D0 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwMyBNYXIgMjAyMSwgRmFicmljZSBHYXNuaWVyIHdyb3RlOgoKPiBUaGUgQVJSIHJl Z2lzdGVyIGlzIGNsZWFyZWQgdW5jb25kaXRpb25hbGx5IHVwb24gcHJvYmluZywgYWZ0ZXIgdGhl IG1heGltdW0KPiB2YWx1ZSBoYXMgYmVlbiByZWFkLiBUaGlzIGluaXRpYWwgY29uZGl0aW9uIGlz IHJhdGhlciBub3QgaW50dWl0aXZlLCB3aGVuCj4gY29uc2lkZXJpbmcgdGhlIGNvdW50ZXIgY2hp bGQgZHJpdmVyLiBJdCByYXRoZXIgZXhwZWN0cyB0aGUgbWF4aW11bSB2YWx1ZQo+IGJ5IGRlZmF1 bHQ6Cj4gLSBUaGUgY291bnRlciBpbnRlcmZhY2Ugc2hvd3MgYSB6ZXJvIHZhbHVlIGJ5IGRlZmF1 bHQgZm9yICdjZWlsaW5nJwo+ICAgYXR0cmlidXRlLgo+IC0gRW5hYmxpbmcgdGhlIGNvdW50ZXIg d2l0aG91dCBhbnkgcHJpb3IgY29uZmlndXJhdGlvbiBtYWtlcyBpdCBkb2Vzbid0Cj4gICBjb3Vu dC4KPiAKPiBUaGUgcmVzZXQgdmFsdWUgb2YgQVJSIHJlZ2lzdGVyIGlzIHRoZSBtYXhpbXVtLiBT byBDaG9pY2UgaGVyZQo+IGlzIHRvIGJhY2t1cCBpdCwgYW5kIHJlc3RvcmUgaXQgdGhlbiwgaW5z dGVhZCBvZiBjbGVhcmluZyBpdHMgdmFsdWUuCj4gSXQgYWxzbyBmaXhlcyB0aGUgaW5pdGlhbCBj b25kaXRpb24gc2VlbiBieSB0aGUgY291bnRlciBkcml2ZXIuCj4gCj4gRml4ZXM6IGQwZjk0OWUy MjBmZCAoIm1mZDogQWRkIFNUTTMyIFRpbWVycyBkcml2ZXIiKQo+IAo+IFNpZ25lZC1vZmYtYnk6 IEZhYnJpY2UgR2FzbmllciA8ZmFicmljZS5nYXNuaWVyQGZvc3Muc3QuY29tPgo+IC0tLQo+ICBk cml2ZXJzL21mZC9zdG0zMi10aW1lcnMuYyB8IDcgKysrKysrLQo+ICAxIGZpbGUgY2hhbmdlZCwg NiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpBcHBsaWVkLCB0aGFua3MuCgotLSAKTGVl IEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2 aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9s bG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=