All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>
Cc: Xueming Li <xuemingl@nvidia.com>,
	dev@dpdk.org,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode
Date: Tue, 23 Mar 2021 12:57:35 +0300	[thread overview]
Message-ID: <20210323125735.0e5c243d@sovereign> (raw)
In-Reply-To: <9acf308d-c73f-2063-5b6d-3fb4fc601c76@ashroe.eu>

2021-03-23 09:34 (UTC+0000), Kinsella, Ray:
> On 23/03/2021 09:33, Kinsella, Ray wrote:
> > 
> > 
> > On 22/03/2021 23:32, Dmitry Kozlyuk wrote:  
> >> 2021-03-16 20:45 (UTC+0800), Xueming Li:
> >> [...]  
> [SNIP]
> >>>  	rte_mem_page_size;  
> >>
> >> New function is private to EAL, so it doesn't need exporting.
> >>  
> > 
> > Right - it is annotated as INTERNAL.
> >   
> 
> Sorry, let me be clearer - it is being correctly annotated unless I have missed something.

This function is purely internal to librte_eal. It doesn't need to be added
to .map or .def. It also doesn't need __rte_internal, like other functions in
eal_private.h don't need it either.

  reply	other threads:[~2021-03-23  9:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 12:45 [dpdk-dev] [PATCH] eal: update all buses default scan mode Xueming Li
2021-03-22 23:32 ` Dmitry Kozlyuk
2021-03-23  9:33   ` Kinsella, Ray
2021-03-23  9:34     ` Kinsella, Ray
2021-03-23  9:57       ` Dmitry Kozlyuk [this message]
2021-03-23  9:58         ` Kinsella, Ray
2021-03-28 13:14           ` Xueming(Steven) Li
2021-03-28 13:12 ` [dpdk-dev] [PATCH v1] " Xueming Li
2023-06-30 16:16   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323125735.0e5c243d@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitrym@microsoft.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=pallavi.kadam@intel.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.