From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lOmop-0003ds-BI for mharc-grub-devel@gnu.org; Tue, 23 Mar 2021 15:35:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOmon-0003a1-PW for grub-devel@gnu.org; Tue, 23 Mar 2021 15:35:57 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:54098) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOmol-0006LU-GL for grub-devel@gnu.org; Tue, 23 Mar 2021 15:35:57 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12NJYg6R184864; Tue, 23 Mar 2021 19:35:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=+wCL+n3vYlCUm0e2CIxMjs98cmU+MQr91dW1Zre3chg=; b=bRlwthXVhDbP7YoERHOEUKOooQaKVTPpIcEp9BxOVrFHKA8Hp3zm2Jih/ygPz4BVvbmK WaJLNqCPtMuXiXzqC08PF7lQZlarUG5rZKLNP1U6cJMMf0z6DpCsGULrlv+8uRiJEoCn 7XLLWP00oPsisNLppzH4FspRFcig8ElP9HYi0jcbWOeJ+OAgYQ2nrunBtMtBuRBZMLdn EWCCqJn82Kznr5EA36XENF8fV/jZzYXGAfVIoUuaGmQh2sQi2Rod4u9aifxyr9nHuPCd C7IzaxZ/YTkzzLZB7RORdVyb2fhNOtdLuxoo/x/5MZ0YUt21UapwExwTlu71xuxndPIu Zw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 37d8fr8dp6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Mar 2021 19:35:37 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12NJYlvN009980; Tue, 23 Mar 2021 19:35:36 GMT Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2055.outbound.protection.outlook.com [104.47.38.55]) by userp3030.oracle.com with ESMTP id 37dtyxvpmq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Mar 2021 19:35:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=deISUZM2kQM/kqOb4GlUERf/FRvr0nEX0sOC828JlXuARF13SBeAStS/P4ijooNlxhlmB2lZwtt0uy13EOsHPNN/HtQ/iTyOTuwtJf30Qfq75od1N/DCF+NFZPrMS4D5pP1P8aKcmKQz4ozDyGA/qpcoyJvpiYhGQBBIl2ox11BnRsQQgqcxYmC/8+X2B/NnIQUnIdJGet72cf8V962tS82H+AybkReZmI+MnfdzWSCSIZvf0arNsakOjYLijWWLmx5L8JjgorsExTKja7BBev3MG1UZCdWi39RgDMrIDXd8G/AalEOkquEK1/AyKM5gGYVP4NSRmfdcoJPkwQxrzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wCL+n3vYlCUm0e2CIxMjs98cmU+MQr91dW1Zre3chg=; b=WlBZpT/SRyI9Ib5dJNKITMZyik/BEbClk4OJuvOL8PVCCglpmh1uC9+nFNm4YvOSzzL0uNspvTUg3MeQw3zqn/aSuhP5RkV/v7SCKiI5ojo84ZVvA7CbxCheQXVTQV9wmblD31HKiMLBysFGjVXGlivcpFCP4swbfWmWhS0d47tBlJqNB8tai6XHYPs8+/ZEum7axPywtBSCTQHhZs4I6bDIEbAU6hxoM0ttzkJivbZiIpZFjL+vamTx7C14OUisLSWrj3gTSJ0T9jJo8StDsDFXmGW+wXWTFPjsxh3pOeqiqgjRNnJzapV4d82oWviDp2k501wRoDaYq+1GpR/02w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wCL+n3vYlCUm0e2CIxMjs98cmU+MQr91dW1Zre3chg=; b=OyFyadk9LLWPYh/mo2eLMfCtkT8vOhRFPyhi+YKBYhfKuzYVcLhN3IlCF8BKhdnncjeehud/PQHm50lYr3UF/1IAUyNV6+M0EcpmlQQs7ZqEGJqexOlo0VR0dGz84ZPDbmZEv/gyh7jdaE+bD4Nhki7sbiMIJg5A7qH1nezyDSI= Authentication-Results: physik.fu-berlin.de; dkim=none (message not signed) header.d=none;physik.fu-berlin.de; dmarc=none action=none header.from=oracle.com; Received: from BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) by BN8PR10MB3121.namprd10.prod.outlook.com (2603:10b6:408:c6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Tue, 23 Mar 2021 19:35:34 +0000 Received: from BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::a06f:8b3f:14dc:8af5]) by BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::a06f:8b3f:14dc:8af5%3]) with mapi id 15.20.3955.024; Tue, 23 Mar 2021 19:35:34 +0000 Date: Tue, 23 Mar 2021 20:35:23 +0100 From: Daniel Kiper To: John Paul Adrian Glaubitz Cc: The development of GNU GRUB , Peter Jones , debian-ia64 , Sergei Trofimovich , Jessica Clarke Subject: Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper Message-ID: <20210323193523.n4sx4wyhwjpekciu@tomti.i.net-space.pl> References: <20210302180056.zq4bk2w2cuqhbvx3@tomti.i.net-space.pl> <20210302180204.23887-108-daniel.kiper@oracle.com> <7bd6a124-e1fc-515e-6e92-01b8b8de3ecc@physik.fu-berlin.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bd6a124-e1fc-515e-6e92-01b8b8de3ecc@physik.fu-berlin.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [84.10.22.86] X-ClientProxiedBy: AM5PR0701CA0067.eurprd07.prod.outlook.com (2603:10a6:203:2::29) To BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tomti.i.net-space.pl (84.10.22.86) by AM5PR0701CA0067.eurprd07.prod.outlook.com (2603:10a6:203:2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.10 via Frontend Transport; Tue, 23 Mar 2021 19:35:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49263f59-95b9-4b91-a76c-08d8ee32d3e9 X-MS-TrafficTypeDiagnostic: BN8PR10MB3121: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2IM3Q/I/C+BnK3QX6+FLQvTbRKDfHEN2llgFGVc8hdqrJe7vavufk1qKvAqS30ndO7J1y+74B6XDPnj2oV2cvQasnPlqNNlQyOqg2s0ga5KZJdTlBsFsacn+YeE6pbC2zz4WCCPJJkLAIpQBRswlTVVId7OeZXMx5dYiMvTDiP7E2+1qSG1TNdm/+bXx5YwdbVe1PqyC/CEA/oMTj5UKyK9Nw2zkNXCrlBukyv9c6bq3IXaOLT3JKXROJYWvWJQocJyexRm5v8RCEblMuz+Ob27R9Ix6zvlBWisp5vjLk6r0xDZIaZQvbHDzFoaBDJwqUkm633ypbU6psri8/Erkiyy0XQBqlB8d8QAIYt82/Vz4nX4My0wHA+tgnLqnAKdB7g0qFeob0dCtAimv9w9k01ypAUv5c13/GVF2Uyw8Nur7Vy9UVV+01mk1sYe3e1fUuvD/C9qpwS1hOq4+K/G+TrBOegDAYpPVV7OXzS9vESqfdgYrYH37OwygT9TpuTUsQj9h/eVKoQicyhDoA59TKx3wg/CwoiGyAXgeWzRbkBjYN0VvZGU+vskdLcdCmPMY8y39H5b8xfOQYeDUVK5fxWr8dPOKQ+Uy5J3Egc41jon7tYHgNChdbS1yejKvjqG35EIbJAgOoOxK3iojfjnMJjaYDM9PU/6Ayrw3F8ccMvk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2228.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(396003)(376002)(39860400002)(346002)(52116002)(7696005)(66946007)(6916009)(6666004)(4326008)(8936002)(186003)(5660300002)(83380400001)(66476007)(8676002)(66556008)(4744005)(15650500001)(316002)(26005)(9686003)(956004)(2906002)(55016002)(54906003)(44832011)(1076003)(478600001)(16526019)(53546011)(86362001)(38100700001)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?l/E+xIsD7v8kTYt4JrrO+YPffeZdiuLSS7h875Mcub08438oyAm/SXu6/QQ6?= =?us-ascii?Q?VqpSMhvlS0qafxMVmH+f5rkuGHlqy4iJPB1/bs5E+l0MxpzJF5DKBC1Pcnrd?= =?us-ascii?Q?XtPBzUflfD02kYnF16er7C1Nd9zp6myrBLeQvJHDxcCVwlzLhiwgki56OON2?= =?us-ascii?Q?NYRV9zfG/q9YWRVWcWuWSKIhMATJi3J9b42jAVTMHOinhgtrZgPPVyHkpukf?= =?us-ascii?Q?n2HqCucA2kOcSYjkdnG4FyBLL6dyzibQYjRenoIdxPUAOmWSke38nT18o57d?= =?us-ascii?Q?h7oemCQcV9WIrBdf25brrfkUlBV9mREmKwk1WiY0VeAXWp1yLrfOCkPE/F8j?= =?us-ascii?Q?Ms0sXN6bUkdXddWUzkb4GIr0sSUtKGU37EypOjG5XorvSr5lpc99IhdhH9f+?= =?us-ascii?Q?g9+CyzMpgz8RTte3kWZUEAYPdVhfdzViFmRuDU+Fs41Pvg6DU+PRuWA+OTPC?= =?us-ascii?Q?uDfrhHusO1bcViNz8QyqpQDbyMrE3CJD0hrvbniaMG7Bt4W/o0CqGJ+pMjDa?= =?us-ascii?Q?7MzcARrgg5llS+XyyNmwvnFbOhglIybAlj/wigxRmtoF9kc2xGVNs4gVbwme?= =?us-ascii?Q?ibkKEd2OJiYXRXbq7UKKPKJdGOfCR7HP8vbkgJzfF+bgJHYMDHAKt9273aLn?= =?us-ascii?Q?1A0VcWimoORPiKslAWuF3Kzo0L2oZanU7foAVahSEeTAOW+ZxYqj8CLgOsZF?= =?us-ascii?Q?nps+VH+53WnSncu0Jgx2Qubo5gx7vwsvBI87gkYQayE171PkM9S1Ak0UhvZI?= =?us-ascii?Q?MRZ5HERyaxLb4CcGnT9Z/zGCBBeH7JW9YVps4nC+1LrdKK7FZhCTPzLJ3jK4?= =?us-ascii?Q?+4GErvcGmU3qmFfP/yZkUdD7GOI3TyFXWsDLa6fJBPOZ76MVQLv3UJlISCpq?= =?us-ascii?Q?/9YP5zJBBcuDC6j8Zkdj5rQu7G8gDdTwKOtHCwITm1W+H2UpziELO30AGL4D?= =?us-ascii?Q?3W64WddQtfF/KQMy5kGQHZZavoNRmeH0A8ZK9/2/RsN6OflaKXP0MAtnIsB8?= =?us-ascii?Q?QIh/9w++kGFE2TvIRPO9lqocS76swPdd5wpRdTkOQ4GL6o+ZdwMSeAhJEoxW?= =?us-ascii?Q?/veDHpzR5VUydLuZDk+bIUICz/zU2D4KNt48Gg3wQyx714ZGQnbKQpNad8uO?= =?us-ascii?Q?BqGoknnEfsiaFYS7vxmK9aneLSDaDDBQr0KanG78M/2XCcsvYnm44Atof3bu?= =?us-ascii?Q?eZsz3yL2033Ylu18RZtvJ3xMtq/km1KRR7sPeLmtNiUHhTzV/GNoBh8hbRWn?= =?us-ascii?Q?RATsUVBmqtdhJCgKZiNqLrke559DttTMKqvzR8uIvsCsvNUoFSjjxlKtv4fI?= =?us-ascii?Q?V3qLFCk745oOVBOQ62WuT4gX?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49263f59-95b9-4b91-a76c-08d8ee32d3e9 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2228.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 19:35:34.6314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fb5wXesHbn1hD5Q1ONnbfclFMx9AW1uzUi9HbpxGYMEVxw7EjRxLvgkgLaKYbfn4dDSGSkh2AaqQJZ5hK4oyAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3121 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9932 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103230143 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9932 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 spamscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103230143 Received-SPF: pass client-ip=156.151.31.86; envelope-from=daniel.kiper@oracle.com; helo=userp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 19:35:58 -0000 Hi Adrian, On Tue, Mar 23, 2021 at 08:16:43PM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote: > > On 3/2/21 7:01 PM, Daniel Kiper wrote: > >> From: Peter Jones > >> > >> Add a init_pe_section() helper function to setup PE sections. This makes > >> the code simpler and easier to read. > >> > >> Signed-off-by: Peter Jones > >> Signed-off-by: Javier Martinez Canillas > >> Reviewed-by: Daniel Kiper > > > > This change broke GRUB on ia64 for me. It now fails to perform any basic commands: > > Any chance someone could have a look at this? As explained in the follow-up mails, > the problem is that the pointer pointing to the modules location in the core image > deviate from the actual modules location as the former was updated but the former > not. I chatted about that with Javier yesterday. He told me he will take a look at the issue... Daniel