From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A597DC433C1 for ; Wed, 24 Mar 2021 01:34:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C813619EA for ; Wed, 24 Mar 2021 01:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbhCXBeX (ORCPT ); Tue, 23 Mar 2021 21:34:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:32950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231546AbhCXBeC (ORCPT ); Tue, 23 Mar 2021 21:34:02 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 857A2619BB; Wed, 24 Mar 2021 01:34:01 +0000 (UTC) Date: Tue, 23 Mar 2021 21:33:59 -0400 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 08/18] trace-cmd: Save tsc2nsec clock in trace.dat file Message-ID: <20210323213359.4c909222@oasis.local.home> In-Reply-To: <20210322095945.259300-9-tz.stoyanov@gmail.com> References: <20210322095945.259300-1-tz.stoyanov@gmail.com> <20210322095945.259300-9-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 22 Mar 2021 11:59:35 +0200 "Tzvetomir Stoyanov (VMware)" wrote: > @@ -4168,7 +4167,8 @@ static void write_guest_file(struct buffer_instance *instance) > handle = tracecmd_get_output_handle_fd(fd); > if (!handle) > die("error writing to %s", file); > - > + if (instance->flags & BUFFER_FL_TSC2NSEC) > + tracecmd_set_out_clock(handle, TSCNSEC_CLOCK); > temp_files = malloc(sizeof(*temp_files) * cpu_count); > if (!temp_files) > die("failed to allocate temp_files for %d cpus", > @@ -4290,9 +4290,10 @@ static void record_data(struct common_record_context *ctx) > add_guest_info(handle, instance); > } > > - if (ctx->tsc2nsec.mult) > + if (ctx->tsc2nsec.mult) { > add_tsc2nsec(handle, &ctx->tsc2nsec); > - > + tracecmd_set_out_clock(handle, TSCNSEC_CLOCK); > + } > if (tracecmd_write_cmdlines(handle)) > die("Writing cmdlines"); > OK, I see why you wanted to clean up the writing of all clocks. But I still find that information valuable as for the reasons I stated in the other email. I wonder if we can still read all the clocks, parse them out (remove the '[' and ']') and have tracecmd_set_out_clock() still write them. Hmm? Or at least save them in a new option (like I save uname). -- Steve