* [PATCH] linux/gpio/driver.h: some edits for clarity
@ 2021-03-23 22:19 Randy Dunlap
2021-03-25 8:03 ` Linus Walleij
2021-03-26 13:06 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-03-23 22:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Linus Walleij, Bartosz Golaszewski, linux-gpio
Fix a few typos and some punctuation.
Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org
---
include/linux/gpio/driver.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--- linux-next-20210323.orig/include/linux/gpio/driver.h
+++ linux-next-20210323/include/linux/gpio/driver.h
@@ -227,7 +227,7 @@ struct gpio_irq_chip {
/**
* @valid_mask:
*
- * If not %NULL holds bitmask of GPIOs which are valid to be included
+ * If not %NULL, holds bitmask of GPIOs which are valid to be included
* in IRQ domain of the chip.
*/
unsigned long *valid_mask;
@@ -346,7 +346,7 @@ struct gpio_irq_chip {
* output.
*
* A gpio_chip can help platforms abstract various sources of GPIOs so
- * they can all be accessed through a common programing interface.
+ * they can all be accessed through a common programming interface.
* Example sources would be SOC controllers, FPGAs, multifunction
* chips, dedicated GPIO expanders, and so on.
*
@@ -435,15 +435,15 @@ struct gpio_chip {
/**
* @valid_mask:
*
- * If not %NULL holds bitmask of GPIOs which are valid to be used
+ * If not %NULL, holds bitmask of GPIOs which are valid to be used
* from the chip.
*/
unsigned long *valid_mask;
#if defined(CONFIG_OF_GPIO)
/*
- * If CONFIG_OF is enabled, then all GPIO controllers described in the
- * device tree automatically may have an OF translation
+ * If CONFIG_OF_GPIO is enabled, then all GPIO controllers described in
+ * the device tree automatically may have an OF translation
*/
/**
@@ -508,7 +508,7 @@ extern int gpiochip_add_data_with_key(st
* for GPIOs will fail rudely.
*
* gpiochip_add_data() must only be called after gpiolib initialization,
- * ie after core_initcall().
+ * i.e. after core_initcall().
*
* If gc->base is negative, this requests dynamic assignment of
* a range of valid GPIOs.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux/gpio/driver.h: some edits for clarity
2021-03-23 22:19 [PATCH] linux/gpio/driver.h: some edits for clarity Randy Dunlap
@ 2021-03-25 8:03 ` Linus Walleij
2021-03-26 13:06 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-03-25 8:03 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Tue, Mar 23, 2021 at 11:19 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> Fix a few typos and some punctuation.
> Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux/gpio/driver.h: some edits for clarity
2021-03-23 22:19 [PATCH] linux/gpio/driver.h: some edits for clarity Randy Dunlap
2021-03-25 8:03 ` Linus Walleij
@ 2021-03-26 13:06 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2021-03-26 13:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Linus Walleij, linux-gpio
On Tue, Mar 23, 2021 at 11:19 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Fix a few typos and some punctuation.
> Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> ---
Applied with a slightly improved commit message.
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 22:19 [PATCH] linux/gpio/driver.h: some edits for clarity Randy Dunlap
2021-03-25 8:03 ` Linus Walleij
2021-03-26 13:06 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.