From: Rokudo Yan <wu-yan@tcl.com>
To: <paolo.valente@linaro.org>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>
Cc: <wu-yan@tcl.com>
Subject: [PATCH] block,bfq: fix the timeout calculation in bfq_bfqq_charge_time
Date: Wed, 24 Mar 2021 10:33:41 +0800 [thread overview]
Message-ID: <20210324023341.1545234-1-wu-yan@tcl.com> (raw)
in bfq_bfqq_charge_time, timeout_ms is calculated with global
constant bfq_timeout(HZ/8), which is not correct. It should be
bfqd->bfq_timeout here as per-device bfq_timeout can be modified
through /sys/block/<disk/queue/iosched/timeout_sync.
Signed-off-by: Rokudo Yan <wu-yan@tcl.com>
---
block/bfq-wf2q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
index 070e34a7feb1..48f540a5ee6a 100644
--- a/block/bfq-wf2q.c
+++ b/block/bfq-wf2q.c
@@ -872,7 +872,7 @@ void bfq_bfqq_charge_time(struct bfq_data *bfqd, struct bfq_queue *bfqq,
unsigned long time_ms)
{
struct bfq_entity *entity = &bfqq->entity;
- unsigned long timeout_ms = jiffies_to_msecs(bfq_timeout);
+ unsigned long timeout_ms = jiffies_to_msecs(bfqd->bfq_timeout);
unsigned long bounded_time_ms = min(time_ms, timeout_ms);
int serv_to_charge_for_time =
(bfqd->bfq_max_budget * bounded_time_ms) / timeout_ms;
--
2.25.1
next reply other threads:[~2021-03-24 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 2:33 Rokudo Yan [this message]
2021-04-02 10:18 ` [PATCH] block,bfq: fix the timeout calculation in bfq_bfqq_charge_time Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324023341.1545234-1-wu-yan@tcl.com \
--to=wu-yan@tcl.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.