Re: [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h

From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Anson Jacob <Anson.Jacob@amd.com>
Cc: felipe.clark@amd.com, Harry.Wentland@amd.com,
	amd-gfx@lists.freedesktop.org, solomon.chiu@amd.com
Subject: Re: [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h
Date: Wed, 24 Mar 2021 00:12:09 -0400	[thread overview]
Message-ID: <20210324041209.bcmea72uriixhwnn@outlook.office365.com> (raw)
In-Reply-To: <20210323210134.432845-1-Anson.Jacob@amd.com>


[-- Attachment #1.1: Type: text/plain, Size: 2648 bytes --]

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

On 03/23, Anson Jacob wrote:
> Removing code that is not used at the moment.
> 
> Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
>  .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h   | 37 -------------------
>  1 file changed, 37 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> index 09c62485a1f1..2d23462f4980 100644
> --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> @@ -202,12 +202,7 @@ struct dmub_feature_caps {
>  	 * Max PSR version supported by FW.
>  	 */
>  	uint8_t psr;
> -#ifndef TRIM_FAMS
> -	uint8_t fw_assisted_mclk_switch;
> -	uint8_t reserved[6];
> -#else
>  	uint8_t reserved[7];
> -#endif
>  };
>  
>  #if defined(__cplusplus)
> @@ -532,10 +527,6 @@ enum dmub_cmd_type {
>  	 * Command type used for OUTBOX1 notification enable
>  	 */
>  	DMUB_CMD__OUTBOX1_ENABLE = 71,
> -#ifndef TRIM_FAMS
> -	DMUB_CMD__FW_ASSISTED_MCLK_SWITCH = 76,
> -#endif
> -
>  	/**
>  	 * Command type used for all VBIOS interface commands.
>  	 */
> @@ -1115,13 +1106,6 @@ enum dmub_cmd_psr_type {
>  	DMUB_CMD__PSR_FORCE_STATIC		= 5,
>  };
>  
> -#ifndef TRIM_FAMS
> -enum dmub_cmd_fams_type {
> -	DMUB_CMD__FAMS_SETUP_FW_CTRL	= 0,
> -	DMUB_CMD__FAMS_DRR_UPDATE		= 1,
> -};
> -#endif
> -
>  /**
>   * PSR versions.
>   */
> @@ -1791,24 +1775,6 @@ struct dmub_rb_cmd_drr_update {
>  		struct dmub_optc_state dmub_optc_state_req;
>  };
>  
> -#ifndef TRIM_FAMS
> -struct dmub_cmd_fw_assisted_mclk_switch_pipe_data {
> -	uint32_t pix_clk_100hz;
> -	uint32_t min_refresh_in_uhz;
> -	uint32_t max_ramp_step;
> -};
> -
> -struct dmub_cmd_fw_assisted_mclk_switch_config {
> -	uint32_t fams_enabled;
> -	struct dmub_cmd_fw_assisted_mclk_switch_pipe_data pipe_data[DMUB_MAX_STREAMS];
> -};
> -
> -struct dmub_rb_cmd_fw_assisted_mclk_switch {
> -	struct dmub_cmd_header header;
> -	struct dmub_cmd_fw_assisted_mclk_switch_config config_data;
> -};
> -#endif
> -
>  /**
>   * Data passed from driver to FW in a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
>   */
> @@ -1951,9 +1917,6 @@ union dmub_rb_cmd {
>  	 */
>  	struct dmub_rb_cmd_query_feature_caps query_feature_caps;
>  	struct dmub_rb_cmd_drr_update drr_update;
> -#ifndef TRIM_FAMS
> -	struct dmub_rb_cmd_fw_assisted_mclk_switch fw_assisted_mclk_switch;
> -#endif
>  	/**
>  	 * Definition of a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
>  	 */
> -- 
> 2.25.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx