From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: llvmlinux@lists.linuxfoundation.org,
linuxppc-dev@lists.ozlabs.org, Daniel Axtens <dja@axtens.net>
Subject: Re: [RFC PATCH 6/8] powerpc/mm/book3s64/hash: drop pre 2.06 tlbiel for clang
Date: Wed, 24 Mar 2021 10:51:05 -0500 [thread overview]
Message-ID: <20210324155105.GZ16691@gate.crashing.org> (raw)
In-Reply-To: <1616436133.s8792026fh.astroid@bobo.none>
Hi!
On Tue, Mar 23, 2021 at 04:11:10AM +1000, Nicholas Piggin wrote:
> The problem in this file is we generate 3 different tlbie and tlbiel
> instructions with the same mnemonic corresponding to different ISA
> versions.
>
> This might actually be the one good place to use .machine to make sure
> the assembler generates the right thing.
Yes, but then hide that in some macro.
(And "the one good place"? I protest!)
> I'm not entirely sure it is
> foolproof because some of the times the instruction variant is inferred
> by the number of arguments it has yet arguments can be implicit. PPC_
> define would be exactly explicit.
The variants with fewer operands have those coded as 0 in the
instruction. All of this is backwards compatible.
> But if it can be made reasonably robust with .machine then I'd be okay
> with that too.
Since you should do a macro (or inline) for it anyway, you could just
do .long, all the nastiness is in one place anyway then, it won't make
much difference what you do. It should be documented there as well :-)
Segher
next prev parent reply other threads:[~2021-03-24 15:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 3:09 [RFC PATCH 0/8] WIP support for the LLVM integrated assembler Daniel Axtens
2021-02-25 3:09 ` [PATCH 1/8] powerpc/64s/exception: Clean up a missed SRR specifier Daniel Axtens
2021-02-25 3:10 ` [RFC PATCH 2/8] powerpc: check for support for -Wa,-m{power4,any} Daniel Axtens
2021-03-19 1:32 ` [RFC PATCH 2/8] powerpc: check for support for -Wa, -m{power4, any} Nicholas Piggin
2021-03-19 10:53 ` Michael Ellerman
2021-02-25 3:10 ` [RFC PATCH 3/8] powerpc/head-64: do less gas-specific stuff with sections Daniel Axtens
2021-03-19 1:35 ` Nicholas Piggin
2021-02-25 3:10 ` [RFC PATCH 4/8] powerpc/ppc_asm: use plain numbers for registers Daniel Axtens
2021-02-25 15:25 ` Segher Boessenkool
2021-02-26 0:12 ` Daniel Axtens
2021-03-19 1:39 ` Nicholas Piggin
2021-02-25 3:10 ` [RFC PATCH 5/8] poweprc/lib/quad: Provide macros for lq/stq Daniel Axtens
2021-02-25 15:44 ` Segher Boessenkool
2021-02-26 0:13 ` Daniel Axtens
2021-02-25 3:10 ` [RFC PATCH 6/8] powerpc/mm/book3s64/hash: drop pre 2.06 tlbiel for clang Daniel Axtens
2021-03-19 2:01 ` Nicholas Piggin
2021-03-22 16:49 ` Christophe Leroy
2021-03-22 18:11 ` Nicholas Piggin
2021-03-24 15:51 ` Segher Boessenkool [this message]
2021-03-24 21:07 ` Segher Boessenkool
2021-02-25 3:10 ` [RFC PATCH 7/8] powerpc/purgatory: drop .machine specifier Daniel Axtens
2021-02-25 15:58 ` Segher Boessenkool
2021-02-26 0:17 ` Daniel Axtens
2021-03-19 2:05 ` Nicholas Piggin
2021-03-19 10:59 ` Michael Ellerman
2021-02-25 3:10 ` [RFC PATCH 8/8] powerpc/64/asm: don't reassign labels Daniel Axtens
2021-02-25 16:08 ` Segher Boessenkool
2021-02-26 0:28 ` Daniel Axtens
2021-03-19 2:15 ` Nicholas Piggin
2021-03-14 10:01 ` [RFC PATCH 0/8] WIP support for the LLVM integrated assembler Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324155105.GZ16691@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvmlinux@lists.linuxfoundation.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.