From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB63EC433C1 for ; Wed, 24 Mar 2021 16:57:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 794AC619D5 for ; Wed, 24 Mar 2021 16:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236669AbhCXQ4o (ORCPT ); Wed, 24 Mar 2021 12:56:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:44608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236954AbhCXQ4f (ORCPT ); Wed, 24 Mar 2021 12:56:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FB98619D5; Wed, 24 Mar 2021 16:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616604994; bh=IjT8ks42t54B0PsxkI6Yx9Mt8/2cYsxEH6Mf39wNzuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=psAd6bkZ609VOTv9dfgf5ceanQAZR12Lf2SizqoLgRO8CKQ3Hn+8Od0UxXLvDmVlb g3Z+lOwsxu21osfem/fZkaZ85xgMnrxZtegMcsIyWJ0ywTiiw9ZCLNtVNR7EpBKtP2 GngEfaClfOSa6H0ilQJ5POAvGhdxNV66vIWywPC1gOq5ObJTD8zWf9uTjH1KVVidKH KBBmMp8BM4wvOBZVkwA4qJk6BrgWsCegNT0QS55NmgDBSENPEvWTqaQpvMjfNAqoe7 RpW3A0F1XG6nt5GoBZoKTwVsIjQ4LhiJqLv5wQpfEk0Hn7zfXVAa600sXuZMGL2HVb 1DzF+YS6awdjw== Date: Wed, 24 Mar 2021 16:56:30 +0000 From: Will Deacon To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, marcan@marcan.st, maz@kernel.org, tglx@linutronix.de Subject: Re: [PATCHv3 4/6] arm64: entry: factor irq triage logic into macros Message-ID: <20210324165629.GC13030@willie-the-truck> References: <20210315115629.57191-1-mark.rutland@arm.com> <20210315115629.57191-5-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315115629.57191-5-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 11:56:27AM +0000, Mark Rutland wrote: > From: Marc Zyngier > > In subsequent patches we'll allow an FIQ handler to be registered, and > FIQ exceptions will need to be triaged very similarly to IRQ exceptions. > So that we can reuse the existing logic, this patch factors the IRQ > triage logic out into macros that can be reused for FIQ. > > The macros are named to follow the elX_foo_handler scheme used by the C > exception handlers. For consistency with other top-level exception > handlers, the kernel_entry/kernel_exit logic is not moved into the > macros. As FIQ will use a different C handler, this handler name is > provided as an argument to the macros. > > There should be no functional change as a result of this patch. > > Signed-off-by: Marc Zyngier > [Mark: rework macros, commit message, rebase before DAIF rework] > Signed-off-by: Mark Rutland > Tested-by: Hector Martin > Cc: Catalin Marinas > Cc: James Morse > Cc: Thomas Gleixner > Cc: Will Deacon > --- > arch/arm64/kernel/entry.S | 80 +++++++++++++++++++++++++---------------------- > 1 file changed, 43 insertions(+), 37 deletions(-) Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3636FC433C1 for ; Wed, 24 Mar 2021 16:58:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7DE161A10 for ; Wed, 24 Mar 2021 16:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7DE161A10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fp11+Zexa3UuF6O/f2HHAFBJ2TqSP9L4nLqwyqdfW+A=; b=kVl59fhmPABFcWHc1vZlA/+jb kG4FVmBjc8n6OH3/ByXnIS1gRTixYgdVMhAKIx4Dl8ESla1UugvIWSYG4HsNH05OlJ4lfhA5KrxjV puebFo6D4wKeb4LLQ/bH2Xp/vhBNTPZil6h5EuBgJdGuPKp/Ryv3uc2GaZX37Qo1kVSxbcQi6U/vV pgNRBoXwEO3QwFAY5u31h7UHR1RXqP1BQsKk5ZLEAoipfd+sevhb+YJT+XRx8Jaui4oMxqurEliJr x/tPpo1Ovi5Lxe0YL1WUi5dQa2Rc2vVoMhrxkp9WajpWdi4EZiUv53mlf1YDutJJ0mkIouECTZ6km dFwD/bqmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP6oC-00HSGo-LC; Wed, 24 Mar 2021 16:56:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP6o8-00HSG9-A1 for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 16:56:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FB98619D5; Wed, 24 Mar 2021 16:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616604994; bh=IjT8ks42t54B0PsxkI6Yx9Mt8/2cYsxEH6Mf39wNzuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=psAd6bkZ609VOTv9dfgf5ceanQAZR12Lf2SizqoLgRO8CKQ3Hn+8Od0UxXLvDmVlb g3Z+lOwsxu21osfem/fZkaZ85xgMnrxZtegMcsIyWJ0ywTiiw9ZCLNtVNR7EpBKtP2 GngEfaClfOSa6H0ilQJ5POAvGhdxNV66vIWywPC1gOq5ObJTD8zWf9uTjH1KVVidKH KBBmMp8BM4wvOBZVkwA4qJk6BrgWsCegNT0QS55NmgDBSENPEvWTqaQpvMjfNAqoe7 RpW3A0F1XG6nt5GoBZoKTwVsIjQ4LhiJqLv5wQpfEk0Hn7zfXVAa600sXuZMGL2HVb 1DzF+YS6awdjw== Date: Wed, 24 Mar 2021 16:56:30 +0000 From: Will Deacon To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, marcan@marcan.st, maz@kernel.org, tglx@linutronix.de Subject: Re: [PATCHv3 4/6] arm64: entry: factor irq triage logic into macros Message-ID: <20210324165629.GC13030@willie-the-truck> References: <20210315115629.57191-1-mark.rutland@arm.com> <20210315115629.57191-5-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315115629.57191-5-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_165636_551107_D82E57A2 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 11:56:27AM +0000, Mark Rutland wrote: > From: Marc Zyngier > > In subsequent patches we'll allow an FIQ handler to be registered, and > FIQ exceptions will need to be triaged very similarly to IRQ exceptions. > So that we can reuse the existing logic, this patch factors the IRQ > triage logic out into macros that can be reused for FIQ. > > The macros are named to follow the elX_foo_handler scheme used by the C > exception handlers. For consistency with other top-level exception > handlers, the kernel_entry/kernel_exit logic is not moved into the > macros. As FIQ will use a different C handler, this handler name is > provided as an argument to the macros. > > There should be no functional change as a result of this patch. > > Signed-off-by: Marc Zyngier > [Mark: rework macros, commit message, rebase before DAIF rework] > Signed-off-by: Mark Rutland > Tested-by: Hector Martin > Cc: Catalin Marinas > Cc: James Morse > Cc: Thomas Gleixner > Cc: Will Deacon > --- > arch/arm64/kernel/entry.S | 80 +++++++++++++++++++++++++---------------------- > 1 file changed, 43 insertions(+), 37 deletions(-) Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel