All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
	lorenzo.bianconi@redhat.com, devicetree@vger.kernel.org,
	sean.wang@mediatek.com, ryder.lee@mediatek.com,
	johannes@sipsolutions.net
Subject: Re: [PATCH v2 1/2] dt-bindings:net:wireless:ieee80211: txt to yaml conversion
Date: Wed, 24 Mar 2021 11:16:55 -0600	[thread overview]
Message-ID: <20210324171655.GA3266836@robh.at.kernel.org> (raw)
In-Reply-To: <3dca0518c14e3a8e563933c903de0d62429a3667.1615752835.git.lorenzo@kernel.org>

On Sun, Mar 14, 2021 at 09:21:06PM +0100, Lorenzo Bianconi wrote:
> Convert generic ieee80211 dts bindings from .txt to .yaml
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../bindings/net/wireless/ieee80211.txt       | 24 -----------
>  .../bindings/net/wireless/ieee80211.yaml      | 41 +++++++++++++++++++
>  2 files changed, 41 insertions(+), 24 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/net/wireless/ieee80211.txt
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt
> deleted file mode 100644
> index f6442b1397f5..000000000000
> --- a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Common IEEE 802.11 properties
> -
> -This provides documentation of common properties that are valid for all wireless
> -devices.
> -
> -Optional properties:
> - - ieee80211-freq-limit : list of supported frequency ranges in KHz. This can be
> -	used for devices that in a given config support less channels than
> -	normally. It may happen chipset supports a wide wireless band but it is
> -	limited to some part of it due to used antennas or power amplifier.
> -	An example case for this can be tri-band wireless router with two
> -	identical chipsets used for two different 5 GHz subbands. Using them
> -	incorrectly could not work or decrease performance noticeably.
> -
> -Example:
> -
> -pcie@0,0 {
> -	reg = <0x0000 0 0 0 0>;
> -	wifi@0,0 {
> -		reg = <0x0000 0 0 0 0>;
> -		ieee80211-freq-limit = <2402000 2482000>,
> -				       <5170000 5250000>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> new file mode 100644
> index 000000000000..6fb9ae7403c1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/ieee80211.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common IEEE 802.11 Binding
> +
> +maintainers:
> +  - Johannes Berg <johannes@sipsolutions.net>
> +
> +description: |
> +  This provides documentation of common properties that are valid for
> +  all wireless devices
> +
> +properties:
> +  ieee80211-freq-limit:

Needs a type ref:

$ref: /schemas/types.yaml#/definitions/uint32-matrix
items:
  minItems: 2
  maxItems: 2

> +    description:
> +      List of supported frequency ranges in KHz. This can be used for devices
> +      that in a given config support less channels than normally. It may happen
> +      chipset supports a wide wireless band but it is limited to some part of
> +      it due to used antennas or power amplifier. An example case for this
> +      can be tri-band wireless router with two identical chipsets used for two
> +      different 5 GHz subbands. Using them incorrectly could not work or
> +      decrease performance noticeably
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    pcie0 {
> +      #address-cells = <3>;
> +      #size-cells = <2>;
> +      wifi@0,0 {
> +        reg = <0x0000 0 0 0 0>;
> +        ieee80211-freq-limit = <2402000 2482000>,
> +                               <5170000 5250000>;
> +      };
> +    };
> -- 
> 2.29.2
> 

  reply	other threads:[~2021-03-24 17:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14 20:21 [PATCH v2 0/2] dt-bindings: convert mt76 and ieee80211 in yaml Lorenzo Bianconi
2021-03-14 20:21 ` [PATCH v2 1/2] dt-bindings:net:wireless:ieee80211: txt to yaml conversion Lorenzo Bianconi
2021-03-24 17:16   ` Rob Herring [this message]
2021-03-24 21:03   ` Johannes Berg
2021-03-24 21:17     ` Lorenzo Bianconi
2021-03-14 20:21 ` [PATCH v2 2/2] dt-bindings:net:wireless:mediatek,mt76: " Lorenzo Bianconi
2021-03-24 17:40   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324171655.GA3266836@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.