From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 658DFC433E0 for ; Wed, 24 Mar 2021 17:46:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BE1561A1E for ; Wed, 24 Mar 2021 17:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237199AbhCXRp5 (ORCPT ); Wed, 24 Mar 2021 13:45:57 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:45686 "EHLO mail-io1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236616AbhCXRpa (ORCPT ); Wed, 24 Mar 2021 13:45:30 -0400 Received: by mail-io1-f53.google.com with SMTP id k8so22392558iop.12; Wed, 24 Mar 2021 10:45:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WQOKKI3NBhlafu15L4AYHTsh8eoYcv2NYX3pxh4cbeY=; b=fLcPi0nCP9Nb7SG8qkTXoUMNre4sg5jXl6cwa/jxpJPIiXed8Okr3gJXcls+Nx5SXm bNq1KB1RL7QwgwVeQl2kQrojYjZUNxRVdtg0wvtRmNGllkQRvAYEJb2PfMp4JM7DFs5Z 1ZBuS1ycDYJkGlnKHHjI4OLHNbKdZKjK0boAR4NEkeaQZgL4cvNJwm9NKYeKCqOuoqxD Xxc0/JyT55dGDnCvKkbDryXISxnaiGa7tRD2+ap+mydZ7DsSt+yp1yXRotYT03A4jsdo nYP0wBZjGCmBMJjtsQQ+/8ClSWMhEck6emFVs89pgr1ZRyXVoRtQu0w4gOgC2piaVoI0 lGIw== X-Gm-Message-State: AOAM532ot5Ffod2oVEjIgMcNEA41KdkIXuid8JVkY/Jy2sgxre131Mk2 bHHqMEuMrcaQruQxGq/GcQaMX6eI16eK X-Google-Smtp-Source: ABdhPJykeeWlxXXZ603awX5WAKK6E91QipPknYAhmUz/+Kj3s31Ka3rSq1o62TNB0Nhkf4AldSTLRQ== X-Received: by 2002:a02:8801:: with SMTP id r1mr4013533jai.51.1616607929547; Wed, 24 Mar 2021 10:45:29 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id 14sm1439848ilt.54.2021.03.24.10.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:45:28 -0700 (PDT) Received: (nullmailer pid 3316165 invoked by uid 1000); Wed, 24 Mar 2021 17:45:25 -0000 Date: Wed, 24 Mar 2021 11:45:25 -0600 From: Rob Herring To: dillon min Cc: Alexandre TORGUE , rong.a.chen@intel.com, Ahmad Fatoum , Maxime Coquelin , Alexandre Torgue , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , Linux Kernel Mailing List , linux@armlinux.org.uk, Vladimir Murzin , afzal.mohd.ma@gmail.com, gregkh@linuxfoundation.org, erwan.leray@st.com, erwan.leray@foss.st.com, linux-serial@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs_check warrning Message-ID: <20210324174525.GA3309477@robh.at.kernel.org> References: <1615801436-3016-1-git-send-email-dillon.minfei@gmail.com> <1615801436-3016-10-git-send-email-dillon.minfei@gmail.com> <01c9f635-7b2b-fc9c-3cf9-6d7f425d683e@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 07:13:27PM +0800, dillon min wrote: > Hi Alexandre, > > Thanks for the reply. > > On Fri, Mar 19, 2021 at 4:38 PM Alexandre TORGUE > wrote: > > > > Hi Dillon > > > > On 3/19/21 5:28 AM, dillon min wrote: > > > No changes, Just loop lkp in. > > > > > > > > > Hi lkp, > > > > > > Sorry for the late reply, thanks for your report. > > > This patch is to fix the build warning message. > > > > > > Thanks. > > > Regards > > > > > > On Mon, Mar 15, 2021 at 5:45 PM wrote: > > >> > > >> From: dillon min > > >> > > >> when run make dtbs_check with 'bluetoothi brcm,bcm43438-bt' > > >> dts enabled on stm32h7, there is a warrning popup: > > >> > > >>>> arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800: 'bluetooth' > > >> does not match any of the regexes: 'pinctrl-[0-9]+' > > >> > > >> to make dtbs_check happy, so add a phandle bluetooth > > >> > > >> Fixes: 500cdb23d608 ("ARM: dts: stm32: Add STM32H743 MCU and STM32H743i-EVAL board") > > >> Signed-off-by: dillon min > > >> Reported-by: kernel test robot > > >> --- > > >> Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > > >> 1 file changed, 5 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > > >> index 8631678283f9..5e674840e62d 100644 > > >> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > > >> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > > >> @@ -50,6 +50,11 @@ properties: > > >> minItems: 1 > > >> maxItems: 2 > > >> > > >> + bluetooth: > > >> + type: object > > >> + description: | > > >> + phandles to the usart controller and bluetooth > > >> + > > > > Do we really need to add this "generic" property here ? You could test > > without the "AditionalProperties:False". > Yes, indeed. we have no reason to add a generic 'bluetooth' property > into specific soc's interface yaml. > I can't just remove "AditionalProperties:False", else make > O=../kernel-art/ dtbs dtbs_check will run into > > /home/fmin/linux/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml: > 'oneOf' conditional failed, one must be fixed: > 'unevaluatedProperties' is a required property > 'additionalProperties' is a required property > ... > > So , i will replace "AditionalProperties:False". with > unevaluatedProperties: false, do you agree with this? This is okay as long as 'serial.yaml' is referenced, but will eventually fail if not (unevaluatedProperties isn't actually implemented yet). > If so, i will send patch v4 later. Or you can do this: addtionalProperties: type: object Which means any other property has to be a node. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740BDC433C1 for ; Wed, 24 Mar 2021 17:47:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11B3C61A01 for ; Wed, 24 Mar 2021 17:47:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11B3C61A01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LhWfXt7EcgJkFxCn8frRnW7CxjMO7O79jTpJXtaDkIE=; b=HAhUSVt8S3PFJM/lwUsv5wG7W sl1PBHJdhoo1Cja4ciZb7ruyjUiJTYcRiyQUU8ue1tsoQb4h8N9p3bC8TX3gKZCltl+qZfSEhsAIt sHOJm3yLSaQGqjFchMCex/AQqAa08wZe1prigPos/C82tMVfl2S9RrvpbyHDQLISkI5XnYop7393M DIFOzhGHh2APWL2p+lPeccQ1SYM4B8YRtYi8XULk/MMVpL70A0OCVbo77HjhwJGIEbdbX8mHIMuDp QTyfEMUTxTxJv1k8id/lPjdr8uMqznxFblVZielY69Rc+9b5QvK4fwPDV/9Z1H0+p5Gd+xzvtiTs8 NjwLW/JtA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP7ZX-00Ha0q-C3; Wed, 24 Mar 2021 17:45:35 +0000 Received: from mail-io1-f41.google.com ([209.85.166.41]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP7ZT-00HZzG-C4 for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 17:45:33 +0000 Received: by mail-io1-f41.google.com with SMTP id n21so22410687ioa.7 for ; Wed, 24 Mar 2021 10:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WQOKKI3NBhlafu15L4AYHTsh8eoYcv2NYX3pxh4cbeY=; b=O174eQ4qOJKZGvJJ77Kp6sT5l1lu6KPeRlEY4OwZUQi5dCSkeaRB+pdnM5EoVcNeDh sSGGFWfWUpQc7mA7xuKjyVNVgSe0IGZawpXcKMyJikIqtduAv3uGWOsTvX9jjj9uvSbY Yt0V4p50SqDKl0jliAHe7e2JvTWsU23VHmdKX5gd8eDNphSzapzYAFo5AVJ5hRKeRRyg /j2iq6o/cwuxT/0HLMC/pHF054lCClrQi3FNVmJ/itKmCGd8TINqUUNbmNVEAEildzb7 F6vnUlP8JoGPEpmdqwbqnT7jKsf0tjAcsINFSoWUcQkZGfiomgjt4oVsiWbNzKeT2QrX XFwA== X-Gm-Message-State: AOAM531OQdvyJQ5MZEvpnfcsfadcBSptFDsi0f5BZq/rkpw8PSMUBgha ORYRs/SPrTAr3hExcGXu4Q== X-Google-Smtp-Source: ABdhPJykeeWlxXXZ603awX5WAKK6E91QipPknYAhmUz/+Kj3s31Ka3rSq1o62TNB0Nhkf4AldSTLRQ== X-Received: by 2002:a02:8801:: with SMTP id r1mr4013533jai.51.1616607929547; Wed, 24 Mar 2021 10:45:29 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id 14sm1439848ilt.54.2021.03.24.10.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:45:28 -0700 (PDT) Received: (nullmailer pid 3316165 invoked by uid 1000); Wed, 24 Mar 2021 17:45:25 -0000 Date: Wed, 24 Mar 2021 11:45:25 -0600 From: Rob Herring To: dillon min Cc: Alexandre TORGUE , rong.a.chen@intel.com, Ahmad Fatoum , Maxime Coquelin , Alexandre Torgue , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , Linux Kernel Mailing List , linux@armlinux.org.uk, Vladimir Murzin , afzal.mohd.ma@gmail.com, gregkh@linuxfoundation.org, erwan.leray@st.com, erwan.leray@foss.st.com, linux-serial@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs_check warrning Message-ID: <20210324174525.GA3309477@robh.at.kernel.org> References: <1615801436-3016-1-git-send-email-dillon.minfei@gmail.com> <1615801436-3016-10-git-send-email-dillon.minfei@gmail.com> <01c9f635-7b2b-fc9c-3cf9-6d7f425d683e@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_174531_499702_8EB4E7CF X-CRM114-Status: GOOD ( 29.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 19, 2021 at 07:13:27PM +0800, dillon min wrote: > Hi Alexandre, > > Thanks for the reply. > > On Fri, Mar 19, 2021 at 4:38 PM Alexandre TORGUE > wrote: > > > > Hi Dillon > > > > On 3/19/21 5:28 AM, dillon min wrote: > > > No changes, Just loop lkp in. > > > > > > > > > Hi lkp, > > > > > > Sorry for the late reply, thanks for your report. > > > This patch is to fix the build warning message. > > > > > > Thanks. > > > Regards > > > > > > On Mon, Mar 15, 2021 at 5:45 PM wrote: > > >> > > >> From: dillon min > > >> > > >> when run make dtbs_check with 'bluetoothi brcm,bcm43438-bt' > > >> dts enabled on stm32h7, there is a warrning popup: > > >> > > >>>> arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800: 'bluetooth' > > >> does not match any of the regexes: 'pinctrl-[0-9]+' > > >> > > >> to make dtbs_check happy, so add a phandle bluetooth > > >> > > >> Fixes: 500cdb23d608 ("ARM: dts: stm32: Add STM32H743 MCU and STM32H743i-EVAL board") > > >> Signed-off-by: dillon min > > >> Reported-by: kernel test robot > > >> --- > > >> Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > > >> 1 file changed, 5 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > > >> index 8631678283f9..5e674840e62d 100644 > > >> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > > >> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > > >> @@ -50,6 +50,11 @@ properties: > > >> minItems: 1 > > >> maxItems: 2 > > >> > > >> + bluetooth: > > >> + type: object > > >> + description: | > > >> + phandles to the usart controller and bluetooth > > >> + > > > > Do we really need to add this "generic" property here ? You could test > > without the "AditionalProperties:False". > Yes, indeed. we have no reason to add a generic 'bluetooth' property > into specific soc's interface yaml. > I can't just remove "AditionalProperties:False", else make > O=../kernel-art/ dtbs dtbs_check will run into > > /home/fmin/linux/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml: > 'oneOf' conditional failed, one must be fixed: > 'unevaluatedProperties' is a required property > 'additionalProperties' is a required property > ... > > So , i will replace "AditionalProperties:False". with > unevaluatedProperties: false, do you agree with this? This is okay as long as 'serial.yaml' is referenced, but will eventually fail if not (unevaluatedProperties isn't actually implemented yet). > If so, i will send patch v4 later. Or you can do this: addtionalProperties: type: object Which means any other property has to be a node. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel