From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC047C433E3 for ; Wed, 24 Mar 2021 18:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F07B61A25 for ; Wed, 24 Mar 2021 18:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237566AbhCXSYO (ORCPT ); Wed, 24 Mar 2021 14:24:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:44346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237532AbhCXSYD (ORCPT ); Wed, 24 Mar 2021 14:24:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AC2C61923; Wed, 24 Mar 2021 18:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616610242; bh=K6oHNv+C7LY+kAhzbl3PH+/kTu3OVjYksdUZOBHFlLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZKt+MCQzHYhfjqUgacgIFrJphqDrv1Ohu4AIGdvpFurBScBaJjDll3mZalfUguou0 D+UymlPgk6SPAtFY/tg8jfWe7ktbau3fj4JqqAGepn5WkxoPDHDRk3/Dg2etkgycQv B9Bc4YgGOUCyscy2AS2fUwl9hGSoB2FV8UGZWN0EL652pnnjP210+rCXaW/uRv9dU8 uXfI9Pe3t5Idmq4bfVv5mj9KDAiwKdTmY7xrMxtCFc/1QQ519ap8BTIwBfby74g1DV K23ZCo4Xdr6HtfqgQ9Gj573yQ8rKnX2Uh70JgA6/Mz4uLUW9PduLcbjWsAHO8zdJnv s5BIhlSmLU3qQ== Date: Wed, 24 Mar 2021 18:23:55 +0000 From: Will Deacon To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH v3 14/27] arm64: move ICH_ sysreg bits from arm-gic-v3.h to sysreg.h Message-ID: <20210324182355.GE13181@willie-the-truck> References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-15-marcan@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304213902.83903-15-marcan@marcan.st> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 06:38:49AM +0900, Hector Martin wrote: > These definitions are in arm-gic-v3.h for historical reasons which no > longer apply. Move them to sysreg.h so the AIC driver can use them, as > it needs to peek into vGIC registers to deal with the GIC maintentance > interrupt. > > Signed-off-by: Hector Martin > --- > arch/arm64/include/asm/sysreg.h | 60 ++++++++++++++++++++++++++++++ > include/linux/irqchip/arm-gic-v3.h | 56 ---------------------------- > 2 files changed, 60 insertions(+), 56 deletions(-) This would be much easier to remove if you just moved the definitions, rather than reordered than and changed the comments at the same time! But I *think* nothing had changed, so: Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FCA0C433DB for ; Wed, 24 Mar 2021 18:25:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD9E761A0E for ; Wed, 24 Mar 2021 18:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD9E761A0E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WvC3s7fLbQAnlXIaSD9/DDMKyj2qWckv0FtTld8eXDw=; b=nS6vmSe8v5H4MMh+G7nRkSymh En3opfhx3QCq1YF04zJC31mc/ZzaidHHSskJuJd2+1vMQvWLnNDTo9pZsdU0rlreTHTfAFn1RV3Az xkINSQBz2969DW381xBG1CKgUw0+7sY0h2uTWSJ/mCErvX0bsSHWeHwbDb8un5yV1phDObeEUUWSN E8dyv4uFe9kf8QSBOQ6kS3GLYe7n7KaN540lPe2WB1a/AlYPirfpWI2mhPE6eKvqJMkQ1r/4T+syR furEkgdjG3ZSIcerED6oqtpZ/sMVy02E/U6M9+i6XuGCK6vJnrn7yxTdgCr6XHpOUU18hcTxnDxjI KzmusgB5g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP8Aq-0002rH-KX; Wed, 24 Mar 2021 18:24:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP8Am-0002qh-5m for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 18:24:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AC2C61923; Wed, 24 Mar 2021 18:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616610242; bh=K6oHNv+C7LY+kAhzbl3PH+/kTu3OVjYksdUZOBHFlLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZKt+MCQzHYhfjqUgacgIFrJphqDrv1Ohu4AIGdvpFurBScBaJjDll3mZalfUguou0 D+UymlPgk6SPAtFY/tg8jfWe7ktbau3fj4JqqAGepn5WkxoPDHDRk3/Dg2etkgycQv B9Bc4YgGOUCyscy2AS2fUwl9hGSoB2FV8UGZWN0EL652pnnjP210+rCXaW/uRv9dU8 uXfI9Pe3t5Idmq4bfVv5mj9KDAiwKdTmY7xrMxtCFc/1QQ519ap8BTIwBfby74g1DV K23ZCo4Xdr6HtfqgQ9Gj573yQ8rKnX2Uh70JgA6/Mz4uLUW9PduLcbjWsAHO8zdJnv s5BIhlSmLU3qQ== Date: Wed, 24 Mar 2021 18:23:55 +0000 From: Will Deacon To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH v3 14/27] arm64: move ICH_ sysreg bits from arm-gic-v3.h to sysreg.h Message-ID: <20210324182355.GE13181@willie-the-truck> References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-15-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210304213902.83903-15-marcan@marcan.st> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_182404_570873_FACDF165 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 06:38:49AM +0900, Hector Martin wrote: > These definitions are in arm-gic-v3.h for historical reasons which no > longer apply. Move them to sysreg.h so the AIC driver can use them, as > it needs to peek into vGIC registers to deal with the GIC maintentance > interrupt. > > Signed-off-by: Hector Martin > --- > arch/arm64/include/asm/sysreg.h | 60 ++++++++++++++++++++++++++++++ > include/linux/irqchip/arm-gic-v3.h | 56 ---------------------------- > 2 files changed, 60 insertions(+), 56 deletions(-) This would be much easier to remove if you just moved the definitions, rather than reordered than and changed the comments at the same time! But I *think* nothing had changed, so: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel